[PATCH] packagegroup-core-base-utils.bb: check the gplv3 license

[PATCH] packagegroup-core-base-utils.bb: check the gplv3 license

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

packagegroup-core-base-utils repends on some packages which are
gplv3 compatilbe.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 .../packagegroups/packagegroup-core-base-utils.bb  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
index 1e63da7f16..0a3cb63bc2 100644
--- a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
+++ b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
@@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
     grep \
     gzip \
     ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "", "ifupdown", d)} \
-    inetutils \
-    inetutils-ping \
-    inetutils-telnet \
-    inetutils-tftp \
-    inetutils-traceroute \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-ping', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-telnet', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-tftp', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-traceroute', d)} \
     iproute2 \
     ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd", "", d)} \
     kmod \
     less \
     ncurses-tools \
     net-tools \
-    parted \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'parted', d)} \
     patch \
     procps \
     psmisc \
@@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
     unzip \
     util-linux \
     ${VIRTUAL-RUNTIME_vim} \
-    wget \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'wget', d)} \
     which \
     xz \
     "
-- 
2.26.2

Re: [OE-core] [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]

I’m not sure I like this approach. It doesn’t look like the right place to
decide whether to include or not some packages based on specific licensing
requirements, licenses for these and other items change over time, and
there may be more undesirable licenses than just this one.

Why not simply create a new package group?

Alex

On Fri 18. Dec 2020 at 6.37, Yu, Mingli <mingli.yu@windriver.com> wrote:

> From: Mingli Yu <mingli.yu@windriver.com>
>
> packagegroup-core-base-utils repends on some packages which are
> gplv3 compatilbe.
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  .../packagegroups/packagegroup-core-base-utils.bb  | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-extended/packagegroups/
> packagegroup-core-base-utils.bb b/meta/recipes-extended/packagegroups/
> packagegroup-core-base-utils.bb
> index 1e63da7f16..0a3cb63bc2 100644
> --- a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> +++ b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> @@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
>      grep \
>      gzip \
>      ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "", "ifupdown",
> d)} \
> -    inetutils \
> -    inetutils-ping \
> -    inetutils-telnet \
> -    inetutils-tftp \
> -    inetutils-traceroute \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-ping', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-telnet', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-tftp', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-traceroute', d)} \
>      iproute2 \
>      ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd", "", d)} \
>      kmod \
>      less \
>      ncurses-tools \
>      net-tools \
> -    parted \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'parted',
> d)} \
>      patch \
>      procps \
>      psmisc \
> @@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
>      unzip \
>      util-linux \
>      ${VIRTUAL-RUNTIME_vim} \
> -    wget \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'wget', d)}
> \
>      which \
>      xz \
>      "
> --
> 2.26.2
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 3929 bytes --]

Re: [OE-core] [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license

[Randy MacLeod]

On 2020-12-18 2:47 a.m., Alexander Kanavin wrote:
> I’m not sure I like this approach. It doesn’t look like the right place 
> to decide whether to include or not some packages based on specific 
> licensing requirements, licenses for these and other items change over 
> time, and there may be more undesirable licenses than just this one.
> 
> Why not simply create a new package group?
> 
> Alex

Makes sense to me, Mingli?

I'm replying months later because I see that we fixed this locally
without getting agreement with Alex and other oe-core devs. Not a
big deal but we want to minimize our collection of WR specific patches.

../Randy
> 
> On Fri 18. Dec 2020 at 6.37, Yu, Mingli <mingli.yu@windriver.com 
> <mailto:mingli.yu@windriver.com>> wrote:
> 
>     From: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
> 
>     packagegroup-core-base-utils repends on some packages which are
>     gplv3 compatilbe.
> 
>     Signed-off-by: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
>     ---
>       .../packagegroups/packagegroup-core-base-utils.bb
>     <http://packagegroup-core-base-utils.bb>  | 14 +++++++-------
>       1 file changed, 7 insertions(+), 7 deletions(-)
> 
>     diff --git
>     a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     index 1e63da7f16..0a3cb63bc2 100644
>     ---
>     a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     +++
>     b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     @@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
>           grep \
>           gzip \
>           ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "",
>     "ifupdown", d)} \
>     -    inetutils \
>     -    inetutils-ping \
>     -    inetutils-telnet \
>     -    inetutils-tftp \
>     -    inetutils-traceroute \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-ping', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-telnet', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-tftp', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-traceroute', d)} \
>           iproute2 \
>           ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd",
>     "", d)} \
>           kmod \
>           less \
>           ncurses-tools \
>           net-tools \
>     -    parted \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'parted', d)} \
>           patch \
>           procps \
>           psmisc \
>     @@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
>           unzip \
>           util-linux \
>           ${VIRTUAL-RUNTIME_vim} \
>     -    wget \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'wget', d)} \
>           which \
>           xz \
>           "
>     -- 
>     2.26.2
> 
> 
> 
> 
> 
> 
> 
> 


-- 
# Randy MacLeod
# Wind River Linux