From: "Joshua Watt" <JPEWhacker@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Dominik Schmidt <ds@technokrat.ch>, Joshua Watt <JPEWhacker@gmail.com>
Subject: [OE-core][PATCH] fetch2: git: Append the password to the username on git URI reassembling
Date: Thu, 14 Jan 2021 10:11:53 -0600 [thread overview]
Message-ID: <20210114161153.17719-1-JPEWhacker@gmail.com> (raw)
From: Dominik Schmidt <ds@technokrat.ch>
This allows the users to specify SRC_URIs of the form
git://user:password@host.tld/path/to/repo.git
which allows pulling in private repositories.
[YOCTO #14065]
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
bitbake/lib/bb/fetch2/git.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index df9538a60d..a1356ed9f0 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -606,7 +606,10 @@ class Git(FetchMethod):
# removing the password. ssh keys, ~/.netrc and ~/.ssh/config files can be used as
# alternatives so we will not take patches adding password support here.
if ud.user:
- username = ud.user + '@'
+ username = ud.user
+ if ud.pswd:
+ username += ":" + ud.pswd
+ username += "@"
else:
username = ""
return "%s://%s%s%s" % (ud.proto, username, ud.host, ud.path)
--
2.30.0
next reply other threads:[~2021-01-14 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 16:11 Joshua Watt [this message]
2021-01-14 16:14 ` [OE-core][PATCH] fetch2: git: Append the password to the username on git URI reassembling Joshua Watt
2021-01-14 16:52 ` Quentin Schulz
2021-01-14 16:55 ` Joshua Watt
2021-01-14 20:16 ` Khem Raj
2021-01-14 20:18 ` Joshua Watt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114161153.17719-1-JPEWhacker@gmail.com \
--to=jpewhacker@gmail.com \
--cc=ds@technokrat.ch \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox