Re: [OE-core][PATCH] fetch2: git: Append the password to the username on git URI reassembling

["Joshua Watt" <JPEWhacker@gmail.com>]

Argh, sorry. This is not what we want.... I was supposed to make a 
different change and forgot :(

On 1/14/21 10:11 AM, Joshua Watt wrote:
> From: Dominik Schmidt <ds@technokrat.ch>
>
> This allows the users to specify SRC_URIs of the form
> git://user:password@host.tld/path/to/repo.git
>
> which allows pulling in private repositories.
>
> [YOCTO #14065]
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>   bitbake/lib/bb/fetch2/git.py | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
> index df9538a60d..a1356ed9f0 100644
> --- a/bitbake/lib/bb/fetch2/git.py
> +++ b/bitbake/lib/bb/fetch2/git.py
> @@ -606,7 +606,10 @@ class Git(FetchMethod):
>           # removing the password. ssh keys, ~/.netrc and ~/.ssh/config files can be used as
>           # alternatives so we will not take patches adding password support here.
>           if ud.user:
> -            username = ud.user + '@'
> +            username = ud.user
> +            if ud.pswd:
> +                username += ":" + ud.pswd
> +            username += "@"
>           else:
>               username = ""
>           return "%s://%s%s%s" % (ud.proto, username, ud.host, ud.path)