[[PATCH] cve-check.bbclass: don't skip scanning if file not found

[[PATCH] cve-check.bbclass: don't skip scanning if file not found

[akuster]

This helps avoid these errors:
ERROR: lockdev-1_1.0.3-r0 do_cve_check: File Not found: /home/build/builds/master/tmp/work/core2-64-poky-linux/lockdev/1_1.0.3-r0/lockdev_1.0.3-1.6.diff

We should continuing to scan other applied patches for CVE info.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta/classes/cve-check.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 1bed815d8e4..e56366579d1 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -186,8 +186,8 @@ def get_patches_cves(d):
         patch_file = bb.fetch.decodeurl(url)[2]
 
         if not os.path.isfile(patch_file):
-            bb.error("File Not found: %s" % patch_file)
-            raise FileNotFoundError
+            bb.warn("File Not found: %s" % patch_file)
+            continue
 
         # Check patch file name for CVE ID
         fname_match = cve_file_name_match.search(patch_file)
-- 
2.25.1

Re: [OE-core] [[PATCH] cve-check.bbclass: don't skip scanning if file not found

[Ross Burton]

Why is the file not found though?

Ross

On Mon, 15 Feb 2021 at 22:41, akuster <akuster808@gmail.com> wrote:
>
> This helps avoid these errors:
> ERROR: lockdev-1_1.0.3-r0 do_cve_check: File Not found: /home/build/builds/master/tmp/work/core2-64-poky-linux/lockdev/1_1.0.3-r0/lockdev_1.0.3-1.6.diff
>
> We should continuing to scan other applied patches for CVE info.
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta/classes/cve-check.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
> index 1bed815d8e4..e56366579d1 100644
> --- a/meta/classes/cve-check.bbclass
> +++ b/meta/classes/cve-check.bbclass
> @@ -186,8 +186,8 @@ def get_patches_cves(d):
>          patch_file = bb.fetch.decodeurl(url)[2]
>
>          if not os.path.isfile(patch_file):
> -            bb.error("File Not found: %s" % patch_file)
> -            raise FileNotFoundError
> +            bb.warn("File Not found: %s" % patch_file)
> +            continue
>
>          # Check patch file name for CVE ID
>          fname_match = cve_file_name_match.search(patch_file)
> --
> 2.25.1
>
>
> 
>

Re: [OE-core] [[PATCH] cve-check.bbclass: don't skip scanning if file not found

[akuster]

On 2/18/21 8:50 AM, Ross Burton wrote:
> Why is the file not found though?
its downloaded there for not in the WORKDIR

-armin


>
> Ross
>
> On Mon, 15 Feb 2021 at 22:41, akuster <akuster808@gmail.com> wrote:
>> This helps avoid these errors:
>> ERROR: lockdev-1_1.0.3-r0 do_cve_check: File Not found: /home/build/builds/master/tmp/work/core2-64-poky-linux/lockdev/1_1.0.3-r0/lockdev_1.0.3-1.6.diff
>>
>> We should continuing to scan other applied patches for CVE info.
>>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta/classes/cve-check.bbclass | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
>> index 1bed815d8e4..e56366579d1 100644
>> --- a/meta/classes/cve-check.bbclass
>> +++ b/meta/classes/cve-check.bbclass
>> @@ -186,8 +186,8 @@ def get_patches_cves(d):
>>          patch_file = bb.fetch.decodeurl(url)[2]
>>
>>          if not os.path.isfile(patch_file):
>> -            bb.error("File Not found: %s" % patch_file)
>> -            raise FileNotFoundError
>> +            bb.warn("File Not found: %s" % patch_file)
>> +            continue
>>
>>          # Check patch file name for CVE ID
>>          fname_match = cve_file_name_match.search(patch_file)
>> --
>> 2.25.1
>>
>>
>> 
>>