Re: [OE-core] [RFC][PATCH] sstatesig.py: show an error instead of warning when sstate manifest isn't found

["Martin Jansa" <Martin.Jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3252 bytes --]

On Tue, Feb 23, 2021 at 02:35:53PM +0100, Martin Jansa via lists.openembedded.org wrote:
> * not sure if there are some valid use-cases for missing manifest, but
>   recently I'm seeing increasing number of build failures where something
>   from native recipe is missing (seen it with pseudo, autoconf, nodejs
>   recently) and the only indication that something is wrong (before showing
>   sometimes misleading error like:
>   recipe-sysroot-native/usr/bin/node: No such file or directory
>   is this warning:
>   NOTE: Running task 7844 of 12431 (/meta-oe/meta-oe/recipes-devtools/nodejs/nodejs_12.20.2.bb:do_prepare_recipe_sysroot)
>   NOTE: recipe nodejs-12.20.2-r0: task do_prepare_recipe_sysroot: Started
>   WARNING: nodejs-12.20.2-r0 do_prepare_recipe_sysroot: Manifest /BUILD/sstate-control/manifest-x86_64_ubuntu-18.04-nodejs-native.populate_sysroot not found in x86_64 x86_64_ubuntu-18.04 (variant '')?
>   NOTE: Running task 7845 of 12431 (/meta-oe/meta-oe/recipes-devtools/nodejs/nodejs_12.20.2.bb:do_unpack)
>   NOTE: recipe nodejs-12.20.2-r0: task do_unpack: Started
>   WARNING: nodejs-12.20.2-r0 do_prepare_recipe_sysroot: Manifest /BUILD/sstate-control/manifest-x86_64_ubuntu-18.04-nodejs-native.populate_sysroot not found in x86_64 x86_64_ubuntu-18.04 (variant '')?
>   NOTE: recipe nodejs-12.20.2-r0: task do_prepare_recipe_sysroot: Succeeded
> 
>   if I rebuild that native dependency, then it gets fixed and I don't
>   see these failures in clean builds (as without sstate and with empty
>   TMPDIR), only in incremental builds
> 
> * but if there isn't valid reason for missing manifest file, then I think
>   it would be better to error early (or even bb.fatal())

Looks like this warning was first introduced in 2014:
https://git.openembedded.org/openembedded-core/commit/?id=79ea036de331bde65a88fb777647dc099ef05acf
then extended and updated for RSS in:
https://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
then added for package management in:
https://git.openembedded.org/openembedded-core/commit/?id=85e72e129362db896b0d368077033e4a2e373cf9
and then unified last 2 to common function in:
https://git.openembedded.org/openembedded-core/commit/?id=68150bac7444f089f19c789e9f6602d59f605d7a

> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/lib/oe/sstatesig.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/sstatesig.py b/meta/lib/oe/sstatesig.py
> index 84999ee94d..6cd6e11acc 100644
> --- a/meta/lib/oe/sstatesig.py
> +++ b/meta/lib/oe/sstatesig.py
> @@ -453,7 +453,7 @@ def find_sstate_manifest(taskdata, taskdata2, taskname, d, multilibcache):
>          manifest = d2.expand("${SSTATE_MANIFESTS}/manifest-%s-%s.%s" % (pkgarch, taskdata, taskname))
>          if os.path.exists(manifest):
>              return manifest, d2
> -    bb.warn("Manifest %s not found in %s (variant '%s')?" % (manifest, d2.expand(" ".join(pkgarchs)), variant))
> +    bb.error("Manifest %s not found in %s (variant '%s')?" % (manifest, d2.expand(" ".join(pkgarchs)), variant))
>      return None, d2
>
>  def OEOuthashBasic(path, sigfile, task, d):
> -- 
> 2.27.0
> 

> 
> 
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]