Re: [OE-core] [RFC][PATCH] sstatesig.py: show an error instead of warning when sstate manifest isn't found

["Martin Jansa" <Martin.Jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3326 bytes --]

On Fri, Mar 12, 2021 at 05:41:50PM -0500, Denys Dmytriyenko wrote:
> On Fri, Feb 26, 2021 at 03:53:38PM +0000, Richard Purdie wrote:
> > On Tue, 2021-02-23 at 14:51 +0100, Martin Jansa wrote:
> > > On Tue, Feb 23, 2021 at 02:35:53PM +0100, Martin Jansa via lists.openembedded.org wrote:
> > > > * not sure if there are some valid use-cases for missing manifest, but
> > > >   recently I'm seeing increasing number of build failures where something
> > > >   from native recipe is missing (seen it with pseudo, autoconf, nodejs
> > > >   recently) and the only indication that something is wrong (before showing
> > > >   sometimes misleading error like:
> > > >   recipe-sysroot-native/usr/bin/node: No such file or directory
> > > >   is this warning:
> > > >   NOTE: Running task 7844 of 12431 (/meta-oe/meta-oe/recipes-devtools/nodejs/nodejs_12.20.2.bb:do_prepare_recipe_sysroot)
> > > >   NOTE: recipe nodejs-12.20.2-r0: task do_prepare_recipe_sysroot: Started
> > > >   WARNING: nodejs-12.20.2-r0 do_prepare_recipe_sysroot: Manifest /BUILD/sstate-control/manifest-x86_64_ubuntu-18.04-nodejs-native.populate_sysroot not found in x86_64 x86_64_ubuntu-18.04 (variant '')?
> > > >   NOTE: Running task 7845 of 12431 (/meta-oe/meta-oe/recipes-devtools/nodejs/nodejs_12.20.2.bb:do_unpack)
> > > >   NOTE: recipe nodejs-12.20.2-r0: task do_unpack: Started
> > > >   WARNING: nodejs-12.20.2-r0 do_prepare_recipe_sysroot: Manifest /BUILD/sstate-control/manifest-x86_64_ubuntu-18.04-nodejs-native.populate_sysroot not found in x86_64 x86_64_ubuntu-18.04 (variant '')?
> > > >   NOTE: recipe nodejs-12.20.2-r0: task do_prepare_recipe_sysroot: Succeeded
> > > > 
> > > >   if I rebuild that native dependency, then it gets fixed and I don't
> > > >   see these failures in clean builds (as without sstate and with empty
> > > >   TMPDIR), only in incremental builds
> > > > 
> > > > * but if there isn't valid reason for missing manifest file, then I think
> > > >   it would be better to error early (or even bb.fatal())
> > > 
> > > Looks like this warning was first introduced in 2014:
> > > https://git.openembedded.org/openembedded-core/commit/?id=79ea036de331bde65a88fb777647dc099ef05acf
> > > then extended and updated for RSS in:
> > > https://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
> > > then added for package management in:
> > > https://git.openembedded.org/openembedded-core/commit/?id=85e72e129362db896b0d368077033e4a2e373cf9
> > > and then unified last 2 to common function in:
> > > https://git.openembedded.org/openembedded-core/commit/?id=68150bac7444f089f19c789e9f6602d59f605d7a
> > 
> > I merged this. There were cases where the warning showed in cases where
> > there wasn't a problem but I think we've fixed all those now.
> 
> Richard, Martin,
> 
> Can you please point me to the right way of fixing this? I've been seeing 
> this warning before and since it is now an error and backported to Dunfell, 
> it breaks builds one in a while.

Do you see this error triggered on initramfs manifest used by your
kernel? See this thread for possible work arounds:
https://lists.openembedded.org/g/openembedded-core/topic/81249042#149271

but maybe you have some different corner case which will need different
fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]