* [PATCH] libnotify: Make gtk+3 dependency optional
@ 2021-05-13 14:36 Mike Crowe
2021-05-13 14:43 ` [OE-core] " Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Mike Crowe @ 2021-05-13 14:36 UTC (permalink / raw)
To: openembedded-core; +Cc: Mike Crowe
libnotify only requires gtk+3 for its tests. Let's disable them by
default.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-gnome/libnotify/libnotify_0.7.9.bb b/meta/recipes-gnome/libnotify/libnotify_0.7.9.bb
index bbbd72193e..819cb304f7 100644
--- a/meta/recipes-gnome/libnotify/libnotify_0.7.9.bb
+++ b/meta/recipes-gnome/libnotify/libnotify_0.7.9.bb
@@ -9,15 +9,16 @@ SECTION = "libs"
LICENSE = "LGPLv2.1"
LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
-DEPENDS = "dbus gtk+3 glib-2.0"
+DEPENDS = "dbus glib-2.0 gdk-pixbuf"
+
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
GNOMEBASEBUILDCLASS = "meson"
GTKDOC_MESON_OPTION = "gtk_doc"
GIR_MESON_ENABLE_FLAG = "enabled"
GIR_MESON_DISABLE_FLAG = "disabled"
inherit gnomebase gtk-doc features_check gobject-introspection
-# depends on gtk+3
-ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
SRC_URI[archive.md5sum] = "ccd9c53364174cc8d13e18a1988faa76"
SRC_URI[archive.sha256sum] = "66c0517ed16df7af258e83208faaf5069727dfd66995c4bbc51c16954d674761"
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional
2021-05-13 14:36 [PATCH] libnotify: Make gtk+3 dependency optional Mike Crowe
@ 2021-05-13 14:43 ` Alexander Kanavin
2021-05-13 14:46 ` Mike Crowe
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexander Kanavin @ 2021-05-13 14:43 UTC (permalink / raw)
To: yocto; +Cc: OE-core, Mike Crowe
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <yocto=
mac.mcrowe.com@lists.openembedded.org> wrote:
> +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
>
Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s
seems weird.
Alex
[-- Attachment #2: Type: text/html, Size: 684 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional
2021-05-13 14:43 ` [OE-core] " Alexander Kanavin
@ 2021-05-13 14:46 ` Mike Crowe
2021-05-13 15:24 ` Khem Raj
2021-05-13 16:06 ` Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Mike Crowe @ 2021-05-13 14:46 UTC (permalink / raw)
To: Alexander Kanavin, OE-core
On Thursday 13 May 2021 at 16:43:15 +0200, Alexander Kanavin wrote:
> On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <yocto=
> mac.mcrowe.com@lists.openembedded.org> wrote:
>
> > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> >
>
> Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s
> seems weird.
You're right. That does look odd. This is actually an old patch I hoovered
up after upgrading and didn't retest it. I'll do some more testing...
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional
2021-05-13 14:43 ` [OE-core] " Alexander Kanavin
2021-05-13 14:46 ` Mike Crowe
@ 2021-05-13 15:24 ` Khem Raj
2021-05-13 16:06 ` Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2021-05-13 15:24 UTC (permalink / raw)
To: Alexander Kanavin, yocto; +Cc: OE-core, Mike Crowe
On 5/13/21 7:43 AM, Alexander Kanavin wrote:
> On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org
> <http://lists.openembedded.org>
> <yocto=mac.mcrowe.com@lists.openembedded.org
> <mailto:mac.mcrowe.com@lists.openembedded.org>> wrote:
>
> +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
>
>
> Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s
> seems weird.
it is valid if tests need gtk+3 at runtime, but not during build time,
in that case you only create rdep as above.
>
> Alex
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional
2021-05-13 14:43 ` [OE-core] " Alexander Kanavin
2021-05-13 14:46 ` Mike Crowe
2021-05-13 15:24 ` Khem Raj
@ 2021-05-13 16:06 ` Richard Purdie
2021-05-13 16:11 ` Mike Crowe
2 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2021-05-13 16:06 UTC (permalink / raw)
To: Alexander Kanavin, yocto; +Cc: OE-core, Mike Crowe
On Thu, 2021-05-13 at 16:43 +0200, Alexander Kanavin wrote:
> On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <
> yocto=mac.mcrowe.com@lists.openembedded.org> wrote:
> > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> >
>
>
> Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s seems weird.
It means to add a runtime (RDEPENDS) rather than DEPENDS. There are
options for positions 5 and 6 too if I remember rightly.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional
2021-05-13 16:06 ` Richard Purdie
@ 2021-05-13 16:11 ` Mike Crowe
0 siblings, 0 replies; 6+ messages in thread
From: Mike Crowe @ 2021-05-13 16:11 UTC (permalink / raw)
To: Richard Purdie, Alexander Kanavin, OE-core
On Thursday 13 May 2021 at 17:06:23 +0100, Richard Purdie wrote:
> On Thu, 2021-05-13 at 16:43 +0200, Alexander Kanavin wrote:
> > On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <
> > yocto=mac.mcrowe.com@lists.openembedded.org> wrote:
> > > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> > >
> >
> >
> > Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s seems weird.
>
> It means to add a runtime (RDEPENDS) rather than DEPENDS. There are
> options for positions 5 and 6 too if I remember rightly.
Yes, but it should have been a build dependency. :( Alexander was correct
to draw attention to it. It turns out that the whole line is wrong because
I failed to spot that master is now using Meson too. :(
A better patch will be arriving shortly.
Thanks.
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-13 16:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-13 14:36 [PATCH] libnotify: Make gtk+3 dependency optional Mike Crowe
2021-05-13 14:43 ` [OE-core] " Alexander Kanavin
2021-05-13 14:46 ` Mike Crowe
2021-05-13 15:24 ` Khem Raj
2021-05-13 16:06 ` Richard Purdie
2021-05-13 16:11 ` Mike Crowe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox