public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Mike Crowe" <yocto@mac.mcrowe.com>
To: Philip Lorenz <philip@bithub.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [pseudo][PATCH] test: Add missing test-statx test case
Date: Wed, 11 Aug 2021 18:19:25 +0100	[thread overview]
Message-ID: <20210811171925.GA15765@mcrowe.com> (raw)
In-Reply-To: <20210811164132.74849-1-philip@bithub.de>

On Wednesday 11 August 2021 at 18:41:32 +0200, Philip Lorenz wrote:
> Adding this test case was erroneously omitted in
> 7c722296879906fe093e1e7c4b7537e150d492cd.
> 
> Signed-off-by: Philip Lorenz <philip@bithub.de>
> ---
>  test/test-statx.c  | 20 ++++++++++++++++++++
>  test/test-statx.sh |  6 ++++++
>  2 files changed, 26 insertions(+)
>  create mode 100644 test/test-statx.c
>  create mode 100755 test/test-statx.sh
> 
> diff --git a/test/test-statx.c b/test/test-statx.c
> new file mode 100644
> index 0000000..06d86af
> --- /dev/null
> +++ b/test/test-statx.c
> @@ -0,0 +1,20 @@
> +/*
> + * Test that passing NULL to a parameter marked as nonnull works correctly
> + * SPDX-License-Identifier: LGPL-2.1-only
> + *
> + */
> +#define _GNU_SOURCE
> +
> +#include <sys/stat.h>
> +#include <unistd.h>
> +#include <fcntl.h>
> +
> +// Passing a null pointer is the test scenario
> +#pragma GCC diagnostic ignored "-Wnonnull"
> +
> +int main(void) {
> +    if (statx(0, NULL, 0, 0, NULL) != -1) {
> +        return 1;
> +    }
> +    return 0;
> +}
> diff --git a/test/test-statx.sh b/test/test-statx.sh
> new file mode 100755
> index 0000000..77d0302
> --- /dev/null
> +++ b/test/test-statx.sh
> @@ -0,0 +1,6 @@
> +#!/bin/bash
> +#
> +# SPDX-License-Identifier: LGPL-2.1-only
> +#
> +
> +exec ./test/test-statx
> -- 
> 2.32.0
> 

> 
> 
> 

Applying this patch (along with <169A4FE272BB166C.28384@lists.openembedded.org>)
makes all the tests pass for me. However, the run of test-statx.sh causes:

 couldn't allocate absolute path for '(null)'.

to be printed.

Thanks.

Mike.

  reply	other threads:[~2021-08-11 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 16:41 [pseudo][PATCH] test: Add missing test-statx test case Philip Lorenz
2021-08-11 17:19 ` Mike Crowe [this message]
2021-08-15 12:50   ` [OE-core] " Philip Lorenz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811171925.GA15765@mcrowe.com \
    --to=yocto@mac.mcrowe.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=philip@bithub.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox