From: Lukasz Majewski <lukma@denx.de>
To: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: "Florian Weimer" <fweimer@redhat.com>,
"Fāng-ruì Sòng" <maskray@google.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"Patches and discussions about the oe-core layer"
<openembedded-core@lists.openembedded.org>,
"Andreas Schwab" <schwab@linux-m68k.org>,
"Joseph Myers" <joseph@codesourcery.com>,
"Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM
Date: Mon, 25 Oct 2021 16:04:44 +0200 [thread overview]
Message-ID: <20211025160444.09f0c5e0@ktm> (raw)
In-Reply-To: <20211025133425.GN1982710@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Hi Szabolcs,
> The 10/25/2021 12:53, Lukasz Majewski wrote:
> > Hi Florian,
> >
> > > * Lukasz Majewski:
> > >
> > > > Do we have any idea on how to move forward with this issue?
> > >
> > > Either fix the prelink tool not to prelink shared objects that do
> > > not have a dependency on libc.so.6, or fix the dynamic loader to
> > > work if prelinked on AArch64.
> >
> > Just for the correctness - both 64 and 32 bit ARMs are affected.
>
> last time i looked, prelinking did not support tlsdesc
> correctly so it is unusable for aarch64.
>
> does yocto/oe use prelinking on aarch64?
I think yes - the
USER_CLASSES ?= "buildstats image-prelink"
is added by default to local.conf
>
> >
> > > I do not have a strong opinion.
> >
> > Thanks for your opinion. Let's wait for other community members
> > opinions.
>
> i think fixing the arm load address computation makes
> sense (small extra cost of a relative reloc). i think
> the c code proposal i made in the thread is nicer than
> the old asm.
>
> (i'm happy to make the same change on aarch64 too if
> prelinking is used there, but i think that's broken.)
+1
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-25 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210907131616.23472-1-lukma@denx.de>
[not found] ` <20211015075417.29931-1-lukma@denx.de>
[not found] ` <20211015120915.GD1982710@arm.com>
[not found] ` <CAMe9rOpPM7RmA65MzTNr2DtoC_wMFt87mnyJ4pgvmK5TAorCCQ@mail.gmail.com>
2021-10-15 12:59 ` [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM Lukasz Majewski
[not found] ` <CAFP8O3+DBOregW5SuaPErkHUt+5aqb=bL98wHGtXu-OwFwud+w@mail.gmail.com>
[not found] ` <20211018110818.GE1982710@arm.com>
[not found] ` <871r4iftvc.fsf@oldenburg.str.redhat.com>
2021-10-19 12:03 ` Lukasz Majewski
2021-10-25 10:18 ` Lukasz Majewski
[not found] ` <878ryhwgd7.fsf@oldenburg.str.redhat.com>
2021-10-25 10:53 ` Lukasz Majewski
[not found] ` <20211025133425.GN1982710@arm.com>
2021-10-25 14:04 ` Lukasz Majewski [this message]
[not found] ` <20211025150904.GO1982710@arm.com>
2021-10-25 18:25 ` Lukasz Majewski
[not found] ` <alpine.DEB.2.22.394.2110251718420.1572984@digraph.polyomino.org.uk>
2021-10-26 13:52 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025160444.09f0c5e0@ktm \
--to=lukma@denx.de \
--cc=Szabolcs.Nagy@arm.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox