Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Alexander Kanavin <alex@linutronix.de>
Subject: [PATCH 03/14] rust-llvm: apply the same reproducibility patch as for llvm proper
Date: Sun,  9 Jan 2022 23:27:21 +0100	[thread overview]
Message-ID: <20220109222732.2252416-3-alex@linutronix.de> (raw)
In-Reply-To: <20220109222732.2252416-1-alex@linutronix.de>

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/lib/oeqa/selftest/cases/reproducible.py  |  4 ---
 meta/recipes-devtools/rust/rust-llvm.inc      |  3 +-
 ...r-sort-ClassInfo-lists-by-name-as-we.patch | 31 +++++++++++++++++++
 3 files changed, 33 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-devtools/rust/rust-llvm/0001-AsmMatcherEmitter-sort-ClassInfo-lists-by-name-as-we.patch

diff --git a/meta/lib/oeqa/selftest/cases/reproducible.py b/meta/lib/oeqa/selftest/cases/reproducible.py
index a0dc76977f..e539365031 100644
--- a/meta/lib/oeqa/selftest/cases/reproducible.py
+++ b/meta/lib/oeqa/selftest/cases/reproducible.py
@@ -17,11 +17,7 @@ import stat
 import os
 import datetime
 
-# rust-llvm:
-#https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20210825-kaihham6/
 exclude_packages = [
-	'rust-llvm-liblto',
-	'rust-llvm-staticdev'
 	]
 
 def is_excluded(package):
diff --git a/meta/recipes-devtools/rust/rust-llvm.inc b/meta/recipes-devtools/rust/rust-llvm.inc
index 0f8fb785b7..5c2ccdac9a 100644
--- a/meta/recipes-devtools/rust/rust-llvm.inc
+++ b/meta/recipes-devtools/rust/rust-llvm.inc
@@ -2,7 +2,8 @@ SUMMARY = "LLVM compiler framework (packaged with rust)"
 LICENSE ?= "Apache-2.0-with-LLVM-exception"
 HOMEPAGE = "http://www.rust-lang.org"
 
-SRC_URI += "file://0002-llvm-allow-env-override-of-exe-path.patch;striplevel=2"
+SRC_URI += "file://0002-llvm-allow-env-override-of-exe-path.patch;striplevel=2 \
+            file://0001-AsmMatcherEmitter-sort-ClassInfo-lists-by-name-as-we.patch;striplevel=2"
 
 S = "${RUSTSRC}/src/llvm-project/llvm"
 
diff --git a/meta/recipes-devtools/rust/rust-llvm/0001-AsmMatcherEmitter-sort-ClassInfo-lists-by-name-as-we.patch b/meta/recipes-devtools/rust/rust-llvm/0001-AsmMatcherEmitter-sort-ClassInfo-lists-by-name-as-we.patch
new file mode 100644
index 0000000000..48af6fc283
--- /dev/null
+++ b/meta/recipes-devtools/rust/rust-llvm/0001-AsmMatcherEmitter-sort-ClassInfo-lists-by-name-as-we.patch
@@ -0,0 +1,31 @@
+From 86940d87026432683fb6741cd8a34d3b9b18e40d Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Fri, 27 Nov 2020 10:11:08 +0000
+Subject: [PATCH] AsmMatcherEmitter: sort ClassInfo lists by name as well
+
+Otherwise, there are instances which are identical in
+every other field and therefore sort non-reproducibly
+(which breaks binary and source reproducibiliy).
+
+Upstream-Status: Submitted [https://reviews.llvm.org/D97477]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+---
+ llvm/utils/TableGen/AsmMatcherEmitter.cpp | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/llvm/utils/TableGen/AsmMatcherEmitter.cpp b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
+index ccf0959389b..1f801e83b7d 100644
+--- a/llvm/utils/TableGen/AsmMatcherEmitter.cpp
++++ b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
+@@ -359,7 +359,10 @@ public:
+     // name of a class shouldn't be significant. However, some of the backends
+     // accidentally rely on this behaviour, so it will have to stay like this
+     // until they are fixed.
+-    return ValueName < RHS.ValueName;
++    if (ValueName != RHS.ValueName)
++        return ValueName < RHS.ValueName;
++    // All else being equal, we should sort by name, for source and binary reproducibility
++    return Name < RHS.Name;
+   }
+ };
+ 
-- 
2.20.1



  parent reply	other threads:[~2022-01-09 22:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 22:27 [PATCH 01/14] python3: drop unneeded multiprocessing module patch Alexander Kanavin
2022-01-09 22:27 ` [PATCH 02/14] ruby: disable rdoc due to non-reproducibility Alexander Kanavin
2022-01-09 22:27 ` Alexander Kanavin [this message]
2022-01-09 22:27 ` [PATCH 04/14] busybox: update 1.34.1 -> 1.35.0 Alexander Kanavin
2022-01-10 15:09   ` [OE-core] " akuster808
     [not found]   ` <16C8F145D420B770.27414@lists.openembedded.org>
2022-01-10 15:10     ` Armin Kuster
2022-01-09 22:27 ` [PATCH 05/14] systemd: update 249.7 -> 250.1 Alexander Kanavin
2022-01-09 22:27 ` [PATCH 06/14] python3-numpy: update 1.21.4 -> 1.22.0 Alexander Kanavin
2022-01-09 22:27 ` [PATCH 07/14] mdadm: update 4.1 -> 4.2 Alexander Kanavin
2022-01-09 22:27 ` [PATCH 08/14] librsvg: update 2.52.4 -> 2.52.5 Alexander Kanavin
2022-01-09 22:27 ` [PATCH 09/14] libportal: update 0.4 -> 0.5 Alexander Kanavin
2022-01-09 22:27 ` [PATCH 10/14] epiphany: make libportal optional, and move it to meta-oe Alexander Kanavin
2022-01-10 18:43   ` [OE-core] " Khem Raj
2022-01-10 18:49     ` Alexander Kanavin
2022-01-10 18:57       ` Khem Raj
2022-01-10 19:18         ` Alexander Kanavin
2022-01-10 20:54           ` Khem Raj
2022-01-11  7:49             ` Khem Raj
2022-01-11  8:48               ` Alexander Kanavin
2022-01-11 19:44                 ` Khem Raj
2022-01-09 22:27 ` [PATCH 11/14] qemuboot/runqemu: fully form the ip= kernel parameter Alexander Kanavin
2022-01-09 22:27 ` [PATCH 12/14] parselogs: add a couple systemd false positives Alexander Kanavin
2022-01-09 22:27 ` [PATCH 13/14] connman: do nothing in qemu, do not touch eth0 Alexander Kanavin
2022-01-11 10:54   ` [OE-core] " Richard Purdie
2022-01-11 11:02     ` Alexander Kanavin
2022-01-11 11:08       ` Richard Purdie
2022-01-11 11:10         ` Alexander Kanavin
2022-01-11 11:15           ` Richard Purdie
2022-01-09 22:27 ` [PATCH 14/14] systemd-boot: restore reproducibility Alexander Kanavin
2022-01-10 13:59 ` [OE-core] [PATCH 01/14] python3: drop unneeded multiprocessing module patch Richard Purdie
2022-01-10 14:21   ` Alexander Kanavin
2022-01-10 14:23     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220109222732.2252416-3-alex@linutronix.de \
    --to=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox