Re: [OE-core] [PATCH 13/14] connman: do nothing in qemu, do not touch eth0

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2022-01-09 at 23:27 +0100, Alexander Kanavin wrote:
> qemu kernel itself is nowdays perfectly capable of setting up
> what was passed in via ip=:
> 
> [    1.676847] IP-Config: Complete:
> [    1.677768]      device=eth0, hwaddr=52:54:00:12:34:02, ipaddr=192.168.7.2, mask=255.255.255.0, gw=192.168.7.1
> [    1.679933]      host=192.168.7.2, domain=, nis-domain=(none)
> [    1.681201]      bootserver=255.255.255.255, rootserver=255.255.255.255, rootpath=
> [    1.681203]      nameserver0=8.8.8.8
> 
> connman-conf only does the same thing again by (badly and incompletely)
> parsing those parameters with sed.
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> 
[...]

> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 748eefa748..07049fbf21 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -101,6 +101,12 @@ do_install:append() {
>      fi
>  }
>  
> +# Kernel IP-Config is perfectly capable of setting up networking passed in via ip=
> +do_install:append:qemuall() {
> +    mkdir -p ${D}${sysconfdir}/default
> +    echo "export EXTRA_PARAM=\"-I eth0\"" > ${D}${sysconfdir}/default/connman
> +}
> +
>  # These used to be plugins, but now they are core
>  RPROVIDES:${PN} = "\
>  	connman-plugin-loopback \

This means connman becomes machine specific, you can't do that. This would need
to be done in the connman-conf recipe.

Cheers,

Richard