Openembedded Core Discussions
 help / color / mirror / Atom feed
* [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable
@ 2022-04-12 13:08 Alex Kiernan
  2022-04-13  9:29 ` [OE-core] " Luca Ceresoli
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Kiernan @ 2022-04-12 13:08 UTC (permalink / raw)
  To: openembedded-core; +Cc: Alex Kiernan

This has been unused since:

  commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
  Author: Richard Purdie <richard@openedhand.com>
  Date:   Mon Jan 8 21:05:18 2007 +0000

      kernel.bbclass: Drop KERNEL_RELEASE variable

      git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123 311d38ba-8fff-0310-9ca6-ca027cbcb966

Signed-off-by: Alex Kiernan <alexk@zuma.ai>
---
 meta/classes/kernel.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 7ca847f0a341..cd900edd5cb6 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -221,8 +221,6 @@ export CMDLINE_CONSOLE = "console=${@d.getVar("KERNEL_CONSOLE") or "ttyS0"}"
 
 KERNEL_VERSION = "${@get_kernelversion_headers('${B}')}"
 
-KERNEL_LOCALVERSION ?= ""
-
 # kernels are generally machine specific
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-- 
2.35.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable
  2022-04-12 13:08 [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable Alex Kiernan
@ 2022-04-13  9:29 ` Luca Ceresoli
  2022-04-13 13:28   ` Alex Kiernan
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Ceresoli @ 2022-04-13  9:29 UTC (permalink / raw)
  To: Alex Kiernan; +Cc: openembedded-core, Alex Kiernan

Hello Alex,

Il giorno Tue, 12 Apr 2022 14:08:18 +0100
"Alex Kiernan" <alex.kiernan@gmail.com> ha scritto:

> This has been unused since:
> 
>   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
>   Author: Richard Purdie <richard@openedhand.com>
>   Date:   Mon Jan 8 21:05:18 2007 +0000
> 
>       kernel.bbclass: Drop KERNEL_RELEASE variable
> 
>       git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> 311d38ba-8fff-0310-9ca6-ca027cbcb966
> 
> Signed-off-by: Alex Kiernan <alexk@zuma.ai>

This patch has [meta-oe] in the subject line but it is indeed for
oe-core. No need to resend it, I've taken it for autobuilders testing
already, however this is something you should possibly fix in future
patches.

The same applies to the 8-patch series you sent a few minutes earlier.

Best regards
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable
  2022-04-13  9:29 ` [OE-core] " Luca Ceresoli
@ 2022-04-13 13:28   ` Alex Kiernan
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Kiernan @ 2022-04-13 13:28 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: Patches and discussions about the oe-core layer, Alex Kiernan

On Wed, Apr 13, 2022 at 10:29 AM Luca Ceresoli
<luca.ceresoli@bootlin.com> wrote:
>
> Hello Alex,
>
> Il giorno Tue, 12 Apr 2022 14:08:18 +0100
> "Alex Kiernan" <alex.kiernan@gmail.com> ha scritto:
>
> > This has been unused since:
> >
> >   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
> >   Author: Richard Purdie <richard@openedhand.com>
> >   Date:   Mon Jan 8 21:05:18 2007 +0000
> >
> >       kernel.bbclass: Drop KERNEL_RELEASE variable
> >
> >       git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> > 311d38ba-8fff-0310-9ca6-ca027cbcb966
> >
> > Signed-off-by: Alex Kiernan <alexk@zuma.ai>
>
> This patch has [meta-oe] in the subject line but it is indeed for
> oe-core. No need to resend it, I've taken it for autobuilders testing
> already, however this is something you should possibly fix in future
> patches.
>
> The same applies to the 8-patch series you sent a few minutes earlier.
>

Thank you!

-- 
Alex Kiernan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-13 15:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 13:08 [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable Alex Kiernan
2022-04-13  9:29 ` [OE-core] " Luca Ceresoli
2022-04-13 13:28   ` Alex Kiernan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox