[PATCH 0/1] wic/plugins/images/direct: Allow changes in fstab on rootfs

[PATCH 0/1] wic/plugins/images/direct: Allow changes in fstab on rootfs

[Tobias Schmidl]

This patch removes the exclusion of `/` in the fstab update. This is
useful for a lot of things, including but not limited to:
- The setting of `fspassno`, proposed as "[PATCH v2] wic: added fspassno parameter to partition"
- The writing of `fsoptions`

The latter is used for example for systemd-growfs:

```
part / --fstype ext4 --fsoptions "defaults,x-systemd.growfs" --fspassno 1 --align 1024 --part-type 8304 --use-uuid
```

Tobias Schmidl (1):
  wic/plugins/images/direct: Allow changes in fstab on rootfs

 scripts/lib/wic/plugins/imager/direct.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.36.1

[PATCH 1/1] wic/plugins/images/direct: Allow changes in fstab on rootfs

[Tobias Schmidl]

Allow wic to also manipulate the rootfs entry in fstab, which it
currently refuses to write. Reasons one might want to do that include
using systemd-growfs via --fsoptions on /
With this change / is now handled exactly the same as other
mountpoints, the former exception seemingly was not even documented.

Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
---
 scripts/lib/wic/plugins/imager/direct.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/wic/plugins/imager/direct.py b/scripts/lib/wic/plugins/imager/direct.py
index da483daed5..c44159b235 100644
--- a/scripts/lib/wic/plugins/imager/direct.py
+++ b/scripts/lib/wic/plugins/imager/direct.py
@@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin):
         updated = False
         for part in self.parts:
             if not part.realnum or not part.mountpoint \
-               or part.mountpoint == "/" or not part.mountpoint.startswith('/'):
+               or not part.mountpoint.startswith('/'):
                 continue
 
             if part.use_uuid:
-- 
2.36.1

Re: [OE-core] [PATCH 1/1] wic/plugins/images/direct: Allow changes in fstab on rootfs

[Luca Ceresoli]

Hello Tobias,

Il giorno Tue, 17 May 2022 20:48:16 +0200
"Tobias Schmidl" <tobiasschmidl@siemens.com> ha scritto:

> Allow wic to also manipulate the rootfs entry in fstab, which it
> currently refuses to write. Reasons one might want to do that include
> using systemd-growfs via --fsoptions on /
> With this change / is now handled exactly the same as other
> mountpoints, the former exception seemingly was not even documented.
> 
> Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>

The autobuilders found some errors while building with this patch on my
testing branch:

https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3600/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3544/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3566/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3606/steps/14/logs/stdio

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH 1/1] wic/plugins/images/direct: Allow changes in fstab on rootfs

[Schmidl, Tobias]

Hello Luca,

Am Donnerstag, dem 19.05.2022 um 15:34 +0200 schrieb Luca Ceresoli:
> 
> > Allow wic to also manipulate the rootfs entry in fstab, which it
> > currently refuses to write. Reasons one might want to do that include
> > using systemd-growfs via --fsoptions on /
> > With this change / is now handled exactly the same as other
> > mountpoints, the former exception seemingly was not even documented.
> > 
> > Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
> 
> The autobuilders found some errors while building with this patch on my
> testing branch:
> 

thanks, will look into it.

Kind regards,

Tobias