Re: [OE-core] [PATCH] rootfs.py: find .ko.zst kernel modules

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hi Sean,

Il giorno Tue, 31 May 2022 11:10:52 -0400
"Sean Anderson via lists.openembedded.org"
<sean.anderson=seco.com@lists.openembedded.org> ha scritto:

> With CONFIG_MODULE_COMPRESS_ZSTD enabled, kernel modules will have a
> .ko.zst extension. This fixes depmod not being run.
> 
> Fixes: 1b696a45ddb ("rootfs.py: Add check for kernel modules before running depmod")

We can't blame this commit done in 2015 for not having implemented
MODULE_COMPRESS_ZSTD, added in the kernel in 2021.

And actually I don't think there is anything to fix here, but rather we
have a feature that was non-existing in the past, now it exists and we
want to support it.

So I'm taking this patch in my testing branch with the 'Fixes:' line
removed.

> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
> 
>  meta/lib/oe/rootfs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
> index 98cf3f244d4..61ccf369f12 100644
> --- a/meta/lib/oe/rootfs.py
> +++ b/meta/lib/oe/rootfs.py
> @@ -311,7 +311,7 @@ class Rootfs(object, metaclass=ABCMeta):
>      def _check_for_kernel_modules(self, modules_dir):
>          for root, dirs, files in os.walk(modules_dir, topdown=True):
>              for name in files:
> -                found_ko = name.endswith((".ko", ".ko.gz", ".ko.xz"))
> +                found_ko = name.endswith((".ko", ".ko.gz", ".ko.xz", ".ko.zst"))
>                  if found_ko:
>                      return found_ko
>          return False



-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com