Re: [OE-core] [PATCH] rootfs.py: find .ko.zst kernel modules

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hi Sean,

On Thu, 2 Jun 2022 10:52:59 -0400
"Sean Anderson via lists.openembedded.org"
<sean.anderson=seco.com@lists.openembedded.org> wrote:

> Hi Luca,
> 
> On 6/1/22 3:13 AM, Luca Ceresoli wrote:
> > [You don't often get email from luca.ceresoli@bootlin.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification.]
> > 
> > Hi Sean,
> > 
> > Il giorno Tue, 31 May 2022 11:10:52 -0400
> > "Sean Anderson via lists.openembedded.org"
> > <sean.anderson=seco.com@lists.openembedded.org> ha scritto:
> > 
> > As you can see from the above line, your e-mails appear as coming from
> > an inappropriate address. This is not your fault, it's a mangling done
> > by mail servers, but it makes applying patches more complex.
> > 
> > It should be easy to fix, at least enough to allow patches to apply
> > properly, by setting the sendemail.from parameter in your git config.
> > This should force outgoing patches to start with a 'From:' line in the
> > body, and that one is used by git am to take the correct commit author
> > e-mail.
> > 
> > Can you please try that before sending another patch?
> > 
> > Thank you!  
> 
> I believe the From header is being modified by the openembedded mailing
> list. On my local email client I see the correct From. Further, git
> send-email reports the correct From as well:

Sure, this is absolutely *not* your fault!

This is done by DMARC (https://en.wikipedia.org/wiki/DMARC) as part of
anti-phishing and the like and it happend on some domains, including
the one I am using as you can see. The issue has already been discussed
but as far as I know if you are hit by it there is currently no better
alternative than using the git sendemail.from field to put an
*additional* From line at the beginning of the body.

When people receive an e-mail from the mailing list, it will look like:

------------------------8<------------------------
From: "Sean Anderson via lists.openembedded.org" <sean.anderson=seco.com@lists.openembedded.org>
To: openembedded-core@lists.openembedded.org
Cc: Christophe Chapuis <chris.chapuis@gmail.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>,
	Martin Jansa <Martin.Jansa@gmail.com>,
	Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH] rootfs.py: find .ko.zst kernel modules
Date: Tue, 31 May 2022 11:10:52 -0400
Message-Id: <20220531151052.3667079-1-sean.anderson@seco.com>
X-Mailer: git-send-email 2.35.1.1320.gc452695387.dirty
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Sean Anderson <sean.anderson@seco.com>     <---- THIS ONE

...your original commit message + diff...
------------------------8<------------------------

See the additional 'From:' line in the body. Since it is in the body and
not in the header, DMARC won't mangle it. 'git am' will use it for the
Author: field and remove it from the commit message.

I suggest you (and anybody affected by the issue) to try and see: it's
simpler to do it than to explain it! :-)

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com