Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paulo Neves <ptsneves@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Paulo Neves <ptsneves@gmail.com>
Subject: [PATCH v5 1/7] python: Avoid shebang overflow on python-config.py
Date: Tue, 14 Jun 2022 17:10:59 +0200	[thread overview]
Message-ID: <20220614151105.1890454-1-ptsneves@gmail.com> (raw)
In-Reply-To: <20220606155807.1414519-1-ptsneves@gmail.com>

The native path may be too big, leading to shebang
overflow. Just use the #!/usr/bin/env python3.

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
---
 ...shebang-overflow-on-python-config.py.patch | 33 +++++++++++++++++++
 .../recipes-devtools/python/python3_3.10.4.bb |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch

diff --git a/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch b/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
new file mode 100644
index 0000000000..921da8de7c
--- /dev/null
+++ b/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
@@ -0,0 +1,33 @@
+From f0c9dec63d452a7cd1e15ea653f4aced281f021c Mon Sep 17 00:00:00 2001
+From: Paulo Neves <ptsneves@gmail.com>
+Date: Tue, 7 Jun 2022 16:16:41 +0200
+Subject: [PATCH 1/1] Avoid shebang overflow on python-config.py
+
+The whole native path may be too big, leading to shebang
+overflow. Let's just use the env shebang.
+
+Denial reason: [1]
+
+Upstream-Status: Denied [distribution]
+
+[1] https://github.com/python/cpython/pull/93760#pullrequestreview-1005365737
+---
+ Makefile.pre.in | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Makefile.pre.in b/Makefile.pre.in
+index f0aedb76cb58999427804255da56fa53284d7032..dd88e43114730f7681715777cc76dabb31113176 100644
+--- a/Makefile.pre.in
++++ b/Makefile.pre.in
+@@ -1638,6 +1638,8 @@ python-config: $(srcdir)/Misc/python-config.in Misc/python-config.sh
+ 	@ # Substitution happens here, as the completely-expanded BINDIR
+ 	@ # is not available in configure
+ 	sed -e "s,@EXENAME@,$(BINDIR)/python$(LDVERSION)$(EXE)," < $(srcdir)/Misc/python-config.in >python-config.py
++	@ # Otherwise we might get huge shebangs with native paths
++	sed -i -e '1s|^#!.*|#!/usr/bin/env python3|' python-config.py
+ 	@ # Replace makefile compat. variable references with shell script compat. ones; $(VAR) -> ${VAR}
+ 	LC_ALL=C sed -e 's,\$$(\([A-Za-z0-9_]*\)),\$$\{\1\},g' < Misc/python-config.sh >python-config
+ 	@  # In OpenEmbedded, always use the python version of the script, the shell
+-- 
+2.25.1
+
diff --git a/meta/recipes-devtools/python/python3_3.10.4.bb b/meta/recipes-devtools/python/python3_3.10.4.bb
index 6bd3a6aba8..357025f856 100644
--- a/meta/recipes-devtools/python/python3_3.10.4.bb
+++ b/meta/recipes-devtools/python/python3_3.10.4.bb
@@ -34,6 +34,7 @@ SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
            file://0001-Lib-pty.py-handle-stdin-I-O-errors-same-way-as-maste.patch \
            file://0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch \
            file://deterministic_imports.patch \
+           file://0001-Avoid-shebang-overflow-on-python-config.py.patch \
            "
 
 SRC_URI:append:class-native = " \
-- 
2.25.1



  parent reply	other threads:[~2022-06-14 15:11 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 15:58 [PATCH 1/3] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-06 15:58 ` [PATCH 2/3] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-06 15:58 ` [PATCH 3/3] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-07 15:11 ` [PATCH v2 1/5] python: Avoid shebang overflow on python-config.py Paulo Neves
2022-06-07 15:11   ` [PATCH v2 2/5] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2 Paulo Neves
2022-06-07 15:11   ` [PATCH v2 3/5] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-07 15:11   ` [PATCH v2 4/5] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-08 12:53     ` [OE-core] " Luca Ceresoli
2022-06-08 14:45       ` Paulo Neves
2022-06-08 15:02         ` Luca Ceresoli
     [not found]     ` <16F6A653C457F871.26104@lists.openembedded.org>
2022-06-08 15:06       ` Luca Ceresoli
2022-06-13 11:20         ` Paulo Neves
2022-06-15 11:04     ` Ross Burton
2022-06-07 15:11   ` [PATCH v2 5/5] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-07 16:53   ` [OE-core] [PATCH v2 1/5] python: Avoid shebang overflow on python-config.py Alexander Kanavin
2022-06-07 20:03     ` Paulo Neves
2022-06-07 22:09       ` Alexander Kanavin
2022-06-10 21:43 ` [PATCH v3 1/7] " Paulo Neves
2022-06-10 21:43   ` [PATCH v3 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2 Paulo Neves
2022-06-10 21:43   ` [PATCH v3 3/7] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-10 21:43   ` [PATCH v3 4/7] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-10 21:43   ` [PATCH v3 5/7] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-10 21:43   ` [PATCH v3 6/7] utils: Add cmdline_shebang_wrapper util Paulo Neves
2022-06-10 21:43   ` [PATCH v3 7/7] libcheck: Fix too long shebang for native case Paulo Neves
2022-06-13  7:30   ` [OE-core] [PATCH v3 1/7] python: Avoid shebang overflow on python-config.py Alexander Kanavin
2022-06-13 10:32     ` Paulo Neves
2022-06-13 12:36       ` Alexander Kanavin
2022-06-14 13:16 ` [PATCH v4 " Paulo Neves
2022-06-14 13:16   ` [PATCH v4 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2 Paulo Neves
2022-06-14 13:16   ` [PATCH v4 3/7] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-14 13:16   ` [PATCH v4 4/7] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-14 13:16   ` [PATCH v4 5/7] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-14 13:16   ` [PATCH v4 6/7] utils: Add cmdline_shebang_wrapper util Paulo Neves
2022-06-14 13:39     ` [OE-core] " Martin Jansa
2022-06-14 13:46       ` Paulo Neves
2022-06-14 14:17         ` Martin Jansa
2022-06-14 15:12           ` Paulo Neves
2022-06-14 13:16   ` [PATCH v4 7/7] libcheck: Fix too long shebang for native case Paulo Neves
2022-06-14 15:10 ` Paulo Neves [this message]
2022-06-14 15:11   ` [PATCH v5 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2 Paulo Neves
2022-06-14 15:11   ` [PATCH v5 3/7] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-17 16:50     ` [OE-core] " Richard Purdie
2022-06-19 10:53       ` Paulo Neves
     [not found]     ` <16F97685B484595E.1329@lists.openembedded.org>
2022-07-01 12:53       ` Richard Purdie
2022-06-14 15:11   ` [PATCH v5 4/7] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-14 15:11   ` [PATCH v5 5/7] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-14 15:11   ` [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper util Paulo Neves
2022-06-15 10:52     ` [OE-core] " Ross Burton
2022-06-15 13:11       ` Peter Kjellerstedt
2022-06-15 13:50         ` Paulo Neves
2022-06-15 22:16           ` Peter Kjellerstedt
2022-06-19 19:03             ` Paulo Neves
2022-06-14 15:11   ` [PATCH v5 7/7] libcheck: Fix too long shebang for native case Paulo Neves
2022-06-15 11:07 ` [OE-core] [PATCH 1/3] insane.bbclass: Make do_qa_staging check shebangs Ross Burton
2022-06-15 11:08   ` Ross Burton
2022-06-15 11:09     ` Paulo Neves
2022-06-19 19:20 ` [PATCH v6 1/7] python: Avoid shebang overflow on python-config.py Paulo Neves
2022-06-19 19:20   ` [PATCH v6 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2 Paulo Neves
2022-06-19 19:20   ` [PATCH v6 3/7] insane.bbclass: Make do_qa_staging check shebangs Paulo Neves
2022-06-19 19:20   ` [PATCH v6 4/7] oeqa/selftest: Add test for shebang overflow Paulo Neves
2022-06-19 19:20   ` [PATCH v6 5/7] oeqa/selftest: Test staged .la and .pc files Paulo Neves
2022-06-19 19:20   ` [PATCH v6 6/7] utils: Add cmdline_shebang_wrapper util Paulo Neves
2022-07-05  4:50     ` [OE-core] " Jacob Kroon
2022-06-19 19:20   ` [PATCH v6 7/7] libcheck: Fix too long shebang for native case Paulo Neves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614151105.1890454-1-ptsneves@gmail.com \
    --to=ptsneves@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox