RE: [OE-core] [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper util.

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Ross Burton
> Sent: den 15 juni 2022 12:52
> To: ptsneves@gmail.com
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper
> util.
> 
> On 14 Jun 2022, at 16:11, Paulo Neves via lists.openembedded.org
> <ptsneves=gmail.com@lists.openembedded.org> wrote:
> > +create_cmdline_shebang_wrapper () {
> 
> The indentation in this function is a mix of tabs and spaces, please
> unify.
> 
> > +  argument="$(basename "$(head -n1 $cmd | sed -e 's|#![ ]*||g' )”)”
> 
> [ ]* seems overly, complex, no need for the brackets. I’d anchor to the
> beginning of the line, and remove the g as there’s only one expected.

This should work:

argument=$(basename "$(sed -ne 's/^#! *//p;q')" $cmd)

However, if the first line is something like "#!/usr/bin/env python3", then 
$argument will be "env python3" and somehow I assume that is not exactly 
what the rest of the code expects.

> 
> Might also be wise to assert that you found something here, so running
> this on an ELF fails with an obvious error.
> 
> Ross

//Peter