public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v3 2/2] systemd: add usrmerge to REQUIRED_DISTRO_FEATURES
Date: Wed, 13 Jul 2022 17:55:33 +0100	[thread overview]
Message-ID: <20220713165533.125600-2-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20220713165533.125600-1-luca.boccassi@gmail.com>

From: Luca Boccassi <luca.boccassi@microsoft.com>

Support for unmerged-usr is deprecated upstream, taints the system and will be
removed in the near future.
Enforce building merged-usr images when using systemd.

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v3: use += without :append

 meta/recipes-core/systemd/systemd-compat-units.bb | 2 +-
 meta/recipes-core/systemd/systemd-serialgetty.bb  | 2 +-
 meta/recipes-core/systemd/systemd.inc             | 5 +++++
 meta/recipes-core/systemd/systemd_251.2.bb        | 2 +-
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
index 55ebf99117..8831578010 100644
--- a/meta/recipes-core/systemd/systemd-compat-units.bb
+++ b/meta/recipes-core/systemd/systemd-compat-units.bb
@@ -14,7 +14,7 @@ INHIBIT_DEFAULT_DEPS = "1"
 
 ALLOW_EMPTY:${PN} = "1"
 
-REQUIRED_DISTRO_FEATURES = "systemd"
+REQUIRED_DISTRO_FEATURES += "systemd"
 
 SYSTEMD_DISABLED_SYSV_SERVICES = " \
   busybox-udhcpc \
diff --git a/meta/recipes-core/systemd/systemd-serialgetty.bb b/meta/recipes-core/systemd/systemd-serialgetty.bb
index fd888bb834..0987c3f416 100644
--- a/meta/recipes-core/systemd/systemd-serialgetty.bb
+++ b/meta/recipes-core/systemd/systemd-serialgetty.bb
@@ -14,7 +14,7 @@ S = "${WORKDIR}"
 
 # As this package is tied to systemd, only build it when we're also building systemd.
 inherit features_check
-REQUIRED_DISTRO_FEATURES = "systemd"
+REQUIRED_DISTRO_FEATURES += "systemd"
 
 do_install() {
 	if [ ! -z "${SERIAL_CONSOLES}" ] ; then
diff --git a/meta/recipes-core/systemd/systemd.inc b/meta/recipes-core/systemd/systemd.inc
index b8dbe2263a..f9e109bba4 100644
--- a/meta/recipes-core/systemd/systemd.inc
+++ b/meta/recipes-core/systemd/systemd.inc
@@ -21,3 +21,8 @@ SRC_URI = "git://github.com/systemd/systemd-stable.git;protocol=https;branch=${S
 "
 
 S = "${WORKDIR}/git"
+
+# unmerged-usr support is deprecated upstream, taints the system and will be
+# removed in the near future. Fail the build if it is not enabled.
+inherit features_check
+REQUIRED_DISTRO_FEATURES = "usrmerge"
diff --git a/meta/recipes-core/systemd/systemd_251.2.bb b/meta/recipes-core/systemd/systemd_251.2.bb
index bb3c59f418..ade2e61676 100644
--- a/meta/recipes-core/systemd/systemd_251.2.bb
+++ b/meta/recipes-core/systemd/systemd_251.2.bb
@@ -12,7 +12,7 @@ inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu
 
 # As this recipe builds udev, respect systemd being in DISTRO_FEATURES so
 # that we don't build both udev and systemd in world builds.
-REQUIRED_DISTRO_FEATURES = "systemd"
+REQUIRED_DISTRO_FEATURES += "systemd"
 
 SRC_URI += "file://touchscreen.rules \
            file://00-create-volatile.conf \
-- 
2.34.1



  reply	other threads:[~2022-07-13 16:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 20:29 [PATCH] systemd: add usrmerge to REQUIRED_DISTRO_FEATURES luca.boccassi
2022-07-11 22:06 ` [OE-core] " Richard Purdie
2022-07-12 17:16   ` Luca Boccassi
2022-07-12 21:55     ` Richard Purdie
2022-07-12 23:30       ` Luca Boccassi
2022-07-13 13:19         ` Richard Purdie
2022-07-13 15:52           ` Luca Boccassi
2022-07-13 17:00             ` Alexander Kanavin
2022-10-19 18:10         ` Luca Boccassi
2022-07-13 15:41 ` [PATCH v2 1/2] poky-altcfg: enable usrmerge luca.boccassi
2022-07-13 15:41   ` [PATCH v2 2/2] systemd: add usrmerge to REQUIRED_DISTRO_FEATURES luca.boccassi
2022-07-13 15:57     ` [OE-core] " Martin Jansa
     [not found]     ` <17016EB5AC5A56BC.15323@lists.openembedded.org>
2022-07-13 16:00       ` Martin Jansa
2022-07-13 16:26     ` Richard Purdie
2022-07-13 16:55       ` Luca Boccassi
2022-07-13 20:55         ` Richard Purdie
2022-07-13 16:55 ` [PATCH v3 1/2] poky-altcfg: enable usrmerge luca.boccassi
2022-07-13 16:55   ` luca.boccassi [this message]
2022-07-13 17:53   ` [OE-core] " Richard Purdie
2022-07-13 18:09     ` Luca Boccassi
2022-07-13 18:36       ` Richard Purdie
2022-07-13 19:02         ` Luca Boccassi
2022-07-13 21:17           ` Richard Purdie
2022-07-13 22:56           ` Andre McCurdy
2022-07-14 11:15     ` Jacob Kroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713165533.125600-2-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox