Re: [OE-core] [PATCH v3 1/2] poky-altcfg: enable usrmerge

[Jacob Kroon <jacob.kroon@gmail.com>]

On 7/13/22 19:53, Richard Purdie wrote:
> On Wed, 2022-07-13 at 17:55 +0100, Luca Bocassi wrote:
>> From: Luca Boccassi <luca.boccassi@microsoft.com>
>>
>> Ensure it gets tested by the CI
>>
>> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
>> ---
>>   meta-poky/conf/distro/poky-altcfg.conf | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-poky/conf/distro/poky-altcfg.conf b/meta-poky/conf/distro/poky-altcfg.conf
>> index f03306e798..57a76e8bb9 100644
>> --- a/meta-poky/conf/distro/poky-altcfg.conf
>> +++ b/meta-poky/conf/distro/poky-altcfg.conf
>> @@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg"
>>   #DISTROOVERRIDES = "poky:linuxstdbase"
>>   
>>   INIT_MANAGER:poky-altcfg = "systemd"
>> +# systemd will soon require usrmerge
>> +DISTRO_FEATURES:poky-altcfg += "usrmerge"
>>   # systemd isn't suitable with musl
>>   INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"
>>   
> 
> This blew up builds since it clears everything else out of
> DISTRO_FEATURES which isn't what was intended. I've tweaked the patch
> and re-queued.
> 

Maybe I'm missing something, but what is the benefit in introducing and 
using the "poky-altcfg" override in this file ? If DISTRO_FEATURES was 
just appended with

DISTRO_FEATURES += "usrmerge"

it would all be fine, since it is after the

require conf/distro/poky.conf

line, right ? And if someone wants to base a distro in 
"poky-altcfg.conf", they would include "poky-altcfg.conf" first in the 
same way, then do customizations.

Jacob