* [poky][dunfell][PATCH] cve_check: skip remote patches that haven't been fetched when searching for CVE tags
@ 2022-08-03 12:43 Akash Hadke
0 siblings, 0 replies; only message in thread
From: Akash Hadke @ 2022-08-03 12:43 UTC (permalink / raw)
To: openembedded-core
Cc: ranjitsinh.rathod, Ross Burton, Richard Purdie, Steve Sakoman
From: Ross Burton <ross.burton@arm.com>
If a remote patch is compressed we need to have run the unpack task for
the file to exist locally. Currently cve_check only depends on fetch so
instead of erroring out, emit a warning that this file won't be scanned
for CVE references.
Typically, remote compressed patches won't contain our custom tags, so
this is unlikely to be an issue.
(From OE-Core rev: b52a508bd7693c40e6416db9c9076a8789499501)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit cefc8741438c91f74264da6b59dece2e31f9e5a5)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 498bbee789f0b3b3a827e7b6914dfa9de764b1be)
Signed-off-by: Akash Hadke <akash.hadke@kpit.com>
---
meta/lib/oe/cve_check.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/lib/oe/cve_check.py b/meta/lib/oe/cve_check.py
index a4b831831b..30fdc3e3dd 100644
--- a/meta/lib/oe/cve_check.py
+++ b/meta/lib/oe/cve_check.py
@@ -114,9 +114,10 @@ def get_patched_cves(d):
for url in oe.patch.src_patches(d):
patch_file = bb.fetch.decodeurl(url)[2]
+ # Remote compressed patches may not be unpacked, so silently ignore them
if not os.path.isfile(patch_file):
- bb.error("File Not found: %s" % patch_file)
- raise FileNotFoundError
+ bb.warn("%s does not exist, cannot extract CVE list" % patch_file)
+ continue
# Check patch file name for CVE ID
fname_match = cve_file_name_match.search(patch_file)
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-03 12:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-03 12:43 [poky][dunfell][PATCH] cve_check: skip remote patches that haven't been fetched when searching for CVE tags Akash Hadke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox