From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Alexander Kanavin" <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
Alexander Kanavin <alex@linutronix.de>
Subject: Re: [OE-core] [PATCH 2/2] scripts/oe-setup-builddir: add a check that TEMPLATECONF is valid
Date: Sat, 27 Aug 2022 09:00:49 +0200 [thread overview]
Message-ID: <20220827090049.1d19b479@booty> (raw)
In-Reply-To: <20220824124234.3549247-2-alex@linutronix.de>
Hi Alex,
On Wed, 24 Aug 2022 14:42:34 +0200
"Alexander Kanavin" <alex.kanavin@gmail.com> wrote:
> specifically that ../../layer.conf exists, and that second-from-last
> component in the path is 'templates'.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
> scripts/oe-setup-builddir | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
> index 975619789a..db26e3b138 100755
> --- a/scripts/oe-setup-builddir
> +++ b/scripts/oe-setup-builddir
> @@ -61,6 +61,11 @@ if [ -n "$TEMPLATECONF" ]; then
> echo >&2 "Error: TEMPLATECONF value points to nonexistent directory '$TEMPLATECONF'"
> exit 1
> fi
> + templatesdir=$(python3 -c "import sys; print(sys.argv[1].strip('/').split('/')[-2])" $TEMPLATECONF)
> + if [ ! -f "$TEMPLATECONF/../../layer.conf" -o $templatesdir != "templates" ]; then
> + echo >&2 "Error: TEMPLATECONF value must point to meta-some-layer/conf/templates/template-name"
> + exit 1
> + fi
This is making the AB fail:
https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4140/steps/7/logs/stdio
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-08-27 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 12:42 [PATCH 1/2] meta/conf: move default configuration templates into meta/conf/templates/default Alexander Kanavin
2022-08-24 12:42 ` [PATCH 2/2] scripts/oe-setup-builddir: add a check that TEMPLATECONF is valid Alexander Kanavin
2022-08-24 13:58 ` [OE-core] " Peter Kjellerstedt
2022-08-24 14:08 ` Alexander Kanavin
2022-08-24 14:43 ` Peter Kjellerstedt
2022-08-24 14:52 ` Alexander Kanavin
2022-08-25 7:19 ` Peter Kjellerstedt
2022-08-25 9:19 ` Alexander Kanavin
2022-08-25 19:41 ` Peter Kjellerstedt
2022-08-27 7:00 ` Luca Ceresoli [this message]
2022-08-27 17:00 ` Alexander Kanavin
[not found] ` <170F423CB671B42F.16609@lists.openembedded.org>
2022-08-27 19:13 ` Alexander Kanavin
2022-08-25 13:37 ` [OE-core] [PATCH 1/2] meta/conf: move default configuration templates into meta/conf/templates/default Luca Ceresoli
2022-08-25 13:45 ` Alexander Kanavin
2022-08-26 9:04 ` Luca Ceresoli
2022-08-26 9:08 ` Alexander Kanavin
2022-08-26 10:27 ` Luca Ceresoli
2022-08-26 10:46 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827090049.1d19b479@booty \
--to=luca.ceresoli@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=alex@linutronix.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox