RE: [OE-core] [PATCH 2/2] scripts/oe-setup-builddir: add a check that TEMPLATECONF is valid

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Alexander Kanavin <alex.kanavin@gmail.com>
> Sent: den 24 augusti 2022 16:09
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org; Alexander Kanavin
> <alex@linutronix.de>
> Subject: Re: [OE-core] [PATCH 2/2] scripts/oe-setup-builddir: add a check
> that TEMPLATECONF is valid
> 
> On Wed, 24 Aug 2022 at 15:58, Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> > Please no. This happens to match your expectations, but doesn't at
> > all match our use of TEMPLATECONF. In our .templateconf we set
> > TEMPLATECONF=${TEMPLATECONF:-templateconf} and create the templateconf
> > directory in runtime where we generate the sample files that match the
> > layers that repo has fetched for this particular build. It obviously
> > has no layer.conf file as it is in no layer, and the path doesn't
> > contain "templates/<something>". I can of course change our tools to
> > create a couple of extra directories to match your expectations, but
> > at the same time it seems very unnecessary.
> 
> If you create the template files on the fly, then you might as well
> create the actual configs directly into build/conf and skip the
> template step. No?

We create the sample files in a small wrapper for oe-init-build-env 
so that to the users, everything works just as described in the Yocto 
documentation. And since the OE scripts expect TEMPLATECONF to be set 
and contain sample files, that is what we create.

> We do need to standardize the location for the templates for reasons
> of discoverability and consistency with machine and distro
> definitions, this has been discussed.

Sure, that is fine. But the expectation I have is that TEMPLATECONF 
refers to the directory that has the sample files needed to set up 
the build environment. And that is it. As long as the sample files 
exist where it says they should be, why do you need the scripts to 
fail because the environment around the directory does not look 
like what you happen to expect? It is only the contents of the 
directory that matters. Or am I missing something?

> 
> Alex

//Peter