public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH] rust: Use variable to specify extra tools to install
@ 2022-09-08 15:13 Khem Raj
  2022-09-08 16:35 ` [OE-core] " Otavio Salvador
  0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2022-09-08 15:13 UTC (permalink / raw)
  To: openembedded-core; +Cc: Khem Raj

All architectures may not support same set of tools, therefore use a
variable to specify this. E.g. on riscv32 only cargo-clippy is buildable
right now.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/rust/rust_1.63.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/rust/rust_1.63.0.bb b/meta/recipes-devtools/rust/rust_1.63.0.bb
index cf6468d212..2f70b33c29 100644
--- a/meta/recipes-devtools/rust/rust_1.63.0.bb
+++ b/meta/recipes-devtools/rust/rust_1.63.0.bb
@@ -62,13 +62,15 @@ rust_do_install:class-nativesdk() {
     rm ${D}${libdir}/rustlib/manifest*
 }
 
+EXTRA_TOOLS ?= "cargo-clippy clippy-driver rustfmt"
+EXTRA_TOOLS:remove:riscv32 = "cargo-driver rustfmt"
 rust_do_install:class-target() {
     export PSEUDO_UNLOAD=1
     rust_runx install
     unset PSEUDO_UNLOAD
 
     install -d ${D}${bindir}
-    for i in cargo-clippy clippy-driver rustfmt; do
+    for i in ${EXTRA_TOOLS}; do
         cp build/${RUST_BUILD_SYS}/stage2-tools/${RUST_HOST_SYS}/release/$i ${D}${bindir}
         chrpath -r "\$ORIGIN/../lib" ${D}${bindir}/$i
     done
-- 
2.37.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core] [PATCH] rust: Use variable to specify extra tools to install
  2022-09-08 15:13 [PATCH] rust: Use variable to specify extra tools to install Khem Raj
@ 2022-09-08 16:35 ` Otavio Salvador
  0 siblings, 0 replies; 2+ messages in thread
From: Otavio Salvador @ 2022-09-08 16:35 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

Em qui., 8 de set. de 2022 às 12:13, Khem Raj <raj.khem@gmail.com> escreveu:

> All architectures may not support same set of tools, therefore use a
> variable to specify this. E.g. on riscv32 only cargo-clippy is buildable
> right now.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/rust/rust_1.63.0.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/rust/rust_1.63.0.bb
> b/meta/recipes-devtools/rust/rust_1.63.0.bb
> index cf6468d212..2f70b33c29 100644
> --- a/meta/recipes-devtools/rust/rust_1.63.0.bb
> +++ b/meta/recipes-devtools/rust/rust_1.63.0.bb
> @@ -62,13 +62,15 @@ rust_do_install:class-nativesdk() {
>      rm ${D}${libdir}/rustlib/manifest*
>  }
>
> +EXTRA_TOOLS ?= "cargo-clippy clippy-driver rustfmt"
> +EXTRA_TOOLS:remove:riscv32 = "cargo-driver rustfmt"
>

clippy driver is spelled wrong.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 2105 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-08 16:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 15:13 [PATCH] rust: Use variable to specify extra tools to install Khem Raj
2022-09-08 16:35 ` [OE-core] " Otavio Salvador

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox