public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Joshua Watt <jpewhacker@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: jon.mason@arm.com, Joshua Watt <JPEWhacker@gmail.com>
Subject: [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored
Date: Fri, 21 Oct 2022 09:53:11 -0500	[thread overview]
Message-ID: <20221021145311.52133-1-JPEWhacker@gmail.com> (raw)

The code to parse arguments was inadvertently skipping all arguments in
the elif block after gl-es if it was specified on the command line.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 983f7514c7..189fc3da91 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -497,7 +497,7 @@ class BaseConfig(object):
                 self.gtk = True
             elif arg == 'gl':
                 self.gl = True
-            elif 'gl-es' in sys.argv[1:]:
+            elif arg == 'gl-es':
                 self.gl_es = True
             elif arg == 'egl-headless':
                 self.egl_headless = True
-- 
2.33.0



             reply	other threads:[~2022-10-21 14:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 14:53 Joshua Watt [this message]
2022-10-26 14:08 ` [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221021145311.52133-1-JPEWhacker@gmail.com \
    --to=jpewhacker@gmail.com \
    --cc=jon.mason@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox