* [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored
@ 2022-10-21 14:53 Joshua Watt
2022-10-26 14:08 ` Joshua Watt
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Watt @ 2022-10-21 14:53 UTC (permalink / raw)
To: openembedded-core; +Cc: jon.mason, Joshua Watt
The code to parse arguments was inadvertently skipping all arguments in
the elif block after gl-es if it was specified on the command line.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
scripts/runqemu | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 983f7514c7..189fc3da91 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -497,7 +497,7 @@ class BaseConfig(object):
self.gtk = True
elif arg == 'gl':
self.gl = True
- elif 'gl-es' in sys.argv[1:]:
+ elif arg == 'gl-es':
self.gl_es = True
elif arg == 'egl-headless':
self.egl_headless = True
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored
2022-10-21 14:53 [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored Joshua Watt
@ 2022-10-26 14:08 ` Joshua Watt
0 siblings, 0 replies; 2+ messages in thread
From: Joshua Watt @ 2022-10-26 14:08 UTC (permalink / raw)
To: openembedded-core; +Cc: jon.mason, Steve Sakoman
Steve,
Please backport this to kirkstone at your convenience.
Thanks
On Fri, Oct 21, 2022 at 9:53 AM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> The code to parse arguments was inadvertently skipping all arguments in
> the elif block after gl-es if it was specified on the command line.
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> scripts/runqemu | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 983f7514c7..189fc3da91 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -497,7 +497,7 @@ class BaseConfig(object):
> self.gtk = True
> elif arg == 'gl':
> self.gl = True
> - elif 'gl-es' in sys.argv[1:]:
> + elif arg == 'gl-es':
> self.gl_es = True
> elif arg == 'egl-headless':
> self.egl_headless = True
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-26 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-21 14:53 [OE-core][PATCH] runqemu: Fix gl-es argument from causing other arguments to be ignored Joshua Watt
2022-10-26 14:08 ` Joshua Watt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox