Re: [PATCH] create-spdx: fix config build by adding dependency to enable reruns

Re: [PATCH] create-spdx: fix config build by adding dependency to enable reruns

[Maanya Goenka]

[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]

Also, signed off by Paul Eggleton: paul.eggleton@microsoft.com
________________________________
From: maanyagoenka@linux.microsoft.com <maanyagoenka@linux.microsoft.com>
Sent: Tuesday, January 17, 2023 10:01 AM
To: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Cc: Maanya Goenka <maanyagoenka@linux.microsoft.com>; Maanya Goenka <maanyagoenka@microsoft.com>
Subject: [PATCH] create-spdx: fix config build by adding dependency to enable reruns

From: Maanya Goenka <maanyagoenka@linux.microsoft.com>

The issue encountered is about local stos builds failing (when these builds are
preceded by a local SoC OS or MOS build). Essentially, the failure is seen when
building two different configs with shared state, one where gcc-cross-<arch> has a dependency
and one where it doesn't (specifically, one where the abicheck class in meta-binaryaudit
is inherited and one where it isn't). Hence, the task signatures change but a rerun of those said tasks
does not occur. The result is that when the config with the dependency is built and then the one without
is built, due to incorrect dependencies, the SPDX manifest creation stage errors out.

create-spdx relies on BB_TASKDEPDATA to get dependencies and then adds that variable to
vardepsexclude. A change in dependencies therefore, does not result in a
re-execution of the tasks. This commit adds an explicit dependency on DEPENDS which influences
BB_TASKDEPDATA and triggers reruns for new config builds having different dependencies.

Signed-off-by: Maanya Goenka <maanyagoenka@microsoft.com>
---
 meta/classes/create-spdx-2.2.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/create-spdx-2.2.bbclass b/meta/classes/create-spdx-2.2.bbclass
index f0513af..e2553b4 100644
--- a/meta/classes/create-spdx-2.2.bbclass
+++ b/meta/classes/create-spdx-2.2.bbclass
@@ -377,7 +377,7 @@ def collect_dep_recipes(d, doc, spdx_recipe):
     return dep_recipes

 collect_dep_recipes[vardepsexclude] += "BB_TASKDEPDATA"
-
+collect_dep_recipes[vardeps] += "DEPENDS"

 def collect_dep_sources(d, dep_recipes):
     import oe.sbom
--
1.8.3.1


[-- Attachment #2: Type: text/html, Size: 3239 bytes --]

Re: [OE-core] [PATCH] create-spdx: fix config build by adding dependency to enable reruns

[Luca Ceresoli]

Hello Maanya,

On Tue, 17 Jan 2023 18:02:52 +0000
"Maanya Goenka via lists.openembedded.org"
<maanyagoenka=microsoft.com@lists.openembedded.org> wrote:

> Also, signed off by Paul Eggleton: paul.eggleton@microsoft.com
> ________________________________
> From: maanyagoenka@linux.microsoft.com <maanyagoenka@linux.microsoft.com>
> Sent: Tuesday, January 17, 2023 10:01 AM
> To: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Cc: Maanya Goenka <maanyagoenka@linux.microsoft.com>; Maanya Goenka <maanyagoenka@microsoft.com>
> Subject: [PATCH] create-spdx: fix config build by adding dependency to enable reruns

Here you seem to be replying to a patch, but the original patch does
not appear neither in my inbox nor in the archives (I checked on
lore.kernel.org).

Can you send the patch again? A "[PATCH][RESEND]" tag would be OK I
guess.

Thank you!
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com