Re: [OE-core] [PATCH 1/3] insane: Improve patch warning/error handling

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello,

On Thu, 19 Jan 2023 10:24:23 +0100
"Luca Ceresoli via lists.openembedded.org"
<luca.ceresoli=bootlin.com@lists.openembedded.org> wrote:

> Hello Richard,
> 
> On Wed, 18 Jan 2023 14:22:19 +0000
> "Richard Purdie" <richard.purdie@linuxfoundation.org> wrote:
> 
> > Currently, whilst patch errors or warnings are shown, the errors don't stop builds.
> > The configuration isn't very configurable from WARN_QA and ERROR_QA either.
> > 
> > This patch:
> >  * Uses the standard mechanisms to handle the patch fuzz warnings/errors
> >  * Makes Upstream-Status checking configurable from WARN/ERROR_QA
> >  * Allows that checking to be used with non-core layers
> >  * Makes patch-fuzz an error by default
> >  * Enables warnings for missing Upstream-Status in non-core layer patches by default
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/classes-global/insane.bbclass | 27 ++++++++++++++++++---------
> >  1 file changed, 18 insertions(+), 9 deletions(-)
> > 
> > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
> > index ada8a7ef4e4..e1295f85392 100644
> > --- a/meta/classes-global/insane.bbclass
> > +++ b/meta/classes-global/insane.bbclass
> > @@ -29,11 +29,12 @@
> >  WARN_QA ?= " libdir xorg-driver-abi buildpaths \
> >              textrel incompatible-license files-invalid \
> >              infodir build-deps src-uri-bad symlink-to-sysroot multilib \
> > -            invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \
> > +            invalid-packageconfig host-user-contaminated uppercase-pn \
> >              mime mime-xdg unlisted-pkg-lics unhandled-features-check \
> >              missing-update-alternatives native-last missing-ptest \
> >              license-exists license-no-generic license-syntax license-format \
> >              license-incompatible license-file-missing obsolete-license \
> > +            patch-status-noncore \  
> 
> AB testing with this patch applied revealed a few Upstream-Status
> warnings:
> 
> - 5 in meta-agl-core:
>   https://autobuilder.yoctoproject.org/typhoon/#/builders/120/builds/2272/steps/13/logs/stdio
> 
> - 3 in meta-intel:
>   https://autobuilder.yoctoproject.org/typhoon/#/builders/100/builds/3968/steps/13/logs/stdio

And I missed:

 - 9 in meta-virtualization:
   https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1168/steps/13/logs/stdio

> Jan-Simon, Anuj, can you look at those patches and maybe fix the Upstream-Status?

Bruce is in the list too now :)

Apologies for the noise.

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com