[PATCH 1/6] python3-hatchling: fix rdepends

[PATCH 1/6] python3-hatchling: fix rdepends

[Ernst Sjöstrand]

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 meta/recipes-devtools/python/python3-hatchling_1.13.0.bb | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/recipes-devtools/python/python3-hatchling_1.13.0.bb b/meta/recipes-devtools/python/python3-hatchling_1.13.0.bb
index 17e7f86ba66..ac1e8cc9d0d 100644
--- a/meta/recipes-devtools/python/python3-hatchling_1.13.0.bb
+++ b/meta/recipes-devtools/python/python3-hatchling_1.13.0.bb
@@ -14,4 +14,11 @@ do_compile:prepend() {
     export PYTHONPATH=src
 }
 
+RDEPENDS:${PN} += " \
+    ${PYTHON_PN}-editables \
+    ${PYTHON_PN}-packaging \
+    ${PYTHON_PN}-pathspec \
+    ${PYTHON_PN}-pluggy \
+"
+
 BBCLASSEXTEND = "native nativesdk"
-- 
2.39.2

[PATCH 2/6] python3-fixtures: add recipe

[Ernst Sjöstrand]

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 .../python/python3-fixtures_4.0.1.bb          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-fixtures_4.0.1.bb

diff --git a/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
new file mode 100644
index 00000000000..f71eec6497e
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
@@ -0,0 +1,19 @@
+SUMMARY = "Python fixtures for testing / resource management"
+HOMEPAGE = "https://github.com/testing-cabal/fixtures"
+SECTION = "devel/python"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://COPYING;md5=239e2f4698b85aad5ed39bae5d2ef226"
+
+inherit pypi setuptools3
+
+SRC_URI[sha256sum] = "d2758826400d095b79666cf93a32a84f50ff8cd179831927efb48cd1e3ca7466"
+
+DEPENDS += " \
+    ${PYTHON_PN}-pbr-native \
+    "
+
+RDEPENDS:${PN} += "\
+    ${PYTHON_PN}-pbr \
+    "
+
+BBCLASSEXTEND = "nativesdk"
-- 
2.39.2

[PATCH 3/6] python3-testtools: add fixtures to rdepends

[Ernst Sjöstrand]

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 meta/recipes-devtools/python/python-testtools.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/python/python-testtools.inc b/meta/recipes-devtools/python/python-testtools.inc
index e004d0eb0b5..3321b040374 100644
--- a/meta/recipes-devtools/python/python-testtools.inc
+++ b/meta/recipes-devtools/python/python-testtools.inc
@@ -20,6 +20,7 @@ DEPENDS += " \
 RDEPENDS:${PN} += "\
     ${PYTHON_PN}-doctest \
     ${PYTHON_PN}-extras \
+    ${PYTHON_PN}-fixtures \
     ${PYTHON_PN}-pbr \
     ${PYTHON_PN}-six \
     "
-- 
2.39.2

[PATCH 4/6] python3-charset-normalizer: add recipe

[Ernst Sjöstrand]

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 .../python/python3-charset-normalizer_3.1.0.bb         | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-charset-normalizer_3.1.0.bb

diff --git a/meta/recipes-devtools/python/python3-charset-normalizer_3.1.0.bb b/meta/recipes-devtools/python/python3-charset-normalizer_3.1.0.bb
new file mode 100644
index 00000000000..9fda99b7ca6
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-charset-normalizer_3.1.0.bb
@@ -0,0 +1,10 @@
+DESCRIPTION = "Truly universal encoding detector in pure Python"
+HOMEPAGE = "https://charset-normalizer.readthedocs.io"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=0974a390827087287db39928f7c524b5"
+
+SRC_URI[sha256sum] = "34e0a2f9c370eb95597aae63bf85eb5e96826d81e3dcf88b8886012906f509b5"
+
+inherit pypi setuptools3
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.39.2

[PATCH 5/6] python3-requests: fix rdepends

[Ernst Sjöstrand]

Remove obsolete or unused rdepends.
Add python3-charset-normalizer.

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 .../python/python3-requests_2.28.2.bb                 | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/meta/recipes-devtools/python/python3-requests_2.28.2.bb b/meta/recipes-devtools/python/python3-requests_2.28.2.bb
index 8ab1ec01212..e16490b2f5a 100644
--- a/meta/recipes-devtools/python/python3-requests_2.28.2.bb
+++ b/meta/recipes-devtools/python/python3-requests_2.28.2.bb
@@ -1,5 +1,5 @@
 SUMMARY = "Python HTTP for Humans."
-HOMEPAGE = "http://python-requests.org"
+HOMEPAGE = "https://requests.readthedocs.io"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
 
@@ -8,17 +8,12 @@ SRC_URI[sha256sum] = "98b1b2782e3c6c4904938b84c0eb932721069dfdb9134313beff7c83c2
 inherit pypi setuptools3
 
 RDEPENDS:${PN} += " \
-    ${PYTHON_PN}-email \
-    ${PYTHON_PN}-json \
-    ${PYTHON_PN}-ndg-httpsclient \
-    ${PYTHON_PN}-netserver \
-    ${PYTHON_PN}-pyasn1 \
-    ${PYTHON_PN}-pyopenssl \
+    ${PYTHON_PN}-certifi \
+    ${PYTHON_PN}-charset-normalizer \
     ${PYTHON_PN}-pysocks \
     ${PYTHON_PN}-urllib3 \
     ${PYTHON_PN}-chardet \
     ${PYTHON_PN}-idna \
-    ${PYTHON_PN}-compression \
 "
 
 CVE_PRODUCT = "requests"
-- 
2.39.2

[PATCH 6/6] python3-subunit: fix rdepends

[Ernst Sjöstrand]

Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
---
 meta/recipes-devtools/python/python3-subunit_1.4.2.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python3-subunit_1.4.2.bb b/meta/recipes-devtools/python/python3-subunit_1.4.2.bb
index a018ef1dc84..3bb8526dfbc 100644
--- a/meta/recipes-devtools/python/python3-subunit_1.4.2.bb
+++ b/meta/recipes-devtools/python/python3-subunit_1.4.2.bb
@@ -10,6 +10,9 @@ SRC_URI[sha256sum] = "2988d324d55ec35dd037e502e3f74ac38f4e457bd44ee0edf5e898f7ee
 
 inherit pypi setuptools3
 
-RDEPENDS:${PN} = " python3-testtools"
+RDEPENDS:${PN} = " \
+    ${PYTHON_PN}-extras \
+    ${PYTHON_PN}-testtools \
+"
 
 BBCLASSEXTEND = "nativesdk"
-- 
2.39.2

Re: [OE-core] [PATCH 5/6] python3-requests: fix rdepends

[Ernst Sjöstrand]

[-- Attachment #1: Type: text/plain, Size: 2334 bytes --]

Oh, email, json, netserver and compression are from the python standard
library,
they are probably still needed. So this patch is wrong!
I was only thinking about PyPI requires from setup.py here.
(Couldn't they have a more unique name, like python3-core-email or
similar... ?)


Den tis 2 maj 2023 kl 19:35 skrev Ernst Sjöstrand via lists.openembedded.org
<ernstp=gmail.com@lists.openembedded.org>:

> Remove obsolete or unused rdepends.
> Add python3-charset-normalizer.
>
> Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
> ---
>  .../python/python3-requests_2.28.2.bb                 | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3-requests_2.28.2.bb
> b/meta/recipes-devtools/python/python3-requests_2.28.2.bb
> index 8ab1ec01212..e16490b2f5a 100644
> --- a/meta/recipes-devtools/python/python3-requests_2.28.2.bb
> +++ b/meta/recipes-devtools/python/python3-requests_2.28.2.bb
> @@ -1,5 +1,5 @@
>  SUMMARY = "Python HTTP for Humans."
> -HOMEPAGE = "http://python-requests.org"
> +HOMEPAGE = "https://requests.readthedocs.io"
>  LICENSE = "Apache-2.0"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
>
> @@ -8,17 +8,12 @@ SRC_URI[sha256sum] =
> "98b1b2782e3c6c4904938b84c0eb932721069dfdb9134313beff7c83c2
>  inherit pypi setuptools3
>
>  RDEPENDS:${PN} += " \
> -    ${PYTHON_PN}-email \
> -    ${PYTHON_PN}-json \
> -    ${PYTHON_PN}-ndg-httpsclient \
> -    ${PYTHON_PN}-netserver \
> -    ${PYTHON_PN}-pyasn1 \
> -    ${PYTHON_PN}-pyopenssl \
> +    ${PYTHON_PN}-certifi \
> +    ${PYTHON_PN}-charset-normalizer \
>      ${PYTHON_PN}-pysocks \
>      ${PYTHON_PN}-urllib3 \
>      ${PYTHON_PN}-chardet \
>      ${PYTHON_PN}-idna \
> -    ${PYTHON_PN}-compression \
>  "
>
>  CVE_PRODUCT = "requests"
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180760):
> https://lists.openembedded.org/g/openembedded-core/message/180760
> Mute This Topic: https://lists.openembedded.org/mt/98644248/4947266
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ernstp@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 4362 bytes --]

Re: [OE-core] [PATCH 2/6] python3-fixtures: add recipe

[Alexandre Belloni]

Hello,

without a maintainers entry, this will fail build testing

On 02/05/2023 19:34:18+0200, Ernst Sj�strand wrote:
> Signed-off-by: Ernst Sj�strand <ernstp@gmail.com>
> ---
>  .../python/python3-fixtures_4.0.1.bb          | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> 
> diff --git a/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> new file mode 100644
> index 00000000000..f71eec6497e
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "Python fixtures for testing / resource management"
> +HOMEPAGE = "https://github.com/testing-cabal/fixtures"
> +SECTION = "devel/python"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=239e2f4698b85aad5ed39bae5d2ef226"
> +
> +inherit pypi setuptools3
> +
> +SRC_URI[sha256sum] = "d2758826400d095b79666cf93a32a84f50ff8cd179831927efb48cd1e3ca7466"
> +
> +DEPENDS += " \
> +    ${PYTHON_PN}-pbr-native \
> +    "
> +
> +RDEPENDS:${PN} += "\
> +    ${PYTHON_PN}-pbr \
> +    "
> +
> +BBCLASSEXTEND = "nativesdk"
> -- 
> 2.39.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180757): https://lists.openembedded.org/g/openembedded-core/message/180757
> Mute This Topic: https://lists.openembedded.org/mt/98644245/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH 2/6] python3-fixtures: add recipe

[Tim Orling]

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

Please add some reason that it needs to be added to core. Empty commit logs
do not help future users know “why?”

On Tue, May 2, 2023 at 10:35 AM Ernst Sjöstrand <ernstp@gmail.com> wrote:

> Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
> ---
>  .../python/python3-fixtures_4.0.1.bb          | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>
> diff --git a/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> new file mode 100644
> index 00000000000..f71eec6497e
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "Python fixtures for testing / resource management"
> +HOMEPAGE = "https://github.com/testing-cabal/fixtures"
> +SECTION = "devel/python"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=239e2f4698b85aad5ed39bae5d2ef226"
> +
> +inherit pypi setuptools3
> +
> +SRC_URI[sha256sum] =
> "d2758826400d095b79666cf93a32a84f50ff8cd179831927efb48cd1e3ca7466"
> +
> +DEPENDS += " \
> +    ${PYTHON_PN}-pbr-native \
> +    "
> +
> +RDEPENDS:${PN} += "\
> +    ${PYTHON_PN}-pbr \
> +    "
> +
> +BBCLASSEXTEND = "nativesdk"
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180757):
> https://lists.openembedded.org/g/openembedded-core/message/180757
> Mute This Topic: https://lists.openembedded.org/mt/98644245/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3228 bytes --]

Re: [OE-core] [PATCH 2/6] python3-fixtures: add recipe

[Tim Orling]

[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]

On Wed, May 3, 2023 at 9:47 PM Tim Orling <ticotimo@gmail.com> wrote:

> Please add some reason that it needs to be added to core. Empty commit
> logs do not help future users know “why?”
>
> On Tue, May 2, 2023 at 10:35 AM Ernst Sjöstrand <ernstp@gmail.com> wrote:
>
>> Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
>> ---
>>  .../python/python3-fixtures_4.0.1.bb          | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>  create mode 100644 meta/recipes-devtools/python/
>> python3-fixtures_4.0.1.bb
>>
>> diff --git a/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>> b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>> new file mode 100644
>> index 00000000000..f71eec6497e
>> --- /dev/null
>> +++ b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>> @@ -0,0 +1,19 @@
>> +SUMMARY = "Python fixtures for testing / resource management"
>> +HOMEPAGE = "https://github.com/testing-cabal/fixtures"
>> +SECTION = "devel/python"
>> +LICENSE = "BSD-3-Clause"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=239e2f4698b85aad5ed39bae5d2ef226"
>> +
>> +inherit pypi setuptools3
>> +
>> +SRC_URI[sha256sum] =
>> "d2758826400d095b79666cf93a32a84f50ff8cd179831927efb48cd1e3ca7466"
>> +
>> +DEPENDS += " \
>> +    ${PYTHON_PN}-pbr-native \
>> +    "
>> +
>> +RDEPENDS:${PN} += "\
>> +    ${PYTHON_PN}-pbr \
>> +    "
>> +
>> +BBCLASSEXTEND = "nativesdk"
>> --
>> 2.39.2
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#180757):
>> https://lists.openembedded.org/g/openembedded-core/message/180757
>> Mute This Topic: https://lists.openembedded.org/mt/98644245/924729
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
>> ticotimo@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>

[-- Attachment #2: Type: text/html, Size: 3581 bytes --]

Re: [OE-core] [PATCH 4/6] python3-charset-normalizer: add recipe

[Tim Orling]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Why does this need to be added to core? Please provide some
reason/justification for adding the recipe.

On Tue, May 2, 2023 at 10:35 AM Ernst Sjöstrand <ernstp@gmail.com> wrote:

> Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
> ---
>  .../python/python3-charset-normalizer_3.1.0.bb         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/
> python3-charset-normalizer_3.1.0.bb
>
> diff --git a/meta/recipes-devtools/python/
> python3-charset-normalizer_3.1.0.bb b/meta/recipes-devtools/python/
> python3-charset-normalizer_3.1.0.bb
> new file mode 100644
> index 00000000000..9fda99b7ca6
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-charset-normalizer_3.1.0.bb
> @@ -0,0 +1,10 @@
> +DESCRIPTION = "Truly universal encoding detector in pure Python"
> +HOMEPAGE = "https://charset-normalizer.readthedocs.io"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0974a390827087287db39928f7c524b5"
> +
> +SRC_URI[sha256sum] =
> "34e0a2f9c370eb95597aae63bf85eb5e96826d81e3dcf88b8886012906f509b5"
> +
> +inherit pypi setuptools3
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180759):
> https://lists.openembedded.org/g/openembedded-core/message/180759
> Mute This Topic: https://lists.openembedded.org/mt/98644247/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3086 bytes --]

Re: [OE-core] [PATCH 2/6] python3-fixtures: add recipe

[Ernst Sjöstrand]

[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]

Right, both these are added as dependencies in their respective next
commits but I will make the commit
messages self contained of course. V2 in a couple of days.
Still thinking about how I can handle python3 standard library modules
compared to PyPI modules...

Den tors 4 maj 2023 kl 06:47 skrev Tim Orling <ticotimo@gmail.com>:

>
>
> On Wed, May 3, 2023 at 9:47 PM Tim Orling <ticotimo@gmail.com> wrote:
>
>> Please add some reason that it needs to be added to core. Empty commit
>> logs do not help future users know “why?”
>>
>> On Tue, May 2, 2023 at 10:35 AM Ernst Sjöstrand <ernstp@gmail.com> wrote:
>>
>>> Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
>>> ---
>>>  .../python/python3-fixtures_4.0.1.bb          | 19 +++++++++++++++++++
>>>  1 file changed, 19 insertions(+)
>>>  create mode 100644 meta/recipes-devtools/python/
>>> python3-fixtures_4.0.1.bb
>>>
>>> diff --git a/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>>> b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>>> new file mode 100644
>>> index 00000000000..f71eec6497e
>>> --- /dev/null
>>> +++ b/meta/recipes-devtools/python/python3-fixtures_4.0.1.bb
>>> @@ -0,0 +1,19 @@
>>> +SUMMARY = "Python fixtures for testing / resource management"
>>> +HOMEPAGE = "https://github.com/testing-cabal/fixtures"
>>> +SECTION = "devel/python"
>>> +LICENSE = "BSD-3-Clause"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=239e2f4698b85aad5ed39bae5d2ef226"
>>> +
>>> +inherit pypi setuptools3
>>> +
>>> +SRC_URI[sha256sum] =
>>> "d2758826400d095b79666cf93a32a84f50ff8cd179831927efb48cd1e3ca7466"
>>> +
>>> +DEPENDS += " \
>>> +    ${PYTHON_PN}-pbr-native \
>>> +    "
>>> +
>>> +RDEPENDS:${PN} += "\
>>> +    ${PYTHON_PN}-pbr \
>>> +    "
>>> +
>>> +BBCLASSEXTEND = "nativesdk"
>>> --
>>> 2.39.2
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> View/Reply Online (#180757):
>>> https://lists.openembedded.org/g/openembedded-core/message/180757
>>> Mute This Topic: https://lists.openembedded.org/mt/98644245/924729
>>> Group Owner: openembedded-core+owner@lists.openembedded.org
>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
>>> ticotimo@gmail.com]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>>

[-- Attachment #2: Type: text/html, Size: 4487 bytes --]