[PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...o-linker-flags-for-libparted-fs-resi.patch | 34 +++++++++++++++++++
 meta/recipes-extended/parted/parted_3.5.bb    |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 meta/recipes-extended/parted/files/0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch

diff --git a/meta/recipes-extended/parted/files/0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch b/meta/recipes-extended/parted/files/0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch
new file mode 100644
index 00000000000..10354f1ed9d
--- /dev/null
+++ b/meta/recipes-extended/parted/files/0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch
@@ -0,0 +1,34 @@
+From 1fc88332f7e906294fd889287b9e84cefc7f1586 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Mon, 12 Jun 2023 10:40:07 -0700
+Subject: [PATCH] fs: Add libuuid to linker flags for libparted-fs-resize
+ library
+
+This library uses uuid_generate function which comes from libuuid and
+hence it should be mentioned on linker cmdline
+
+fixes
+| aarch64-yoe-linux-ld.lld: error: undefined reference due to --no-allow-shlib-undefined: uuid_generate
+| >>> referenced by /mnt/b/yoe/master/build/tmp/work/cortexa72-cortexa53-crypto-yoe-linux/fatresize/1.1.0-r0/recipe-sysroot/usr/lib/libparted-fs-resize.so
+
+Upstream-Status: Submitted [https://alioth-lists.debian.net/pipermail/parted-devel/2023-June/005873.html]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ libparted/fs/Makefile.am | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libparted/fs/Makefile.am b/libparted/fs/Makefile.am
+index 2f345f3..a8970eb 100644
+--- a/libparted/fs/Makefile.am
++++ b/libparted/fs/Makefile.am
+@@ -75,6 +75,7 @@ libparted_fs_resize_la_LDFLAGS =		\
+ EXTRA_DIST += fsresize.sym
+ libparted_fs_resize_la_DEPENDENCIES = $(sym_file)
+ 
++libparted_fs_resize_la_LIBADD   = $(UUID_LIBS)
+ libparted_fs_resize_la_SOURCES = \
+   r/filesys.c			\
+   r/fat/bootsector.c		\
+-- 
+2.41.0
+
diff --git a/meta/recipes-extended/parted/parted_3.5.bb b/meta/recipes-extended/parted/parted_3.5.bb
index f403840d3c2..b269c143b41 100644
--- a/meta/recipes-extended/parted/parted_3.5.bb
+++ b/meta/recipes-extended/parted/parted_3.5.bb
@@ -9,6 +9,7 @@ DEPENDS = "ncurses util-linux virtual/libiconv"
 SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
            file://fix-doc-mandir.patch \
            file://autoconf-2.73.patch \
+           file://0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch \
            file://run-ptest \
            "
 
-- 
2.41.0

Re: [OE-core] [PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[Ross Burton]

On 12 Jun 2023, at 19:10, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> 
> diff --git a/meta/recipes-extended/parted/parted_3.5.bb b/meta/recipes-extended/parted/parted_3.5.bb
> index f403840d3c2..b269c143b41 100644
> --- a/meta/recipes-extended/parted/parted_3.5.bb
> +++ b/meta/recipes-extended/parted/parted_3.5.bb
> @@ -9,6 +9,7 @@ DEPENDS = "ncurses util-linux virtual/libiconv"
> SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
>            file://fix-doc-mandir.patch \
>            file://autoconf-2.73.patch \
  ^^^^

Doesn’t apply cleanly as this patch doesn’t exist in master.  I guess these build on top of a series testing the new autoconf?

Ross

Re: [OE-core] [PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Exactly I can rebase and send v2

On Tue, Jun 13, 2023 at 3:30 AM Ross Burton <Ross.Burton@arm.com> wrote:

> On 12 Jun 2023, at 19:10, Khem Raj via lists.openembedded.org <raj.khem=
> gmail.com@lists.openembedded.org> wrote:
> >
> > diff --git a/meta/recipes-extended/parted/parted_3.5.bb
> b/meta/recipes-extended/parted/parted_3.5.bb
> > index f403840d3c2..b269c143b41 100644
> > --- a/meta/recipes-extended/parted/parted_3.5.bb
> > +++ b/meta/recipes-extended/parted/parted_3.5.bb
> > @@ -9,6 +9,7 @@ DEPENDS = "ncurses util-linux virtual/libiconv"
> > SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
> >            file://fix-doc-mandir.patch \
> >            file://autoconf-2.73.patch \
>   ^^^^
>
> Doesn’t apply cleanly as this patch doesn’t exist in master.  I guess
> these build on top of a series testing the new autoconf?
>
> Ross

[-- Attachment #2: Type: text/html, Size: 1643 bytes --]

Re: [OE-core] [PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[Khem Raj]

On Tue, Jun 13, 2023 at 6:55 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> Exactly I can rebase and send v2
>

I think Alex already did it on his master-next branch here
https://git.yoctoproject.org/poky-contrib/commit/?h=abelloni/master-next&id=9a266798a4f4a9aacc80297af689c0ce254e09f1

> On Tue, Jun 13, 2023 at 3:30 AM Ross Burton <Ross.Burton@arm.com> wrote:
>>
>> On 12 Jun 2023, at 19:10, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
>> >
>> > diff --git a/meta/recipes-extended/parted/parted_3.5.bb b/meta/recipes-extended/parted/parted_3.5.bb
>> > index f403840d3c2..b269c143b41 100644
>> > --- a/meta/recipes-extended/parted/parted_3.5.bb
>> > +++ b/meta/recipes-extended/parted/parted_3.5.bb
>> > @@ -9,6 +9,7 @@ DEPENDS = "ncurses util-linux virtual/libiconv"
>> > SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
>> >            file://fix-doc-mandir.patch \
>> >            file://autoconf-2.73.patch \
>>   ^^^^
>>
>> Doesn’t apply cleanly as this patch doesn’t exist in master.  I guess these build on top of a series testing the new autoconf?
>>
>> Ross

Re: [OE-core] [PATCH] parted: Add missing libuuid to linker cmdline for libparted-fs-resize.so

[Alexandre Belloni]

On 13/06/2023 08:16:48-0700, Khem Raj wrote:
> On Tue, Jun 13, 2023 at 6:55 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Exactly I can rebase and send v2
> >
> 
> I think Alex already did it on his master-next branch here
> https://git.yoctoproject.org/poky-contrib/commit/?h=abelloni/master-next&id=9a266798a4f4a9aacc80297af689c0ce254e09f1
> 

Yeah, let me know if I didn't do the correct thing.

> > On Tue, Jun 13, 2023 at 3:30 AM Ross Burton <Ross.Burton@arm.com> wrote:
> >>
> >> On 12 Jun 2023, at 19:10, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >> >
> >> > diff --git a/meta/recipes-extended/parted/parted_3.5.bb b/meta/recipes-extended/parted/parted_3.5.bb
> >> > index f403840d3c2..b269c143b41 100644
> >> > --- a/meta/recipes-extended/parted/parted_3.5.bb
> >> > +++ b/meta/recipes-extended/parted/parted_3.5.bb
> >> > @@ -9,6 +9,7 @@ DEPENDS = "ncurses util-linux virtual/libiconv"
> >> > SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
> >> >            file://fix-doc-mandir.patch \
> >> >            file://autoconf-2.73.patch \
> >>   ^^^^
> >>
> >> Doesn’t apply cleanly as this patch doesn’t exist in master.  I guess these build on top of a series testing the new autoconf?
> >>
> >> Ross

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#182719): https://lists.openembedded.org/g/openembedded-core/message/182719
> Mute This Topic: https://lists.openembedded.org/mt/99489278/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com