public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
@ 2023-07-21 12:07 Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 2/5] package.bbclass: " Piotr Łobacz
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 12:07 UTC (permalink / raw)
  To: openembedded-core; +Cc: Piotr Łobacz

Extend OPKGBUILDCMD variable, with additional parameters, depending
on target distro features, in order to support ACLs and xattr.

With fix pushed to the opkg-devel:
https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8
opkg-build is able to create tar archives with ACLs and xattr.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 meta/classes-global/package_ipk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
index b4b7bc9ac2..5e151be3cd 100644
--- a/meta/classes-global/package_ipk.bbclass
+++ b/meta/classes-global/package_ipk.bbclass
@@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
 PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
 
 # Program to be used to build opkg packages
-OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
+OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
 
 OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
 OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [OE-Core][PATCH v7][master-next 2/5] package.bbclass: add support for ACLs and xattr
  2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
@ 2023-07-21 12:07 ` Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 3/5] opkg-utils: add acl and xattr support Piotr Łobacz
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 12:07 UTC (permalink / raw)
  To: openembedded-core; +Cc: Piotr Łobacz

Extend `tar` command, with additional parameters, depending
on choosen package class and target distro features, in order
to support ACLs and xattr.

Currently only `package_ipk` supports fully ACLs and xattr.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 meta/classes-global/package.bbclass | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass
index e8055a9cdc..6e5d0dd4dc 100644
--- a/meta/classes-global/package.bbclass
+++ b/meta/classes-global/package.bbclass
@@ -342,8 +342,13 @@ python perform_packagecopy () {
 
     # Start by package population by taking a copy of the installed
     # files to operate on
-    # Preserve sparse files and hard links
-    cmd = 'tar --exclude=./sysroot-only -cf - -C %s -p -S . | tar -xf - -C %s' % (dest, dvar)
+    # Preserve sparse files, hard links, ACLs and extended attributes
+    # TODO: for the moment only ipk packages are supporting ACLs and extended attributes
+    # we need to add support for other package systems as well, but that doesn't bother
+    # tar from creating archives with acl and/or xattr support
+    acl = bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d)
+    xattr = bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs', '', d)
+    cmd = f'tar {acl} {xattr} --numeric-owner --exclude=./sysroot-only -cf - -C {dest} -p -S . | tar {acl} {xattr} -xf - -C {dvar}'
     subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
     # replace RPATHs for the nativesdk binaries, to make them relocatable
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [OE-Core][PATCH v7][master-next 3/5] opkg-utils: add acl and xattr support
  2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 2/5] package.bbclass: " Piotr Łobacz
@ 2023-07-21 12:07 ` Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 4/5] opkg: add options to enable support for acl and xattr Piotr Łobacz
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 12:07 UTC (permalink / raw)
  To: openembedded-core; +Cc: Piotr Łobacz

Add support for tar archives created with --acls and/or --xattrs options,
PAX header format.

GNU tar and libarchive already supports ACLs and extended attributes.
We can now add this support as well to opkg-build script in order to use
fsetattr or setcap inside do_install command and end up with a file in
an image with the relevant ACLs and xattrs.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 ...kg-build-Add-acls-and-xattrs-support.patch | 80 +++++++++++++++++++
 .../opkg-utils/opkg-utils_0.6.2.bb            |  1 +
 2 files changed, 81 insertions(+)
 create mode 100644 meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch

diff --git a/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch b/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch
new file mode 100644
index 0000000000..a9e5f0e191
--- /dev/null
+++ b/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch
@@ -0,0 +1,80 @@
+From 5664c17923cc1ab9644ef01f549bc8d352dd8868 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Piotr=20=C5=81obacz?= <p.lobacz@welotec.com>
+Date: Wed, 5 Jul 2023 10:31:13 +0200
+Subject: [PATCH] opkg-build: Add acls and xattrs support
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Add support for tar archives created with --acls and/or --xattrs options,
+PAX header format.
+
+GNU tar and libarchive already supports ACLs and extended attributes.
+We can now add this support as well to opkg-build script in order to use
+fsetattr or setcap inside do_install command and end up with a file in
+an image with the relevant ACLs and xattrs.
+
+Upstream-Status: Accepted [https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8]
+
+[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=15097
+[2] https://groups.google.com/g/opkg-devel/c/aEGL7XRXfaA
+
+Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
+---
+ opkg-build | 15 ++++++++++-----
+ 1 file changed, 10 insertions(+), 5 deletions(-)
+
+diff --git a/opkg-build b/opkg-build
+index a9e45d4..8d9bcfa 100755
+--- a/opkg-build
++++ b/opkg-build
+@@ -145,6 +145,7 @@ You probably want to chown these to a system user: " >&2
+ ###
+ # opkg-build "main"
+ ###
++attributesargs=""
+ ogargs=""
+ outer=ar
+ noclean=0
+@@ -166,7 +167,7 @@ compressorargs=""
+ tarformat=""
+ if tar --help 2>&1 | grep -- "--format" > /dev/null;
+ then
+-    tarformat="--format=gnu"
++    tarformat="--format=posix"
+ fi
+ 
+ compressor_ext() {
+@@ -197,13 +198,17 @@ compressor_ext() {
+ : <<=cut
+ =head1 SYNOPSIS
+ 
+-B<opkg-build> [B<-c>] [B<-C>] [B<-Z> I<compressor>] [B<-a>] [B<-O>] [B<-o> I<owner>] [B<-g> I<group>] I<pkg_directory> [I<destination_directory>]
++B<opkg-build> [B<-A>] [B<-X>] [B<-c>] [B<-C>] [B<-Z> I<compressor>] [B<-a>] [B<-O>] [B<-o> I<owner>] [B<-g> I<group>] I<pkg_directory> [I<destination_directory>]
+ 
+ =cut
+ 
+-usage="Usage: $0 [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]"
+-while getopts "a:cCg:ho:vOZ:" opt; do
++usage="Usage: $0 [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]"
++while getopts "Aa:cCg:ho:vOXZ:" opt; do
+     case $opt in
++        A ) attributesargs="--acls"
++            ;;
++        X ) attributesargs="$attributesargs --xattrs"
++            ;;
+ 	o ) owner=$OPTARG
+ 	    ogargs="--owner=$owner"
+ 	    ;;
+@@ -314,7 +319,7 @@ export LANG=C
+ export LC_ALL=C
+ ( cd $pkg_dir/$CONTROL && find . -type f | sort > $tmp_dir/control_list )
+ ( cd $pkg_dir && find . -path ./$CONTROL -prune -o -path . -o -print  | sort > $tmp_dir/file_list )
+-( cd $pkg_dir && tar $ogargs $tsortargs --no-recursion $mtime_args -c $tarformat -T $tmp_dir/file_list | $compressor $compressorargs > $tmp_dir/data.tar.$cext )
++( cd $pkg_dir && tar $attributesargs $ogargs $tsortargs --no-recursion $mtime_args -c $tarformat -T $tmp_dir/file_list | $compressor $compressorargs > $tmp_dir/data.tar.$cext )
+ ( cd $pkg_dir/$CONTROL && tar $ogargs $tsortargs --no-recursion --mtime=@$build_date -c $tarformat -T $tmp_dir/control_list | gzip $zipargs > $tmp_dir/control.tar.gz )
+ rm $tmp_dir/file_list
+ rm $tmp_dir/control_list
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/opkg-utils/opkg-utils_0.6.2.bb b/meta/recipes-devtools/opkg-utils/opkg-utils_0.6.2.bb
index eb88b9b734..d5ce2cfbe2 100644
--- a/meta/recipes-devtools/opkg-utils/opkg-utils_0.6.2.bb
+++ b/meta/recipes-devtools/opkg-utils/opkg-utils_0.6.2.bb
@@ -9,6 +9,7 @@ PROVIDES += "${@bb.utils.contains('PACKAGECONFIG', 'update-alternatives', 'virtu
 
 SRC_URI = "git://git.yoctoproject.org/opkg-utils;protocol=https;branch=master \
            file://0001-update-alternatives-correctly-match-priority.patch \
+           file://0002-opkg-build-Add-acls-and-xattrs-support.patch \
            "
 SRCREV = "67994e62dc598282830385da75ba9b1abbbda941"
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [OE-Core][PATCH v7][master-next 4/5] opkg: add options to enable support for acl and xattr
  2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 2/5] package.bbclass: " Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 3/5] opkg-utils: add acl and xattr support Piotr Łobacz
@ 2023-07-21 12:07 ` Piotr Łobacz
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 5/5] opkg: set locale from system environment variables Piotr Łobacz
  2023-07-21 22:01 ` [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Alexandre Belloni
  4 siblings, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 12:07 UTC (permalink / raw)
  To: openembedded-core; +Cc: Piotr Łobacz

The libarchive library, which is being used by opkg, supports ACLs
and xattr already.

More informations can be read at this link:
https://github.com/libarchive/libarchive/pull/691

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 ...-to-enable-support-for-acl-and-xattr.patch | 70 +++++++++++++++++++
 meta/recipes-devtools/opkg/opkg_0.6.2.bb      |  5 +-
 2 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch

diff --git a/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch b/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch
new file mode 100644
index 0000000000..d6cb1d79fb
--- /dev/null
+++ b/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch
@@ -0,0 +1,70 @@
+From 1c935e994bd572d9fff436f660ac1a060a434df0 Mon Sep 17 00:00:00 2001
+From: Maciej Liszewski <m.liszewski@welotec.com>
+Date: Tue, 4 Jul 2023 22:01:58 +0200
+Subject: [PATCH] Add options to enable support for acl and xattr
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The libarchive library, which is being used by opkg, supports ACLs
+and xattr already.
+
+More informations can be read at this link:
+https://github.com/libarchive/libarchive/pull/691
+
+Upstream-Status: Accepted [https://groups.google.com/g/opkg-devel/c/aEGL7XRXfaA]
+
+[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=15097
+
+Signed-off-by: Maciej Liszewski <m.liszewski@welotec.com>
+Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
+---
+ configure.ac           | 12 ++++++++++++
+ libopkg/opkg_archive.c |  8 ++++++++
+ 2 files changed, 20 insertions(+)
+
+diff --git a/configure.ac b/configure.ac
+index 389a818..46949cd 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -158,6 +158,18 @@ return OPENSSL_VERSION_NUMBER; ],
+   AC_SUBST(OPENSSL_LIBS)
+ fi
+ 
++# check for ACL support
++AC_ARG_WITH([acl], [AS_HELP_STRING([--with-acl], [Enable ACL support])])
++if test "x$with_acl" = "xyes"; then
++  AC_DEFINE([ENABLE_ACL], [1], [Enable ACL support])
++fi
++
++# check for xattr support
++AC_ARG_WITH([xattr], [AS_HELP_STRING([--with-xattr], [Enable xattr support])])
++if test "x$with_xattr" = "xyes"; then
++  AC_DEFINE([ENABLE_XATTR], [1], [Enable xattr support])
++fi
++
+ # check for libsolv solver
+ AC_ARG_WITH(libsolv, AC_HELP_STRING([--with-libsolv], [Use libsolv solver support.
+   ]), [], [with_libsolv="no"])
+diff --git a/libopkg/opkg_archive.c b/libopkg/opkg_archive.c
+index 03a4afb..8dd902d 100644
+--- a/libopkg/opkg_archive.c
++++ b/libopkg/opkg_archive.c
+@@ -912,6 +912,14 @@ struct opkg_ar *ar_open_pkg_data_archive(const char *filename)
+     ar->extract_flags = ARCHIVE_EXTRACT_OWNER | ARCHIVE_EXTRACT_PERM |
+         ARCHIVE_EXTRACT_TIME | ARCHIVE_EXTRACT_UNLINK | ARCHIVE_EXTRACT_NO_OVERWRITE;
+ 
++#ifdef ENABLE_ACL
++    ar->extract_flags |= ARCHIVE_EXTRACT_ACL;
++#endif
++
++#ifdef ENABLE_XATTR
++    ar->extract_flags |= ARCHIVE_EXTRACT_FFLAGS | ARCHIVE_EXTRACT_XATTR;
++#endif
++
+     if (opkg_config->ignore_uid)
+         ar->extract_flags &= ~ARCHIVE_EXTRACT_OWNER;
+ 
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/opkg/opkg_0.6.2.bb b/meta/recipes-devtools/opkg/opkg_0.6.2.bb
index 46be137354..d7dc6ab715 100644
--- a/meta/recipes-devtools/opkg/opkg_0.6.2.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.6.2.bb
@@ -15,6 +15,7 @@ PE = "1"
 SRC_URI = "http://downloads.yoctoproject.org/releases/${BPN}/${BPN}-${PV}.tar.gz \
            file://opkg.conf \
            file://0001-opkg_conf-create-opkg.lock-in-run-instead-of-var-run.patch \
+           file://0002-Add-options-to-enable-support-for-acl-and-xattr.patch \
            file://run-ptest \
            "
 
@@ -30,8 +31,10 @@ inherit autotools pkgconfig ptest
 target_localstatedir := "${localstatedir}"
 OPKGLIBDIR ??= "${target_localstatedir}/lib"
 
-PACKAGECONFIG ??= "libsolv"
+PACKAGECONFIG ??= "libsolv ${@bb.utils.filter('DISTRO_FEATURES', 'acl xattr', d)}"
 
+PACKAGECONFIG[acl] = "--with-acl,--without-acl"
+PACKAGECONFIG[xattr] = "--with-xattr,--without-xattr"
 PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,\
     gnupg gpgme libgpg-error,\
     ${@ "gnupg" if ("native" in d.getVar("PN")) else "gnupg-gpg"}\
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [OE-Core][PATCH v7][master-next 5/5] opkg: set locale from system environment variables
  2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
                   ` (2 preceding siblings ...)
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 4/5] opkg: add options to enable support for acl and xattr Piotr Łobacz
@ 2023-07-21 12:07 ` Piotr Łobacz
  2023-07-21 22:01 ` [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Alexandre Belloni
  4 siblings, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 12:07 UTC (permalink / raw)
  To: openembedded-core; +Cc: Piotr Łobacz

A C program inherits its locale environment variables when it starts up.
This happens automatically. However, these variables do not automatically
control the locale used by the library functions, because ISO C says that
all programs start by default in the standard ‘C’ locale.

Fixes warnings:
Warning when reading ar archive header: Pathname can't be converted from UTF-8 to current locale. (errno=84)

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 ...le-from-system-environment-variables.patch | 48 +++++++++++++++++++
 meta/recipes-devtools/opkg/opkg_0.6.2.bb      |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 meta/recipes-devtools/opkg/opkg/0003-opkg-set-locale-from-system-environment-variables.patch

diff --git a/meta/recipes-devtools/opkg/opkg/0003-opkg-set-locale-from-system-environment-variables.patch b/meta/recipes-devtools/opkg/opkg/0003-opkg-set-locale-from-system-environment-variables.patch
new file mode 100644
index 0000000000..71240ec8fd
--- /dev/null
+++ b/meta/recipes-devtools/opkg/opkg/0003-opkg-set-locale-from-system-environment-variables.patch
@@ -0,0 +1,48 @@
+From 712895b1914bf63ee4d669863bfd106814329076 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Piotr=20=C5=81obacz?= <p.lobacz@welotec.com>
+Date: Wed, 19 Jul 2023 21:26:09 +0200
+Subject: [PATCH] opkg: set locale from system environment variables
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+A C program inherits its locale environment variables when it starts up.
+This happens automatically. However, these variables do not automatically
+control the locale used by the library functions, because ISO C says that
+all programs start by default in the standard ‘C’ locale.
+
+Fixes warnings:
+Warning when reading ar archive header: Pathname can't be converted from UTF-8 to current locale. (errno=84)
+
+Upstream-Status: Submitted [https://groups.google.com/g/opkg-devel/c/16kgZfJ26mQ]
+
+[1] https://www.gnu.org/software/libc/manual/html_node/Setting-the-Locale.html
+
+Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
+---
+ src/opkg.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/opkg.c b/src/opkg.c
+index 544c58a..0c729ff 100644
+--- a/src/opkg.c
++++ b/src/opkg.c
+@@ -27,6 +27,7 @@
+ #include <stdio.h>
+ #include <getopt.h>
+ #include <stdlib.h>
++#include <locale.h>
+ 
+ #include "opkg_conf.h"
+ #include "opkg_cmd.h"
+@@ -408,6 +409,7 @@ int main(int argc, char *argv[])
+     if (opkg_conf_init())
+         goto err0;
+ 
++    setlocale(LC_ALL, "");
+     opkg_config->verbosity = NOTICE;
+ 
+     opts = args_parse(argc, argv);
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/opkg/opkg_0.6.2.bb b/meta/recipes-devtools/opkg/opkg_0.6.2.bb
index d7dc6ab715..3b5d51d74a 100644
--- a/meta/recipes-devtools/opkg/opkg_0.6.2.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.6.2.bb
@@ -16,6 +16,7 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/${BPN}/${BPN}-${PV}.tar.gz
            file://opkg.conf \
            file://0001-opkg_conf-create-opkg.lock-in-run-instead-of-var-run.patch \
            file://0002-Add-options-to-enable-support-for-acl-and-xattr.patch \
+           file://0003-opkg-set-locale-from-system-environment-variables.patch \
            file://run-ptest \
            "
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
                   ` (3 preceding siblings ...)
  2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 5/5] opkg: set locale from system environment variables Piotr Łobacz
@ 2023-07-21 22:01 ` Alexandre Belloni
  2023-07-21 23:33   ` ODP: " Piotr Łobacz
  4 siblings, 1 reply; 12+ messages in thread
From: Alexandre Belloni @ 2023-07-21 22:01 UTC (permalink / raw)
  To: Piotr Łobacz; +Cc: openembedded-core

I confirm this still fails on the autobuilders:

This is a-full:
https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631

On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> Extend OPKGBUILDCMD variable, with additional parameters, depending
> on target distro features, in order to support ACLs and xattr.
> 
> With fix pushed to the opkg-devel:
> https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8
> opkg-build is able to create tar archives with ACLs and xattr.
> 
> Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> ---
>  meta/classes-global/package_ipk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> index b4b7bc9ac2..5e151be3cd 100644
> --- a/meta/classes-global/package_ipk.bbclass
> +++ b/meta/classes-global/package_ipk.bbclass
> @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
>  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
>  
>  # Program to be used to build opkg packages
> -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
>  
>  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
>  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184688): https://lists.openembedded.org/g/openembedded-core/message/184688
> Mute This Topic: https://lists.openembedded.org/mt/100275318/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 12+ messages in thread

* ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-21 22:01 ` [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Alexandre Belloni
@ 2023-07-21 23:33   ` Piotr Łobacz
  2023-07-22 10:19     ` Alexandre Belloni
  0 siblings, 1 reply; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-21 23:33 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: openembedded-core@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 5253 bytes --]

Alexandre, Is it possible for you to create a docker file or some image etc. with all commands from autobuilder which will re-create the failure and pass it to me?

Because can grope, find nothing and waste our time...

Cheers,
Piotr

________________________________
Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
Wysłane: sobota, 22 lipca 2023 00:01
Do: Piotr Łobacz <p.lobacz@welotec.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr

I confirm this still fails on the autobuilders:

This is a-full:
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YHOXoiEiIYhWMLP%2FvytWKdXpcSpTDfKzwf8MEyGzWQ0%3D&reserved=0<https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>

On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> Extend OPKGBUILDCMD variable, with additional parameters, depending
> on target distro features, in order to support ACLs and xattr.
>
> With fix pushed to the opkg-devel:
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Hhix8F4A6m9r0tFljzmTUXwQdBUPeV6X8g4c0Nm%2Favw%3D&reserved=0<https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> opkg-build is able to create tar archives with ACLs and xattr.
>
> Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> ---
>  meta/classes-global/package_ipk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> index b4b7bc9ac2..5e151be3cd 100644
> --- a/meta/classes-global/package_ipk.bbclass
> +++ b/meta/classes-global/package_ipk.bbclass
> @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
>  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
>
>  # Program to be used to build opkg packages
> -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
>
>  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
>  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> --
> 2.34.1
>

>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184688): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZwVNo7xrr50em37GziHwBnWym4C%2FiPec1ds13X5vY1g%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/message/184688>
> Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9xI%2FOyNZLgQHu3DxDlNrRlvGnw78R1r%2FMUDsMax2Ols%3D&reserved=0<https://lists.openembedded.org/mt/100275318/3617179>
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xsWva7UZC%2B%2BRVwZFqazqHnRFG2deHmovxTk%2BiamdwBs%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qcJ5Tbo%2BeuKHZTpYlA5WJWQUekULrpnkHDmNnRAvEqo%3D&reserved=0<https://bootlin.com/>

[-- Attachment #2: Type: text/html, Size: 7462 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-21 23:33   ` ODP: " Piotr Łobacz
@ 2023-07-22 10:19     ` Alexandre Belloni
  2023-07-22 11:20       ` ODP: " Piotr Łobacz
  2023-07-22 11:42       ` Piotr Łobacz
  0 siblings, 2 replies; 12+ messages in thread
From: Alexandre Belloni @ 2023-07-22 10:19 UTC (permalink / raw)
  To: Piotr Łobacz; +Cc: openembedded-core@lists.openembedded.org

On 21/07/2023 23:33:02+0000, Piotr Łobacz wrote:
> Alexandre, Is it possible for you to create a docker file or some image etc. with all commands from autobuilder which will re-create the failure and pass it to me?
> 

I don't have that but really, those are just bare installation of the
distro with just what is necessary to start an OE build.

How did you try to reproduce?

The log says that you are trying to execute this:

opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-glibc-binary-localedata-zu-za /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/deploy-ipks/i686-nativesdk'

The error is there, in the logs since I tested v4:

Usage: /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]

It is because you changed OPKGBUILDCMD to be:

OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'

Can you see the extra double quotes that create two extra string
arguments?

Did you test without acl and xattr in DISTRO_FEATURES?

> Because can grope, find nothing and waste our time...
> 

Now, I've spent part of my week-end looking at that, this is time I will
never get back while you just had to read the errors I reported to you
on v4 and v5.
You are demanding this is urgently processed but your patch series is
not ready.

Also, you HAVE to fix the reproducibility issues, else this will not go
in.

> Cheers,
> Piotr
> 
> ________________________________
> Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Wysłane: sobota, 22 lipca 2023 00:01
> Do: Piotr Łobacz <p.lobacz@welotec.com>
> DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
> 
> I confirm this still fails on the autobuilders:
> 
> This is a-full:
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YHOXoiEiIYhWMLP%2FvytWKdXpcSpTDfKzwf8MEyGzWQ0%3D&reserved=0<https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>
> 
> On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> > Extend OPKGBUILDCMD variable, with additional parameters, depending
> > on target distro features, in order to support ACLs and xattr.
> >
> > With fix pushed to the opkg-devel:
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Hhix8F4A6m9r0tFljzmTUXwQdBUPeV6X8g4c0Nm%2Favw%3D&reserved=0<https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> > opkg-build is able to create tar archives with ACLs and xattr.
> >
> > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > ---
> >  meta/classes-global/package_ipk.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> > index b4b7bc9ac2..5e151be3cd 100644
> > --- a/meta/classes-global/package_ipk.bbclass
> > +++ b/meta/classes-global/package_ipk.bbclass
> > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
> >  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> >
> >  # Program to be used to build opkg packages
> > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> >
> >  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> >  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> > --
> > 2.34.1
> >
> 
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#184688): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZwVNo7xrr50em37GziHwBnWym4C%2FiPec1ds13X5vY1g%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/message/184688>
> > Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9xI%2FOyNZLgQHu3DxDlNrRlvGnw78R1r%2FMUDsMax2Ols%3D&reserved=0<https://lists.openembedded.org/mt/100275318/3617179>
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xsWva7UZC%2B%2BRVwZFqazqHnRFG2deHmovxTk%2BiamdwBs%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
> 
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C308b241fa77c483b937808db8a360827%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638255736894248112%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qcJ5Tbo%2BeuKHZTpYlA5WJWQUekULrpnkHDmNnRAvEqo%3D&reserved=0<https://bootlin.com/>

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 12+ messages in thread

* ODP: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-22 10:19     ` Alexandre Belloni
@ 2023-07-22 11:20       ` Piotr Łobacz
  2023-07-22 11:42       ` Piotr Łobacz
  1 sibling, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-22 11:20 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: openembedded-core@lists.openembedded.org

> How did you try to reproduce?
>
> The log says that you are trying to execute this:
>
> opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-glibc-binary-localedata-zu-za /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/deploy-ipks/i686-nativesdk'

Yes, you are absolutely right I haven't noticed these "" "" before...

> Did you test without acl and xattr in DISTRO_FEATURES?

Nevertheless, this was my first suspicion, which I have tested and it didn't occured. I'll try once again maybe for the first time something went wrong...

> Now, I've spent part of my week-end looking at that, this is time I will
> never get back while you just had to read the errors I reported to you
> on v4 and v5.

You don't have to be rude you know? I'm also investing my own time in order to improve it....

> You are demanding this is urgently processed but your patch series is
> not ready.

I'm not demanding anything, I'm only asking for support, that's all :)

> Cheers,
> Piotr
>
> ________________________________
> Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Wysłane: sobota, 22 lipca 2023 00:01
> Do: Piotr Łobacz <p.lobacz@welotec.com>
> DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
>
> I confirm this still fails on the autobuilders:
>
> This is a-full:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631<https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>
>
> On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> > Extend OPKGBUILDCMD variable, with additional parameters, depending
> > on target distro features, in order to support ACLs and xattr.
> >
> > With fix pushed to the opkg-devel:
> > https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8<https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> > opkg-build is able to create tar archives with ACLs and xattr.
> >
> > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > ---
> >  meta/classes-global/package_ipk.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> > index b4b7bc9ac2..5e151be3cd 100644
> > --- a/meta/classes-global/package_ipk.bbclass
> > +++ b/meta/classes-global/package_ipk.bbclass
> > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
> >  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> >
> >  # Program to be used to build opkg packages
> > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> >
> >  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> >  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> > --
> > 2.34.1
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#184688): https://lists.openembedded.org/g/openembedded-core/message/184688<https://lists.openembedded.org/g/openembedded-core/message/184688>
> > Mute This Topic: https://lists.openembedded.org/mt/100275318/3617179<https://lists.openembedded.org/mt/100275318/3617179>
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub<https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com/<https://bootlin.com/>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com/


^ permalink raw reply	[flat|nested] 12+ messages in thread

* ODP: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-22 10:19     ` Alexandre Belloni
  2023-07-22 11:20       ` ODP: " Piotr Łobacz
@ 2023-07-22 11:42       ` Piotr Łobacz
  2023-07-22 12:45         ` Alexandre Belloni
  1 sibling, 1 reply; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-22 11:42 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: openembedded-core@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 10962 bytes --]

OK, finally discovered why in my case removing of acl from DISTRO_FEATURES didn't work for me. We have our own DISTRO_FEATURES:append in which acl is being appended and I just removed it from there.

Unfortunately, there is this file:
yocto/openembedded-core/meta/conf/distro/include/default-distrovars.inc:19:DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
which I was not aware of....

I will fix that today finally...

BR
Piotr
________________________________
Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
Wysłane: sobota, 22 lipca 2023 12:19
Do: Piotr Łobacz <p.lobacz@welotec.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr

On 21/07/2023 23:33:02+0000, Piotr Łobacz wrote:
> Alexandre, Is it possible for you to create a docker file or some image etc. with all commands from autobuilder which will re-create the failure and pass it to me?
>

I don't have that but really, those are just bare installation of the
distro with just what is necessary to start an OE build.

How did you try to reproduce?

The log says that you are trying to execute this:

opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-glibc-binary-localedata-zu-za /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/deploy-ipks/i686-nativesdk'

The error is there, in the logs since I tested v4:

Usage: /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]

It is because you changed OPKGBUILDCMD to be:

OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'

Can you see the extra double quotes that create two extra string
arguments?

Did you test without acl and xattr in DISTRO_FEATURES?

> Because can grope, find nothing and waste our time...
>

Now, I've spent part of my week-end looking at that, this is time I will
never get back while you just had to read the errors I reported to you
on v4 and v5.
You are demanding this is urgently processed but your patch series is
not ready.

Also, you HAVE to fix the reproducibility issues, else this will not go
in.

> Cheers,
> Piotr
>
> ________________________________
> Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Wysłane: sobota, 22 lipca 2023 00:01
> Do: Piotr Łobacz <p.lobacz@welotec.com>
> DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
>
> I confirm this still fails on the autobuilders:
>
> This is a-full:
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xRBC3fnrtzeYVHWF3NXuYNEUcItaUgthfNbsESw0Uf8%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xRBC3fnrtzeYVHWF3NXuYNEUcItaUgthfNbsESw0Uf8%3D&reserved=0><https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>
>
> On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> > Extend OPKGBUILDCMD variable, with additional parameters, depending
> > on target distro features, in order to support ACLs and xattr.
> >
> > With fix pushed to the opkg-devel:
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tHNWv1KiC%2F23ieV1MDFHeDal56N68koKsSejPRw5xd4%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tHNWv1KiC%2F23ieV1MDFHeDal56N68koKsSejPRw5xd4%3D&reserved=0><https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> > opkg-build is able to create tar archives with ACLs and xattr.
> >
> > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > ---
> >  meta/classes-global/package_ipk.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> > index b4b7bc9ac2..5e151be3cd 100644
> > --- a/meta/classes-global/package_ipk.bbclass
> > +++ b/meta/classes-global/package_ipk.bbclass
> > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
> >  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> >
> >  # Program to be used to build opkg packages
> > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> >
> >  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> >  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> > --
> > 2.34.1
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#184688): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VZTQIYFoSzjRHY42jZwFRCNC6EDE30tqMshNiIUcl6M%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VZTQIYFoSzjRHY42jZwFRCNC6EDE30tqMshNiIUcl6M%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/message/184688>
> > Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b09R4UtKy%2FMdb%2Bo3H9c9FfG9yitoxo3ACuVSwiBxK7E%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b09R4UtKy%2FMdb%2Bo3H9c9FfG9yitoxo3ACuVSwiBxK7E%3D&reserved=0><https://lists.openembedded.org/mt/100275318/3617179>
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZWc%2FB6UBqT6hbR5bIxvtbdV41ibuKna%2Bk06Cnj9uq%2BY%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZWc%2FB6UBqT6hbR5bIxvtbdV41ibuKna%2Bk06Cnj9uq%2BY%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0><https://bootlin.com/>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0<https://bootlin.com/>

[-- Attachment #2: Type: text/html, Size: 14301 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: ODP: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-22 11:42       ` Piotr Łobacz
@ 2023-07-22 12:45         ` Alexandre Belloni
  2023-07-22 13:02           ` ODP: " Piotr Łobacz
  0 siblings, 1 reply; 12+ messages in thread
From: Alexandre Belloni @ 2023-07-22 12:45 UTC (permalink / raw)
  To: Piotr Łobacz; +Cc: openembedded-core@lists.openembedded.org

On 22/07/2023 11:42:39+0000, Piotr Łobacz wrote:
> OK, finally discovered why in my case removing of acl from DISTRO_FEATURES didn't work for me. We have our own DISTRO_FEATURES:append in which acl is being appended and I just removed it from there.
> 
> Unfortunately, there is this file:
> yocto/openembedded-core/meta/conf/distro/include/default-distrovars.inc:19:DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
> which I was not aware of....
> 

Note that the failing packages are nativesdk- so I suspect
DISTRO_FEATURES_FILTER_NATIVESDK may have something to do with this.

> I will fix that today finally...
> 
> BR
> Piotr
> ________________________________
> Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Wysłane: sobota, 22 lipca 2023 12:19
> Do: Piotr Łobacz <p.lobacz@welotec.com>
> DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Temat: Re: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
> 
> On 21/07/2023 23:33:02+0000, Piotr Łobacz wrote:
> > Alexandre, Is it possible for you to create a docker file or some image etc. with all commands from autobuilder which will re-create the failure and pass it to me?
> >
> 
> I don't have that but really, those are just bare installation of the
> distro with just what is necessary to start an OE build.
> 
> How did you try to reproduce?
> 
> The log says that you are trying to execute this:
> 
> opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-glibc-binary-localedata-zu-za /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/deploy-ipks/i686-nativesdk'
> 
> The error is there, in the logs since I tested v4:
> 
> Usage: /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
> 
> It is because you changed OPKGBUILDCMD to be:
> 
> OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> 
> Can you see the extra double quotes that create two extra string
> arguments?
> 
> Did you test without acl and xattr in DISTRO_FEATURES?
> 
> > Because can grope, find nothing and waste our time...
> >
> 
> Now, I've spent part of my week-end looking at that, this is time I will
> never get back while you just had to read the errors I reported to you
> on v4 and v5.
> You are demanding this is urgently processed but your patch series is
> not ready.
> 
> Also, you HAVE to fix the reproducibility issues, else this will not go
> in.
> 
> > Cheers,
> > Piotr
> >
> > ________________________________
> > Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Wysłane: sobota, 22 lipca 2023 00:01
> > Do: Piotr Łobacz <p.lobacz@welotec.com>
> > DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> > Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
> >
> > I confirm this still fails on the autobuilders:
> >
> > This is a-full:
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xRBC3fnrtzeYVHWF3NXuYNEUcItaUgthfNbsESw0Uf8%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xRBC3fnrtzeYVHWF3NXuYNEUcItaUgthfNbsESw0Uf8%3D&reserved=0><https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>
> >
> > On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> > > Extend OPKGBUILDCMD variable, with additional parameters, depending
> > > on target distro features, in order to support ACLs and xattr.
> > >
> > > With fix pushed to the opkg-devel:
> > > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tHNWv1KiC%2F23ieV1MDFHeDal56N68koKsSejPRw5xd4%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tHNWv1KiC%2F23ieV1MDFHeDal56N68koKsSejPRw5xd4%3D&reserved=0><https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> > > opkg-build is able to create tar archives with ACLs and xattr.
> > >
> > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > > ---
> > >  meta/classes-global/package_ipk.bbclass | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> > > index b4b7bc9ac2..5e151be3cd 100644
> > > --- a/meta/classes-global/package_ipk.bbclass
> > > +++ b/meta/classes-global/package_ipk.bbclass
> > > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
> > >  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> > >
> > >  # Program to be used to build opkg packages
> > > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> > > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> > >
> > >  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> > >  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> > > --
> > > 2.34.1
> > >
> >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#184688): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VZTQIYFoSzjRHY42jZwFRCNC6EDE30tqMshNiIUcl6M%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VZTQIYFoSzjRHY42jZwFRCNC6EDE30tqMshNiIUcl6M%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/message/184688>
> > > Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b09R4UtKy%2FMdb%2Bo3H9c9FfG9yitoxo3ACuVSwiBxK7E%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b09R4UtKy%2FMdb%2Bo3H9c9FfG9yitoxo3ACuVSwiBxK7E%3D&reserved=0><https://lists.openembedded.org/mt/100275318/3617179>
> > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZWc%2FB6UBqT6hbR5bIxvtbdV41ibuKna%2Bk06Cnj9uq%2BY%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZWc%2FB6UBqT6hbR5bIxvtbdV41ibuKna%2Bk06Cnj9uq%2BY%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0><https://bootlin.com/>
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C144d5e10c57041bc852d08db8a9d349c%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256180025031560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XMC3vugVsU3kWlvJ7Ru%2FFh2RMc8v2NBhSD6vMk9hWlI%3D&reserved=0<https://bootlin.com/>

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 12+ messages in thread

* ODP: ODP: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
  2023-07-22 12:45         ` Alexandre Belloni
@ 2023-07-22 13:02           ` Piotr Łobacz
  0 siblings, 0 replies; 12+ messages in thread
From: Piotr Łobacz @ 2023-07-22 13:02 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: openembedded-core@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 19587 bytes --]

It does not matter, the problem is due to this line:

OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'

For some reason these '' from both acl and xattr are being packed into "", but I wanted it to be threated as empty strings which would be actually not being passed to this command.

I have finally reproduced the error on my side:

ERROR: run-postinsts-1.0-r10 do_package_write_ipk: Fatal errors occurred in subprocesses:
Command 'PATH="/work/build/yocto/openembedded-core/scripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-WelotecGmbH-linux:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/work/build/yocto/bitbake/bin:/work/build/tmp-glibc/hosttools" opkg-build -Z xz -a "--memlimit=50% --threads=16" "" "-X" run-postinsts /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/work/build/yocto/openembedded-core/scripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-WelotecGmbH-linux:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/work/build/yocto/bitbake/bin:/work/build/tmp-glibc/hosttools" opkg-build -Z xz -a "--memlimit=50% --threads=16" "" "-X" run-postinsts-dbg /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/work/build/yocto/openembedded-core/scripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-WelotecGmbH-linux:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/work/build/yocto/bitbake/bin:/work/build/tmp-glibc/hosttools" opkg-build -Z xz -a "--memlimit=50% --threads=16" "" "-X" run-postinsts-dev /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /work/build/tmp-glibc/work/all-WelotecGmbH-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]

when I have just removed entirely acl from DISTRO_FEATURES.

So, in principle I just need to fix this command and that will be all, hopefully.
________________________________
Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
Wysłane: sobota, 22 lipca 2023 14:45
Do: Piotr Łobacz <p.lobacz@welotec.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: ODP: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr

On 22/07/2023 11:42:39+0000, Piotr Łobacz wrote:
> OK, finally discovered why in my case removing of acl from DISTRO_FEATURES didn't work for me. We have our own DISTRO_FEATURES:append in which acl is being appended and I just removed it from there.
>
> Unfortunately, there is this file:
> yocto/openembedded-core/meta/conf/distro/include/default-distrovars.inc:19:DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
> which I was not aware of....
>

Note that the failing packages are nativesdk- so I suspect
DISTRO_FEATURES_FILTER_NATIVESDK may have something to do with this.

> I will fix that today finally...
>
> BR
> Piotr
> ________________________________
> Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Wysłane: sobota, 22 lipca 2023 12:19
> Do: Piotr Łobacz <p.lobacz@welotec.com>
> DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Temat: Re: ODP: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
>
> On 21/07/2023 23:33:02+0000, Piotr Łobacz wrote:
> > Alexandre, Is it possible for you to create a docker file or some image etc. with all commands from autobuilder which will re-create the failure and pass it to me?
> >
>
> I don't have that but really, those are just bare installation of the
> distro with just what is necessary to start an OE build.
>
> How did you try to reproduce?
>
> The log says that you are trying to execute this:
>
> opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-glibc-binary-localedata-zu-za /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/deploy-ipks/i686-nativesdk'
>
> The error is there, in the logs since I tested v4:
>
> Usage: /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/i686-nativesdk-oesdk-linux/nativesdk-glibc-locale/2.37-r1/recipe-sysroot-native/usr/bin/opkg-build [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
>
> It is because you changed OPKGBUILDCMD to be:
>
> OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
>
> Can you see the extra double quotes that create two extra string
> arguments?
>
> Did you test without acl and xattr in DISTRO_FEATURES?
>
> > Because can grope, find nothing and waste our time...
> >
>
> Now, I've spent part of my week-end looking at that, this is time I will
> never get back while you just had to read the errors I reported to you
> on v4 and v5.
> You are demanding this is urgently processed but your patch series is
> not ready.
>
> Also, you HAVE to fix the reproducibility issues, else this will not go
> in.
>
> > Cheers,
> > Piotr
> >
> > ________________________________
> > Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Wysłane: sobota, 22 lipca 2023 00:01
> > Do: Piotr Łobacz <p.lobacz@welotec.com>
> > DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> > Temat: Re: [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
> >
> > I confirm this still fails on the autobuilders:
> >
> > This is a-full:
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1uDyi%2FU59lOmIhLOGt%2F1H7UT3iWRJwBuyGtvSaaxOA8%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1uDyi%2FU59lOmIhLOGt%2F1H7UT3iWRJwBuyGtvSaaxOA8%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F83%2Fbuilds%2F5631&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1uDyi%2FU59lOmIhLOGt%2F1H7UT3iWRJwBuyGtvSaaxOA8%3D&reserved=0><https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5631>
> >
> > On 21/07/2023 14:07:19+0200, Piotr Łobacz wrote:
> > > Extend OPKGBUILDCMD variable, with additional parameters, depending
> > > on target distro features, in order to support ACLs and xattr.
> > >
> > > With fix pushed to the opkg-devel:
> > > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Vhf4D2Ov8fnMJQgVV4tf3q24O4Z6Hr3sUzvjo%2BocM4I%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Vhf4D2Ov8fnMJQgVV4tf3q24O4Z6Hr3sUzvjo%2BocM4I%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Vhf4D2Ov8fnMJQgVV4tf3q24O4Z6Hr3sUzvjo%2BocM4I%3D&reserved=0><https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> > > opkg-build is able to create tar archives with ACLs and xattr.
> > >
> > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > > ---
> > >  meta/classes-global/package_ipk.bbclass | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> > > index b4b7bc9ac2..5e151be3cd 100644
> > > --- a/meta/classes-global/package_ipk.bbclass
> > > +++ b/meta/classes-global/package_ipk.bbclass
> > > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
> > >  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> > >
> > >  # Program to be used to build opkg packages
> > > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> > > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
> > >
> > >  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> > >  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> > > --
> > > 2.34.1
> > >
> >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#184688): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tlbCboG1%2Ff30ogE%2ByFHVYp9XCfzvUJhZeSNARy569JY%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tlbCboG1%2Ff30ogE%2ByFHVYp9XCfzvUJhZeSNARy569JY%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184688&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tlbCboG1%2Ff30ogE%2ByFHVYp9XCfzvUJhZeSNARy569JY%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/message/184688>
> > > Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5QIiE0inXC%2FckyuRCxYnbhstdybPsQ4yIXGnNA5yWlE%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5QIiE0inXC%2FckyuRCxYnbhstdybPsQ4yIXGnNA5yWlE%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100275318%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5QIiE0inXC%2FckyuRCxYnbhstdybPsQ4yIXGnNA5yWlE%3D&reserved=0><https://lists.openembedded.org/mt/100275318/3617179>
> > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=U72%2BiRPCuJ%2B6zv5Xa8xCrKhW7nKXV0hlM%2BDTV2meB4c%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=U72%2BiRPCuJ%2B6zv5Xa8xCrKhW7nKXV0hlM%2BDTV2meB4c%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=U72%2BiRPCuJ%2B6zv5Xa8xCrKhW7nKXV0hlM%2BDTV2meB4c%3D&reserved=0><https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fy1ewqziBFsp7Tr4YdBZ6RndkaUMe2mH2ClcjsK2ua0%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fy1ewqziBFsp7Tr4YdBZ6RndkaUMe2mH2ClcjsK2ua0%3D&reserved=0><https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fy1ewqziBFsp7Tr4YdBZ6RndkaUMe2mH2ClcjsK2ua0%3D&reserved=0><https://bootlin.com/>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fy1ewqziBFsp7Tr4YdBZ6RndkaUMe2mH2ClcjsK2ua0%3D&reserved=0<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364321769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fy1ewqziBFsp7Tr4YdBZ6RndkaUMe2mH2ClcjsK2ua0%3D&reserved=0><https://bootlin.com/>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C9c0e0482f5aa4a4aba3508db8ab18a04%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638256267364478020%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2U1vCACo22kIwqtPm3jTzsM2te9i9csAbbM8%2FT%2Fp%2FVo%3D&reserved=0<https://bootlin.com/>

[-- Attachment #2: Type: text/html, Size: 24547 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-07-22 13:02 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21 12:07 [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 2/5] package.bbclass: " Piotr Łobacz
2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 3/5] opkg-utils: add acl and xattr support Piotr Łobacz
2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 4/5] opkg: add options to enable support for acl and xattr Piotr Łobacz
2023-07-21 12:07 ` [OE-Core][PATCH v7][master-next 5/5] opkg: set locale from system environment variables Piotr Łobacz
2023-07-21 22:01 ` [OE-Core][PATCH v7][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Alexandre Belloni
2023-07-21 23:33   ` ODP: " Piotr Łobacz
2023-07-22 10:19     ` Alexandre Belloni
2023-07-22 11:20       ` ODP: " Piotr Łobacz
2023-07-22 11:42       ` Piotr Łobacz
2023-07-22 12:45         ` Alexandre Belloni
2023-07-22 13:02           ` ODP: " Piotr Łobacz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox