* [PATCH] package: always sort the conffiles
@ 2023-07-27 15:37 Jean-Marie Lemetayer
2023-07-28 10:31 ` [OE-core] " Alexandre Belloni
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Marie Lemetayer @ 2023-07-27 15:37 UTC (permalink / raw)
To: openembedded-core; +Cc: Jean-Marie Lemetayer
To improve package reproducibility, the conffiles order should not be
directly linked to the file system.
Sorting the conffiles solves this issue.
---
meta/lib/oe/package.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 70040f09e7..9d70925b9b 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -613,7 +613,7 @@ def get_conffiles(pkg, d):
conf_list[i] = conf_list[i][1:]
os.chdir(cwd)
- return conf_list
+ return sorted(conf_list)
def legitimize_package_name(s):
"""
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] package: always sort the conffiles
2023-07-27 15:37 [PATCH] package: always sort the conffiles Jean-Marie Lemetayer
@ 2023-07-28 10:31 ` Alexandre Belloni
2023-08-01 7:52 ` [PATCH v2] " Jean-Marie Lemetayer
2023-08-01 7:56 ` Jean-Marie Lemetayer
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Belloni @ 2023-07-28 10:31 UTC (permalink / raw)
To: j.lemetayer; +Cc: openembedded-core
Hello,
On 27/07/2023 17:37:32+0200, Jean-Marie Lemetayer via lists.openembedded.org wrote:
> To improve package reproducibility, the conffiles order should not be
> directly linked to the file system.
>
> Sorting the conffiles solves this issue.
This is missing you Signed-off-by tag.
> ---
> meta/lib/oe/package.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
> index 70040f09e7..9d70925b9b 100644
> --- a/meta/lib/oe/package.py
> +++ b/meta/lib/oe/package.py
> @@ -613,7 +613,7 @@ def get_conffiles(pkg, d):
> conf_list[i] = conf_list[i][1:]
>
> os.chdir(cwd)
> - return conf_list
> + return sorted(conf_list)
>
> def legitimize_package_name(s):
> """
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184964): https://lists.openembedded.org/g/openembedded-core/message/184964
> Mute This Topic: https://lists.openembedded.org/mt/100392906/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] package: always sort the conffiles
2023-07-28 10:31 ` [OE-core] " Alexandre Belloni
@ 2023-08-01 7:52 ` Jean-Marie Lemetayer
2023-08-01 7:56 ` Jean-Marie Lemetayer
1 sibling, 0 replies; 4+ messages in thread
From: Jean-Marie Lemetayer @ 2023-08-01 7:52 UTC (permalink / raw)
To: openembedded-core; +Cc: Jean-Marie Lemetayer
To improve package reproducibility, the conffiles order should not be
directly linked to the file system.
Sorting the conffiles solves this issue.
Signed-off-by: Jean-Marie Lemetayer <j.lemetayer@kerlink.fr>
---
meta/lib/oe/package.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 70040f09e7..9d70925b9b 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -613,7 +613,7 @@ def get_conffiles(pkg, d):
conf_list[i] = conf_list[i][1:]
os.chdir(cwd)
- return conf_list
+ return sorted(conf_list)
def legitimize_package_name(s):
"""
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] package: always sort the conffiles
2023-07-28 10:31 ` [OE-core] " Alexandre Belloni
2023-08-01 7:52 ` [PATCH v2] " Jean-Marie Lemetayer
@ 2023-08-01 7:56 ` Jean-Marie Lemetayer
1 sibling, 0 replies; 4+ messages in thread
From: Jean-Marie Lemetayer @ 2023-08-01 7:56 UTC (permalink / raw)
To: openembedded-core; +Cc: Jean-Marie Lemetayer
To improve package reproducibility, the conffiles order should not be
directly linked to the file system.
Sorting the conffiles solves this issue.
Signed-off-by: Jean-Marie Lemetayer <j.lemetayer@kerlink.fr>
---
meta/lib/oe/package.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 70040f09e7..9d70925b9b 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -613,7 +613,7 @@ def get_conffiles(pkg, d):
conf_list[i] = conf_list[i][1:]
os.chdir(cwd)
- return conf_list
+ return sorted(conf_list)
def legitimize_package_name(s):
"""
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-01 10:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-27 15:37 [PATCH] package: always sort the conffiles Jean-Marie Lemetayer
2023-07-28 10:31 ` [OE-core] " Alexandre Belloni
2023-08-01 7:52 ` [PATCH v2] " Jean-Marie Lemetayer
2023-08-01 7:56 ` Jean-Marie Lemetayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox