Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-Core][PATCH 0/2] patch: reduce changes during patch refresh
@ 2023-11-13 13:57 lukas.funke-oss
  2023-11-13 13:57 ` [OE-Core][PATCH 1/2] patch: extract patches without diffstats lukas.funke-oss
  2023-11-13 13:57 ` [OE-Core][PATCH 2/2] patch: extract patches with all-zero hash lukas.funke-oss
  0 siblings, 2 replies; 4+ messages in thread
From: lukas.funke-oss @ 2023-11-13 13:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: Stefan Herbrechtsmeier, Lukas Funke

From: Lukas Funke <lukas.funke@weidmueller.com>

The patch series aims to reduce the noise in patches created by devtools. Some
diffs are just introduced due to an update in the hash or in the diffstats.
These changes are not important to a reviewer.

Stefan Herbrechtsmeier (2):
  patch: extract patches without diffstats
  patch: extract patches with all-zero hash

 meta/lib/oe/patch.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.30.2



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [OE-Core][PATCH 1/2] patch: extract patches without diffstats
  2023-11-13 13:57 [OE-Core][PATCH 0/2] patch: reduce changes during patch refresh lukas.funke-oss
@ 2023-11-13 13:57 ` lukas.funke-oss
  2023-11-14 11:05   ` Alexandre Belloni
  2023-11-13 13:57 ` [OE-Core][PATCH 2/2] patch: extract patches with all-zero hash lukas.funke-oss
  1 sibling, 1 reply; 4+ messages in thread
From: lukas.funke-oss @ 2023-11-13 13:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: Stefan Herbrechtsmeier

From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

Extract patches without diffstats to reduce changes during patch
refresh.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
 meta/lib/oe/patch.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py
index 4ec9caed45..71cd193afb 100644
--- a/meta/lib/oe/patch.py
+++ b/meta/lib/oe/patch.py
@@ -464,7 +464,8 @@ class GitApplyTree(PatchTree):
         import shutil
         tempdir = tempfile.mkdtemp(prefix='oepatch')
         try:
-            shellcmd = ["git", "format-patch", "--no-signature", "--no-numbered", startcommit, "-o", tempdir]
+            shellcmd = ["git", "format-patch", "--no-signature", "--no-numbered",
+                        "--no-stat", startcommit, "-o", tempdir]
             if paths:
                 shellcmd.append('--')
                 shellcmd.extend(paths)
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [OE-Core][PATCH 2/2] patch: extract patches with all-zero hash
  2023-11-13 13:57 [OE-Core][PATCH 0/2] patch: reduce changes during patch refresh lukas.funke-oss
  2023-11-13 13:57 ` [OE-Core][PATCH 1/2] patch: extract patches without diffstats lukas.funke-oss
@ 2023-11-13 13:57 ` lukas.funke-oss
  1 sibling, 0 replies; 4+ messages in thread
From: lukas.funke-oss @ 2023-11-13 13:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: Stefan Herbrechtsmeier

From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

Extract patches with all-zero hash in each patch header instead of the
hash of the commit to reduce changes during patch refresh.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
 meta/lib/oe/patch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py
index 71cd193afb..cc4c8f4371 100644
--- a/meta/lib/oe/patch.py
+++ b/meta/lib/oe/patch.py
@@ -465,7 +465,7 @@ class GitApplyTree(PatchTree):
         tempdir = tempfile.mkdtemp(prefix='oepatch')
         try:
             shellcmd = ["git", "format-patch", "--no-signature", "--no-numbered",
-                        "--no-stat", startcommit, "-o", tempdir]
+                        "--no-stat", "--zero-commit", startcommit, "-o", tempdir]
             if paths:
                 shellcmd.append('--')
                 shellcmd.extend(paths)
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [OE-Core][PATCH 1/2] patch: extract patches without diffstats
  2023-11-13 13:57 ` [OE-Core][PATCH 1/2] patch: extract patches without diffstats lukas.funke-oss
@ 2023-11-14 11:05   ` Alexandre Belloni
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2023-11-14 11:05 UTC (permalink / raw)
  To: Lukas Funke; +Cc: openembedded-core, Stefan Herbrechtsmeier

On 13/11/2023 14:57:45+0100, Lukas Funke wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 
> Extract patches without diffstats to reduce changes during patch
> refresh.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

This also need your SoB
> ---
>  meta/lib/oe/patch.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py
> index 4ec9caed45..71cd193afb 100644
> --- a/meta/lib/oe/patch.py
> +++ b/meta/lib/oe/patch.py
> @@ -464,7 +464,8 @@ class GitApplyTree(PatchTree):
>          import shutil
>          tempdir = tempfile.mkdtemp(prefix='oepatch')
>          try:
> -            shellcmd = ["git", "format-patch", "--no-signature", "--no-numbered", startcommit, "-o", tempdir]
> +            shellcmd = ["git", "format-patch", "--no-signature", "--no-numbered",
> +                        "--no-stat", startcommit, "-o", tempdir]
>              if paths:
>                  shellcmd.append('--')
>                  shellcmd.extend(paths)
> -- 
> 2.30.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#190471): https://lists.openembedded.org/g/openembedded-core/message/190471
> Mute This Topic: https://lists.openembedded.org/mt/102561450/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-14 11:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 13:57 [OE-Core][PATCH 0/2] patch: reduce changes during patch refresh lukas.funke-oss
2023-11-13 13:57 ` [OE-Core][PATCH 1/2] patch: extract patches without diffstats lukas.funke-oss
2023-11-14 11:05   ` Alexandre Belloni
2023-11-13 13:57 ` [OE-Core][PATCH 2/2] patch: extract patches with all-zero hash lukas.funke-oss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox