Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Konrad Weihmann <kweihmann@outlook.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] recipetool: limit added checksums
Date: Fri, 8 Dec 2023 16:13:54 +0100	[thread overview]
Message-ID: <202312081513545549110e@mail.local> (raw)
In-Reply-To: <PR2PR09MB3100441110E563C11000C461A887A@PR2PR09MB3100.eurprd09.prod.outlook.com>

Hello,

I realized I didn't reply but this was causing failures on the
autobuilders:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6088/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/6138/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6153/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/6143/steps/14/logs/stdio

And we now have another submission doing the same thing (that I also
fixed later on).

On 03/12/2023 10:36:14+0000, Konrad Weihmann wrote:
> to the same values that are used in bb.fetch.
> Currently that would only add sha256sum to the created recipe,
> which is the preferred choice over md5
> 
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
>  scripts/lib/recipetool/create.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
> index 293198d1c8..0016be3e7b 100644
> --- a/scripts/lib/recipetool/create.py
> +++ b/scripts/lib/recipetool/create.py
> @@ -677,7 +677,10 @@ def create_recipe(args):
>      if not srcuri:
>          lines_before.append('# No information for SRC_URI yet (only an external source tree was specified)')
>      lines_before.append('SRC_URI = "%s"' % srcuri)
> +    checksums_shown_list = ["%ssum" % x for x in bb.fetch2.SHOWN_CHECKSUM_LIST]
>      for key, value in sorted(checksums.items()):
> +        if key not in checksums_shown_list:
> +            continue
>          lines_before.append('SRC_URI[%s] = "%s"' % (key, value))
>      if srcuri and supports_srcrev(srcuri):
>          lines_before.append('')
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#191708): https://lists.openembedded.org/g/openembedded-core/message/191708
> Mute This Topic: https://lists.openembedded.org/mt/102949370/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2023-12-08 15:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03 10:36 [PATCH] recipetool: limit added checksums Konrad Weihmann
2023-12-08 15:13 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202312081513545549110e@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=kweihmann@outlook.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox