[PATCH] recipetool: limit added checksums

[PATCH] recipetool: limit added checksums

[Konrad Weihmann]

to the same values that are used in bb.fetch.
Currently that would only add sha256sum to the created recipe,
which is the preferred choice over md5

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
 scripts/lib/recipetool/create.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
index 293198d1c8..0016be3e7b 100644
--- a/scripts/lib/recipetool/create.py
+++ b/scripts/lib/recipetool/create.py
@@ -677,7 +677,10 @@ def create_recipe(args):
     if not srcuri:
         lines_before.append('# No information for SRC_URI yet (only an external source tree was specified)')
     lines_before.append('SRC_URI = "%s"' % srcuri)
+    checksums_shown_list = ["%ssum" % x for x in bb.fetch2.SHOWN_CHECKSUM_LIST]
     for key, value in sorted(checksums.items()):
+        if key not in checksums_shown_list:
+            continue
         lines_before.append('SRC_URI[%s] = "%s"' % (key, value))
     if srcuri and supports_srcrev(srcuri):
         lines_before.append('')
-- 
2.34.1

Re: [OE-core] [PATCH] recipetool: limit added checksums

[Alexandre Belloni]

Hello,

I realized I didn't reply but this was causing failures on the
autobuilders:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6088/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/6138/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6153/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/6143/steps/14/logs/stdio

And we now have another submission doing the same thing (that I also
fixed later on).

On 03/12/2023 10:36:14+0000, Konrad Weihmann wrote:
> to the same values that are used in bb.fetch.
> Currently that would only add sha256sum to the created recipe,
> which is the preferred choice over md5
> 
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
>  scripts/lib/recipetool/create.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
> index 293198d1c8..0016be3e7b 100644
> --- a/scripts/lib/recipetool/create.py
> +++ b/scripts/lib/recipetool/create.py
> @@ -677,7 +677,10 @@ def create_recipe(args):
>      if not srcuri:
>          lines_before.append('# No information for SRC_URI yet (only an external source tree was specified)')
>      lines_before.append('SRC_URI = "%s"' % srcuri)
> +    checksums_shown_list = ["%ssum" % x for x in bb.fetch2.SHOWN_CHECKSUM_LIST]
>      for key, value in sorted(checksums.items()):
> +        if key not in checksums_shown_list:
> +            continue
>          lines_before.append('SRC_URI[%s] = "%s"' % (key, value))
>      if srcuri and supports_srcrev(srcuri):
>          lines_before.append('')
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#191708): https://lists.openembedded.org/g/openembedded-core/message/191708
> Mute This Topic: https://lists.openembedded.org/mt/102949370/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com