Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] glib-2.0: pull in python3-dbusmock unconditionally
@ 2024-01-12 12:41 Alexander Kanavin
  2024-01-12 12:41 ` [PATCH 2/2] python: update 3.11.5 -> 3.12.1 Alexander Kanavin
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2024-01-12 12:41 UTC (permalink / raw)
  To: openembedded-core; +Cc: Alexander Kanavin

With python 3.12 some of the glib ptests started failing. Inspection
revealed that they fail because all tests in some glib's test suites are skipped;
python 3.12's unittest module deems "no tests in a test suite were executed"
a failure (and I tend to agree).

Why are all the tests skipped? Because python dbus module is missing from
the image, and it's missing because it's pulled in by dbusmock, which
in turn is missing because it is pulled in subject to GI_DATA_ENABLED, and
that variable is not global but defined in a g-i class that glib does
not include and never did. So it was simply always excluded regardless
of g-i settings.

Back when this condition was added python3-dbusmock wouldn't build without
introspection data enabled; now it does, so we can again pull it
into ptest dependencies without conditions.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/recipes-core/glib-2.0/glib.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index ae6fc519922..9562bc23ebb 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -175,7 +175,7 @@ RDEPENDS:${PN}-ptest += "\
             ${PN}-locale-th \
             python3-core \
             python3-modules \
-            ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'python3-dbusmock', '', d)} \
+            python3-dbusmock \
             ${PN}-codegen \
             locale-base-de-de \
             locale-base-es-es \
-- 
2.39.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-16  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-12 12:41 [PATCH 1/2] glib-2.0: pull in python3-dbusmock unconditionally Alexander Kanavin
2024-01-12 12:41 ` [PATCH 2/2] python: update 3.11.5 -> 3.12.1 Alexander Kanavin
2024-01-16  7:56   ` [OE-core] " Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox