[PATCH V2] tcmode-default.inc: use ?= to set PREFERRED_VERSION_llvm/llvm-native/nativesdk-llvm

[PATCH V2] tcmode-default.inc: use ?= to set PREFERRED_VERSION_llvm/llvm-native/nativesdk-llvm

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

If meta-clang is included, LLVMVERSION might set to version different
from llvm version in oe-core, and PREFERRED_PROVIDER_llvm set to clang,
In this condition, following warning is reported:
WARNING: preferred version 16.0.1 of llvm-native not available (for item llvm-native)
WARNING: versions of llvm-native available: 15.0.7

use ?= to set following configs in order to allow user
to override the default settings:
PREFERRED_VERSION_llvm
PREFERRED_VERSION_llvm-native
PREFERRED_VERSION_nativesdk-llvm

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/conf/distro/include/tcmode-default.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index 3720a4c5b8..0de858d3af 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
 
-PREFERRED_VERSION_llvm = "${LLVMVERSION}"
-PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
-PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
+PREFERRED_VERSION_llvm ?= "${LLVMVERSION}"
+PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}"
+PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}"
 
 # Rust toolchain preferred versions:
 
-- 
2.25.1

Re: [OE-core] [PATCH V2] tcmode-default.inc: use ?= to set PREFERRED_VERSION_llvm/llvm-native/nativesdk-llvm

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3168 bytes --]

-1

This doesn't fix the issue, just makes the work around in other layers a
bit easier to implement. But those other layers will still need to update
whenever llvm recipe version is updated in oe-core which is annoying and
unnecessary.

I have to do the same with LLVM_PREFERRED_VERSION as it was proposed for
oe-core, because I had to apply it in our layer as in:
https://github.com/webosose/meta-webosose/commit/ba43dfb2d9d5256f0fda0127097d794da7fb3af8#diff-47795833863a904c85557a8d6a3cc4528bccac3e02f224bf392197d2f6656c98

but if the same is applied in oe-core then LLVM_PREFERRED_VERSION would be
updated together with llvm recipe upgrades in oe-core and meta-clang users
would get the right LLVMVERSION automatically from meta-clang's layer.conf:
https://github.com/kraj/meta-clang/blob/master/conf/layer.conf#L36

without doing any of these work arounds (other than setting
PREFERRED_PROVIDERS _once_ as described in
https://github.com/kraj/meta-clang/blob/master/README.md#providing-llvm)

NAK

On Tue, Jan 23, 2024 at 3:37 AM Changqing Li <changqing.li@eng.windriver.com>
wrote:

> From: Changqing Li <changqing.li@windriver.com>
>
> If meta-clang is included, LLVMVERSION might set to version different
> from llvm version in oe-core, and PREFERRED_PROVIDER_llvm set to clang,
> In this condition, following warning is reported:
> WARNING: preferred version 16.0.1 of llvm-native not available (for item
> llvm-native)
> WARNING: versions of llvm-native available: 15.0.7
>
> use ?= to set following configs in order to allow user
> to override the default settings:
> PREFERRED_VERSION_llvm
> PREFERRED_VERSION_llvm-native
> PREFERRED_VERSION_nativesdk-llvm
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> index 3720a4c5b8..0de858d3af 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
>  PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
>
> -PREFERRED_VERSION_llvm = "${LLVMVERSION}"
> -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
> -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
> +PREFERRED_VERSION_llvm ?= "${LLVMVERSION}"
> +PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}"
> +PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}"
>
>  # Rust toolchain preferred versions:
>
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#194198):
> https://lists.openembedded.org/g/openembedded-core/message/194198
> Mute This Topic: https://lists.openembedded.org/mt/103902328/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 4720 bytes --]