* [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a
@ 2024-10-16 12:25 Jagadeesh Krishnanjanappa
2024-10-17 1:36 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Jagadeesh Krishnanjanappa @ 2024-10-16 12:25 UTC (permalink / raw)
To: openembedded-core; +Cc: Jagadeesh Krishnanjanappa
Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature
as armv8a instead of aarch64 which is 64-bit armv8a architecture.
It solves the following build error while compiling libgcc-initial
and libssp-nonshared.
-- snip --
aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon'
aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard'
-- snip --
Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
---
meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
index 25bdf12b18..0eb938a240 100644
--- a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
+++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto"
ARMPKGARCH:tune-cortexa32 = "cortexa32"
ARMPKGARCH:tune-cortexa32-crypto = "cortexa32"
# We do not want -march since -mcpu is added above to cover for it
-TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon"
+TUNE_FEATURES:tune-cortexa32 = "armv8a cortexa32 crc callconvention-hard neon"
TUNE_FEATURES:tune-cortexa32-crypto = "${TUNE_FEATURES:tune-cortexa32} crypto"
PACKAGE_EXTRA_ARCHS:tune-cortexa32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon"
PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a
2024-10-16 12:25 [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a Jagadeesh Krishnanjanappa
@ 2024-10-17 1:36 ` Khem Raj
2024-10-17 8:18 ` Quentin Schulz
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2024-10-17 1:36 UTC (permalink / raw)
To: workjagadeesh; +Cc: openembedded-core
On Wed, Oct 16, 2024 at 5:26 AM Jagadeesh Krishnanjanappa via
lists.openembedded.org
<workjagadeesh=gmail.com@lists.openembedded.org> wrote:
>
> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature
> as armv8a instead of aarch64 which is 64-bit armv8a architecture.
>
That's right. its aarch32 only arch. This change is fine to apply.
> It solves the following build error while compiling libgcc-initial
> and libssp-nonshared.
> -- snip --
> aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon'
> aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard'
> -- snip --
>
> Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
> ---
> meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> index 25bdf12b18..0eb938a240 100644
> --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> @@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto"
> ARMPKGARCH:tune-cortexa32 = "cortexa32"
> ARMPKGARCH:tune-cortexa32-crypto = "cortexa32"
> # We do not want -march since -mcpu is added above to cover for it
> -TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon"
> +TUNE_FEATURES:tune-cortexa32 = "armv8a cortexa32 crc callconvention-hard neon"
> TUNE_FEATURES:tune-cortexa32-crypto = "${TUNE_FEATURES:tune-cortexa32} crypto"
> PACKAGE_EXTRA_ARCHS:tune-cortexa32 = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon"
> PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto"
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#205965): https://lists.openembedded.org/g/openembedded-core/message/205965
> Mute This Topic: https://lists.openembedded.org/mt/109042469/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a
2024-10-17 1:36 ` Khem Raj
@ 2024-10-17 8:18 ` Quentin Schulz
2024-10-17 8:34 ` Alexander Kanavin
0 siblings, 1 reply; 5+ messages in thread
From: Quentin Schulz @ 2024-10-17 8:18 UTC (permalink / raw)
To: raj.khem, workjagadeesh; +Cc: openembedded-core
Hi Khem, Jagadeesh,
On 10/17/24 3:36 AM, Khem Raj via lists.openembedded.org wrote:
> On Wed, Oct 16, 2024 at 5:26 AM Jagadeesh Krishnanjanappa via
> lists.openembedded.org
> <workjagadeesh=gmail.com@lists.openembedded.org> wrote:
>>
>> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature
>> as armv8a instead of aarch64 which is 64-bit armv8a architecture.
>>
>
> That's right. its aarch32 only arch. This change is fine to apply.
>
Do we not have an issue with
TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc
callconvention-hard neon"
in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?
Cheers,
Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a
2024-10-17 8:18 ` Quentin Schulz
@ 2024-10-17 8:34 ` Alexander Kanavin
2024-10-17 8:36 ` Quentin Schulz
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Kanavin @ 2024-10-17 8:34 UTC (permalink / raw)
To: quentin.schulz; +Cc: raj.khem, workjagadeesh, openembedded-core
On Thu, 17 Oct 2024 at 10:18, Quentin Schulz via
lists.openembedded.org
<quentin.schulz=cherry.de@lists.openembedded.org> wrote:
> >> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature
> >> as armv8a instead of aarch64 which is 64-bit armv8a architecture.
> >>
> >
> > That's right. its aarch32 only arch. This change is fine to apply.
> >
>
> Do we not have an issue with
> TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc
> callconvention-hard neon"
>
> in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?
The patch is addressing that, no? Is there a different file or a
different issue?
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a
2024-10-17 8:34 ` Alexander Kanavin
@ 2024-10-17 8:36 ` Quentin Schulz
0 siblings, 0 replies; 5+ messages in thread
From: Quentin Schulz @ 2024-10-17 8:36 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: raj.khem, workjagadeesh, openembedded-core
Hi Alex,
On 10/17/24 10:34 AM, Alexander Kanavin wrote:
> On Thu, 17 Oct 2024 at 10:18, Quentin Schulz via
> lists.openembedded.org
> <quentin.schulz=cherry.de@lists.openembedded.org> wrote:
>>>> Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature
>>>> as armv8a instead of aarch64 which is 64-bit armv8a architecture.
>>>>
>>>
>>> That's right. its aarch32 only arch. This change is fine to apply.
>>>
>>
>> Do we not have an issue with
>> TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc
>> callconvention-hard neon"
>>
>> in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?
>
> The patch is addressing that, no? Is there a different file or a
> different issue?
>
Definitely a different issue... with my reading abilities :)
Sorry for the noise.
Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-17 8:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16 12:25 [OE-core][PATCH] tune-cortexa32: set tune feature as armv8a Jagadeesh Krishnanjanappa
2024-10-17 1:36 ` Khem Raj
2024-10-17 8:18 ` Quentin Schulz
2024-10-17 8:34 ` Alexander Kanavin
2024-10-17 8:36 ` Quentin Schulz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox