From: "Enrico Jörns" <ejo@pengutronix.de>
To: openembedded-core@lists.openembedded.org
Cc: yocto@pengutronix.de, Andrej Valek <andrej.v@skyrain.eu>
Subject: [PATCH v2 5/9] busybox: disable defconfig options from login-utilities.cfg
Date: Mon, 28 Oct 2024 09:29:09 +0100 [thread overview]
Message-ID: <20241028082913.418505-6-ejo@pengutronix.de> (raw)
In-Reply-To: <20241028082913.418505-1-ejo@pengutronix.de>
Accidentally enabled in
4335cd24 ("busybox: refresh the defconfig from 1.33.0").
Since this would also enforce wrong ID ranges due to busbox kconfig's
bad handling of 'inactive' options, manually add them to the
login-utilities.cfg fragment.
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
---
meta/recipes-core/busybox/busybox/defconfig | 28 +++++++++----------
.../busybox/busybox/login-utilities.cfg | 3 ++
2 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
index d2a210d535..116286227b 100644
--- a/meta/recipes-core/busybox/busybox/defconfig
+++ b/meta/recipes-core/busybox/busybox/defconfig
@@ -524,41 +524,41 @@ CONFIG_INIT_TERMINAL_TYPE=""
#
# Login/Password Management Utilities
#
-CONFIG_FEATURE_SHADOWPASSWDS=y
+# CONFIG_FEATURE_SHADOWPASSWDS is not set
# CONFIG_USE_BB_PWD_GRP is not set
# CONFIG_USE_BB_SHADOW is not set
CONFIG_USE_BB_CRYPT=y
# CONFIG_USE_BB_CRYPT_SHA is not set
# CONFIG_ADD_SHELL is not set
# CONFIG_REMOVE_SHELL is not set
-CONFIG_ADDGROUP=y
+# CONFIG_ADDGROUP is not set
# CONFIG_FEATURE_ADDUSER_TO_GROUP is not set
-CONFIG_ADDUSER=y
+# CONFIG_ADDUSER is not set
# CONFIG_FEATURE_CHECK_NAMES is not set
-CONFIG_LAST_ID=60000
-CONFIG_FIRST_SYSTEM_ID=100
-CONFIG_LAST_SYSTEM_ID=999
+CONFIG_LAST_ID=0
+CONFIG_FIRST_SYSTEM_ID=0
+CONFIG_LAST_SYSTEM_ID=0
# CONFIG_CHPASSWD is not set
CONFIG_FEATURE_DEFAULT_PASSWD_ALGO=""
# CONFIG_CRYPTPW is not set
# CONFIG_MKPASSWD is not set
-CONFIG_DELUSER=y
-CONFIG_DELGROUP=y
+# CONFIG_DELUSER is not set
+# CONFIG_DELGROUP is not set
# CONFIG_FEATURE_DEL_USER_FROM_GROUP is not set
-CONFIG_GETTY=y
-CONFIG_LOGIN=y
+# CONFIG_GETTY is not set
+# CONFIG_LOGIN is not set
# CONFIG_LOGIN_SESSION_AS_CHILD is not set
# CONFIG_LOGIN_SCRIPTS is not set
# CONFIG_FEATURE_NOLOGIN is not set
# CONFIG_FEATURE_SECURETTY is not set
-CONFIG_PASSWD=y
+# CONFIG_PASSWD is not set
# CONFIG_FEATURE_PASSWD_WEAK_CHECK is not set
-CONFIG_SU=y
+# CONFIG_SU is not set
# CONFIG_FEATURE_SU_SYSLOG is not set
# CONFIG_FEATURE_SU_CHECKS_SHELLS is not set
# CONFIG_FEATURE_SU_BLANK_PW_NEEDS_SECURE_TTY is not set
-CONFIG_SULOGIN=y
-CONFIG_VLOCK=y
+# CONFIG_SULOGIN is not set
+# CONFIG_VLOCK is not set
#
# Linux Ext2 FS Progs
diff --git a/meta/recipes-core/busybox/busybox/login-utilities.cfg b/meta/recipes-core/busybox/busybox/login-utilities.cfg
index cc9b2db502..8a21e80619 100644
--- a/meta/recipes-core/busybox/busybox/login-utilities.cfg
+++ b/meta/recipes-core/busybox/busybox/login-utilities.cfg
@@ -1,5 +1,8 @@
CONFIG_FEATURE_SHADOWPASSWDS=y
CONFIG_ADDUSER=y
+CONFIG_LAST_ID=60000
+CONFIG_FIRST_SYSTEM_ID=100
+CONFIG_LAST_SYSTEM_ID=999
CONFIG_FEATURE_ADDUSER_LONG_OPTIONS=y
CONFIG_ADDGROUP=y
CONFIG_FEATURE_ADDGROUP_LONG_OPTIONS=y
--
2.39.5
next prev parent reply other threads:[~2024-10-28 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 8:29 [PATCH v2 0/9] busybox: cleanup and fix config fragments Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 1/9] busybox: sync config for busybox 1.37 Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 2/9] busybox: disable defconfig options from simpler fragments Enrico Jörns
2024-10-28 9:06 ` Andrej Valek
2024-10-28 10:39 ` Enrico Jörns
2024-10-29 16:32 ` [OE-core] " Andrej Valek
2024-10-29 20:47 ` Enrico Jörns
2024-11-02 20:42 ` Peter Kjellerstedt
2024-10-28 8:29 ` [PATCH v2 3/9] busybox: disable defconfig options from syslog.cfg Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 4/9] busybox: mdev.cfg: remove CONFIG_SETSID Enrico Jörns
2024-10-28 8:29 ` Enrico Jörns [this message]
2024-10-28 8:29 ` [PATCH v2 6/9] busybox: disable defconfig options from unicode.cfg Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 7/9] busybox: disable defconfig options from getopts.cfg and move long opts Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 8/9] busybox: disable long options in defconfig Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 9/9] busybox: disable defconfig options from mount-via-label.cfg Enrico Jörns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028082913.418505-6-ejo@pengutronix.de \
--to=ejo@pengutronix.de \
--cc=andrej.v@skyrain.eu \
--cc=openembedded-core@lists.openembedded.org \
--cc=yocto@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox