From: "Enrico Jörns" <ejo@pengutronix.de>
To: openembedded-core@lists.openembedded.org
Cc: yocto@pengutronix.de, Andrej Valek <andrej.v@skyrain.eu>
Subject: [PATCH v2 7/9] busybox: disable defconfig options from getopts.cfg and move long opts
Date: Mon, 28 Oct 2024 09:29:11 +0100 [thread overview]
Message-ID: <20241028082913.418505-8-ejo@pengutronix.de> (raw)
In-Reply-To: <20241028082913.418505-1-ejo@pengutronix.de>
This disables getopts.cfg fragment options in the defconfig which were
accidentally enabled in 4335cd24 ("busybox: refresh the defconfig from
1.33.0").
Since there is longopts.cfg for long options, move
CONFIG_FEATURE_GETOPT_LONG there. It was probably not placed there
originally since it does not match the naming scheme of the other long
options.
Note that CONFIG_LONG_OPTS will just be dropped since it is enabled in
defconfig anyway.
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
---
meta/recipes-core/busybox/busybox/defconfig | 4 ++--
meta/recipes-core/busybox/busybox/getopts.cfg | 2 --
meta/recipes-core/busybox/busybox/longopts.cfg | 1 +
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
index a65ae674d8..7481ea2d6b 100644
--- a/meta/recipes-core/busybox/busybox/defconfig
+++ b/meta/recipes-core/busybox/busybox/defconfig
@@ -636,8 +636,8 @@ CONFIG_FLOCK=y
# CONFIG_FSCK_MINIX is not set
# CONFIG_FSFREEZE is not set
CONFIG_FSTRIM=y
-CONFIG_GETOPT=y
-CONFIG_FEATURE_GETOPT_LONG=y
+# CONFIG_GETOPT is not set
+# CONFIG_FEATURE_GETOPT_LONG is not set
CONFIG_HEXDUMP=y
# CONFIG_HD is not set
# CONFIG_XXD is not set
diff --git a/meta/recipes-core/busybox/busybox/getopts.cfg b/meta/recipes-core/busybox/busybox/getopts.cfg
index 8db0a4a8f2..26a2e7add9 100644
--- a/meta/recipes-core/busybox/busybox/getopts.cfg
+++ b/meta/recipes-core/busybox/busybox/getopts.cfg
@@ -1,3 +1 @@
CONFIG_GETOPT=y
-CONFIG_LONG_OPTS=y
-CONFIG_FEATURE_GETOPT_LONG=y
diff --git a/meta/recipes-core/busybox/busybox/longopts.cfg b/meta/recipes-core/busybox/busybox/longopts.cfg
index dcfab99919..3255608f64 100644
--- a/meta/recipes-core/busybox/busybox/longopts.cfg
+++ b/meta/recipes-core/busybox/busybox/longopts.cfg
@@ -13,3 +13,4 @@ CONFIG_FEATURE_FTPGETPUT_LONG_OPTIONS=y
CONFIG_FEATURE_IPCALC_LONG_OPTIONS=y
CONFIG_FEATURE_NSLOOKUP_LONG_OPTIONS=y
CONFIG_FEATURE_WGET_LONG_OPTIONS=y
+CONFIG_FEATURE_GETOPT_LONG=y
--
2.39.5
next prev parent reply other threads:[~2024-10-28 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 8:29 [PATCH v2 0/9] busybox: cleanup and fix config fragments Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 1/9] busybox: sync config for busybox 1.37 Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 2/9] busybox: disable defconfig options from simpler fragments Enrico Jörns
2024-10-28 9:06 ` Andrej Valek
2024-10-28 10:39 ` Enrico Jörns
2024-10-29 16:32 ` [OE-core] " Andrej Valek
2024-10-29 20:47 ` Enrico Jörns
2024-11-02 20:42 ` Peter Kjellerstedt
2024-10-28 8:29 ` [PATCH v2 3/9] busybox: disable defconfig options from syslog.cfg Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 4/9] busybox: mdev.cfg: remove CONFIG_SETSID Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 5/9] busybox: disable defconfig options from login-utilities.cfg Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 6/9] busybox: disable defconfig options from unicode.cfg Enrico Jörns
2024-10-28 8:29 ` Enrico Jörns [this message]
2024-10-28 8:29 ` [PATCH v2 8/9] busybox: disable long options in defconfig Enrico Jörns
2024-10-28 8:29 ` [PATCH v2 9/9] busybox: disable defconfig options from mount-via-label.cfg Enrico Jörns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028082913.418505-8-ejo@pengutronix.de \
--to=ejo@pengutronix.de \
--cc=andrej.v@skyrain.eu \
--cc=openembedded-core@lists.openembedded.org \
--cc=yocto@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox