Openembedded Core Discussions
 help / color / mirror / Atom feed
From: mac@mcrowe.com
To: openembedded-core@lists.openembedded.org
Cc: Mike Crowe <mac@mcrowe.com>, Jack Mitchell <jack@embed.me.uk>
Subject: [PATCH] kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty
Date: Fri, 23 May 2025 13:20:45 +0100	[thread overview]
Message-ID: <20250523122045.3097055-1-mac@mcrowe.com> (raw)

From: Mike Crowe <mac@mcrowe.com>

Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB
consistently to avoid parse errors if either side is empty.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Reviewed-by: Jack Mitchell <jack@embed.me.uk>
---
 meta/classes-recipe/kernel-fitimage.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/kernel-fitimage.bbclass b/meta/classes-recipe/kernel-fitimage.bbclass
index 07786647e1..c81c00f777 100644
--- a/meta/classes-recipe/kernel-fitimage.bbclass
+++ b/meta/classes-recipe/kernel-fitimage.bbclass
@@ -593,7 +593,7 @@ fitimage_assemble() {
 		for DTB in $(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtb' -printf '%P\n' | sort) \
 		$(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtbo' -printf '%P\n' | sort); do
 			# Set the default dtb image if it exists in the devicetree.
-			if [ ${FIT_CONF_DEFAULT_DTB} = $DTB ];then
+			if [ "${FIT_CONF_DEFAULT_DTB}" = "$DTB" ];then
 				default_dtb_image=$(echo "$DTB" | tr '/' '_')
 			fi
 
-- 
2.39.5



             reply	other threads:[~2025-05-23 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 12:20 mac [this message]
2025-05-25 15:41 ` [OE-core] [PATCH] kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty Mathieu Dubois-Briand
2025-05-25 18:45   ` Mike Crowe
2025-05-26  6:56     ` Mathieu Dubois-Briand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523122045.3097055-1-mac@mcrowe.com \
    --to=mac@mcrowe.com \
    --cc=jack@embed.me.uk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox