Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mike Crowe <mac@mcrowe.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: openembedded-core@lists.openembedded.org,
	Jack Mitchell <jack@embed.me.uk>
Subject: Re: [OE-core] [PATCH] kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty
Date: Sun, 25 May 2025 19:45:26 +0100	[thread overview]
Message-ID: <aDNlRimrPXkm-2MS@mcrowe.com> (raw)
In-Reply-To: <DA5CTNMVP3RK.LB01EWGV6S6C@bootlin.com>

On Sunday 25 May 2025 at 17:41:51 +0200, Mathieu Dubois-Briand wrote:
> On Fri May 23, 2025 at 2:20 PM CEST, Mike Crowe via lists.openembedded.org wrote:
> > From: Mike Crowe <mac@mcrowe.com>
> >
> > Quote both sides of the comparison of ${FIT_CONF_DEFAULT_DTB} and $DTB
> > consistently to avoid parse errors if either side is empty.
> >
> > Signed-off-by: Mike Crowe <mac@mcrowe.com>
> > Reviewed-by: Jack Mitchell <jack@embed.me.uk>
> > ---
> 
> Hi Mike,
> 
> Thanks for your patch.
> 
> Just a note: this patch is conflicting with the "FIT image improvements"
> series:
> https://lists.openembedded.org/g/openembedded-core/message/217192
> 
> As this series is most likely going to be merged soon, can you rewrite
> your patch on top of it?

Hi Mathieu,

I spotted that not long after I posted my patch. I replied, but somehow I
only managed to send that reply to Adrian Freihofer, the author of the
conflicting patch. Anyway, here's what I said:

> It looks like Adrian Freihofer's
> "[PATCH v5 14/17] kernel-fitimage: re-write its code in Python"
> in <20250523094152.727177-15-adrian.freihofer@siemens.com> removes this code
> and replaces it with Python which won't suffer from the problem. That's
> much better than my fix above.

So my patch can be ignored.

Thanks and sorry for the hassle.

Mike.


  reply	other threads:[~2025-05-25 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 12:20 [PATCH] kernel-fitimage: Cope with FIT_CONF_DEFAULT_DTB being empty mac
2025-05-25 15:41 ` [OE-core] " Mathieu Dubois-Briand
2025-05-25 18:45   ` Mike Crowe [this message]
2025-05-26  6:56     ` Mathieu Dubois-Briand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDNlRimrPXkm-2MS@mcrowe.com \
    --to=mac@mcrowe.com \
    --cc=jack@embed.me.uk \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox