public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
@ 2026-01-20  7:36 Shaik Moin
  2026-01-20  7:36 ` [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems Shaik Moin
  2026-02-08 23:30 ` [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Yoann Congal
  0 siblings, 2 replies; 12+ messages in thread
From: Shaik Moin @ 2026-01-20  7:36 UTC (permalink / raw)
  To: openembedded-core; +Cc: careers.myinfo

Install libpcre2 test suite and run it as ptest.

Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine (RunTest), and grep utility (RunGrepTest).

pcre2posix_test: Verifies the POSIX wrapper API
RunTest: Executes the core PCRE2 test suite through pcre2test
RunGrepTest: Checks pcre2grep to ensure its grep‑style matching works as expected with various patterns and input files.

Signed-off-by: Shaik Moin <moins@kpit.com>
---
 .../distro/include/ptest-packagelists.inc     |  1 +
 .../libpcre/libpcre2/run-ptest                | 45 +++++++++++++++++++
 .../recipes-support/libpcre/libpcre2_10.43.bb | 21 ++++++++-
 3 files changed, 65 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-support/libpcre/libpcre2/run-ptest

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index 9950e46776..b7393a7c65 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -31,6 +31,7 @@ PTESTS_FAST = "\
     libgpg-error\
     libnl \
     libpcre \
+    libpcre2 \
     libssh2 \
     libtimedate-perl \
     libtest-fatal-perl \
diff --git a/meta/recipes-support/libpcre/libpcre2/run-ptest b/meta/recipes-support/libpcre/libpcre2/run-ptest
new file mode 100644
index 0000000000..aefb971141
--- /dev/null
+++ b/meta/recipes-support/libpcre/libpcre2/run-ptest
@@ -0,0 +1,45 @@
+#!/bin/sh
+
+echo "START: ptest-runner"
+date +"%Y-%m-%dT%H:%M"
+echo "BEGIN: $(pwd)"
+
+# Space-separated list of test binaries
+TESTS="pcre2posix_test RunGrepTest RunTest"
+
+total=0
+pass=0
+fail=0
+results=""
+
+for T in $TESTS; do
+    echo "Running $T"
+    total=$((total + 1))
+    if ./"$T"; then
+        echo "PASS: $T"
+        pass=$((pass + 1))
+        results="${results}\nPASS:  ${T}"
+    else
+        echo "FAIL: $T"
+        fail=$((fail + 1))
+        results="${results}\nFAIL:  ${T}"
+    fi
+done
+echo "============================================================================"
+echo "Testsuite summary for PCRE"
+echo "============================================================================"
+
+if [ -n "$results" ]; then
+    printf "%b\n" "$results"
+fi
+
+# Summary with per-test details
+echo "============================================================================"
+echo "# TOTAL: $total"
+echo "# PASS:  $pass"
+echo "# FAIL:  $fail"
+echo "============================================================================"
+
+# Exit code based on failures
+[ "$fail" -eq 0 ] && exit 0 || exit 1
+
diff --git a/meta/recipes-support/libpcre/libpcre2_10.43.bb b/meta/recipes-support/libpcre/libpcre2_10.43.bb
index f744df88fa..57c4f0d0e7 100644
--- a/meta/recipes-support/libpcre/libpcre2_10.43.bb
+++ b/meta/recipes-support/libpcre/libpcre2_10.43.bb
@@ -10,7 +10,9 @@ SECTION = "devel"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENCE;md5=321a5eb46acae6b6c1ff2c7a866d836a"
 
-SRC_URI = "${GITHUB_BASE_URI}/download/pcre2-${PV}/pcre2-${PV}.tar.bz2"
+SRC_URI = "${GITHUB_BASE_URI}/download/pcre2-${PV}/pcre2-${PV}.tar.bz2 \
+           file://run-ptest \
+"
 
 GITHUB_BASE_URI = "https://github.com/PCRE2Project/pcre2/releases"
 UPSTREAM_CHECK_REGEX = "releases/tag/pcre2-(?P<pver>\d+(\.\d+)+)$"
@@ -26,7 +28,7 @@ DEPENDS += "bzip2 zlib"
 
 BINCONFIG = "${bindir}/pcre2-config"
 
-inherit autotools binconfig-disabled github-releases
+inherit autotools binconfig-disabled github-releases ptest
 
 EXTRA_OECONF = "\
     --enable-newline-is-lf \
@@ -53,3 +55,18 @@ FILES:pcre2test = "${bindir}/pcre2test"
 FILES:pcre2test-doc = "${mandir}/man1/pcre2test.1"
 
 BBCLASSEXTEND = "native nativesdk"
+
+do_install_ptest() {
+        t=${D}${PTEST_PATH}
+        cp -r ${S}/testdata $t
+        for i in pcre2posix_test pcre2grep pcre2test; \
+          do cp ${B}/.libs/$i $t; \
+        done
+        for i in RunTest RunGrepTest test-driver; \
+          do cp ${S}/$i $t; \
+        done
+        # Skip the fr_FR locale test. If the locale fr_FR is found, it is tested.
+        # If not found, the test is skipped. The test program assumes fr_FR is non-UTF-8
+        # locale so the test fails if fr_FR is UTF-8 locale.
+        sed -i -e 's:do3=yes:do3=no:g' ${D}${PTEST_PATH}/RunTest
+}
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems
  2026-01-20  7:36 [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Shaik Moin
@ 2026-01-20  7:36 ` Shaik Moin
  2026-02-08 23:49   ` Yoann Congal
  2026-02-08 23:30 ` [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Yoann Congal
  1 sibling, 1 reply; 12+ messages in thread
From: Shaik Moin @ 2026-01-20  7:36 UTC (permalink / raw)
  To: openembedded-core; +Cc: careers.myinfo

The PCRE2 RunGrepTest script uses the Gnu Coreutils form:
head -1

Busybox does not support this shorthand option and reports:
head: invalid option --'1'

which cause the grep tests fail when running ptest on yocto.
Replace head -1 with head -n 1 . This makes RunGrepTest work
correctly.

Signed-off-by: Shaik Moin <moins@kpit.com>
---
 .../0001-test-Fix-head-1-Busybox.patch        | 38 +++++++++++++++++++
 .../recipes-support/libpcre/libpcre2_10.43.bb |  1 +
 2 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch

diff --git a/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch b/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch
new file mode 100644
index 0000000000..abfc995cee
--- /dev/null
+++ b/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch
@@ -0,0 +1,38 @@
+From 1b2c3d4e5f6a7b8c9d0 Mon Sep 17 00:00:00 2001
+From: Shaik Moin <moins@kpit.com>
+Date: Tue, 18 Nov 2025 10:30:00 +0530
+Subject: [PATCH] tests: Fix head options for BusyBox compatibility
+
+BusyBox does not accept the GNU coreutils shorthand forms:
+  head -1
+ 
+It requires:
+  head -n 1
+ 
+This causes RunGrepTest test data to fail on
+Yocto-based systems that use BusyBox.
+ 
+Replace all occurrences of `head -1` → `head -n 1`
+ 
+This aligns the scripts with POSIX syntax and fixes failing
+grep tests in RunGrepTest (including testtrygrep).
+ 
+Upstream-Status: Inappropriate [oe-specific]
+Signed-off-by: Shaik Moin <moins@kpit.com>
+---
+ 
+diff --git a/RunGrepTest b/RunGrepTest
+index 1c7bbd2..ab4f310 100755
+--- a/RunGrepTest
++++ b/RunGrepTest
+@@ -728,7 +728,7 @@ echo "---------------------------- Test
+ echo "RC=$?" >>testtrygrep
+
+ echo "---------------------------- Test 132 -----------------------------" >>testtrygrep
+-(cd $srcdir; exec 3<testdata/grepinput; $valgrind $vjs $pcre2grep -m1 -A3 '^match' <&3; echo '---'; head -1 <&3; exec 3<&-) >>testtrygrep 2>&1
++(cd $srcdir; exec 3<testdata/grepinput; $valgrind $vjs $pcre2grep -m1 -A3 '^match' <&3; echo '---'; head -n 1 <&3; exec 3<&-) >>testtrygrep 2>&1
+ echo "RC=$?" >>testtrygrep
+
+ echo "---------------------------- Test 133 -----------------------------" >>testtrygrep
+-- 
+2.34.1
diff --git a/meta/recipes-support/libpcre/libpcre2_10.43.bb b/meta/recipes-support/libpcre/libpcre2_10.43.bb
index 57c4f0d0e7..f250f35584 100644
--- a/meta/recipes-support/libpcre/libpcre2_10.43.bb
+++ b/meta/recipes-support/libpcre/libpcre2_10.43.bb
@@ -12,6 +12,7 @@ LIC_FILES_CHKSUM = "file://LICENCE;md5=321a5eb46acae6b6c1ff2c7a866d836a"
 
 SRC_URI = "${GITHUB_BASE_URI}/download/pcre2-${PV}/pcre2-${PV}.tar.bz2 \
            file://run-ptest \
+           file://0001-test-Fix-head-1-Busybox.patch \
 "
 
 GITHUB_BASE_URI = "https://github.com/PCRE2Project/pcre2/releases"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-01-20  7:36 [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Shaik Moin
  2026-01-20  7:36 ` [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems Shaik Moin
@ 2026-02-08 23:30 ` Yoann Congal
  1 sibling, 0 replies; 12+ messages in thread
From: Yoann Congal @ 2026-02-08 23:30 UTC (permalink / raw)
  To: careers.myinfo, openembedded-core

On Tue Jan 20, 2026 at 8:36 AM CET, Shaik Moin via lists.openembedded.org wrote:
> Install libpcre2 test suite and run it as ptest.
>
> Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine (RunTest), and grep utility (RunGrepTest).
>
> pcre2posix_test: Verifies the POSIX wrapper API
> RunTest: Executes the core PCRE2 test suite through pcre2test
> RunGrepTest: Checks pcre2grep to ensure its grep‑style matching works as expected with various patterns and input files.
>
> Signed-off-by: Shaik Moin <moins@kpit.com>
> ---
>  .../distro/include/ptest-packagelists.inc     |  1 +
>  .../libpcre/libpcre2/run-ptest                | 45 +++++++++++++++++++
>  .../recipes-support/libpcre/libpcre2_10.43.bb | 21 ++++++++-
>  3 files changed, 65 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-support/libpcre/libpcre2/run-ptest

Hello,

Thanks for the patches but adding ptest is not usually acceptable under
the stable policy[0]. That also applies to your kirkstone patch.

[0]: https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies

Regards,
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems
  2026-01-20  7:36 ` [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems Shaik Moin
@ 2026-02-08 23:49   ` Yoann Congal
  0 siblings, 0 replies; 12+ messages in thread
From: Yoann Congal @ 2026-02-08 23:49 UTC (permalink / raw)
  To: careers.myinfo, openembedded-core

On Tue Jan 20, 2026 at 8:36 AM CET, Shaik Moin via lists.openembedded.org wrote:
> The PCRE2 RunGrepTest script uses the Gnu Coreutils form:
> head -1
>
> Busybox does not support this shorthand option and reports:
> head: invalid option --'1'
>
> which cause the grep tests fail when running ptest on yocto.
> Replace head -1 with head -n 1 . This makes RunGrepTest work
> correctly.
>
> Signed-off-by: Shaik Moin <moins@kpit.com>
> ---
>  .../0001-test-Fix-head-1-Busybox.patch        | 38 +++++++++++++++++++
>  .../recipes-support/libpcre/libpcre2_10.43.bb |  1 +
>  2 files changed, 39 insertions(+)
>  create mode 100644 meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch

Hello,

Is this patch also needed on master? If yes, please send it there.

Thanks!

>
> diff --git a/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch b/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch
> new file mode 100644
> index 0000000000..abfc995cee
> --- /dev/null
> +++ b/meta/recipes-support/libpcre/libpcre2/0001-test-Fix-head-1-Busybox.patch
> @@ -0,0 +1,38 @@
> +From 1b2c3d4e5f6a7b8c9d0 Mon Sep 17 00:00:00 2001
> +From: Shaik Moin <moins@kpit.com>
> +Date: Tue, 18 Nov 2025 10:30:00 +0530
> +Subject: [PATCH] tests: Fix head options for BusyBox compatibility
> +
> +BusyBox does not accept the GNU coreutils shorthand forms:
> +  head -1
> + 
> +It requires:
> +  head -n 1
> + 
> +This causes RunGrepTest test data to fail on
> +Yocto-based systems that use BusyBox.
> + 
> +Replace all occurrences of `head -1` → `head -n 1`
This commit message (and also in 1/2) looks to have an encoding problem. 

> + 
> +This aligns the scripts with POSIX syntax and fixes failing
> +grep tests in RunGrepTest (including testtrygrep).
> + 
> +Upstream-Status: Inappropriate [oe-specific]

I disagree: To me, this patch looks appropriate for upstream.

> +Signed-off-by: Shaik Moin <moins@kpit.com>
> +---
> + 
> +diff --git a/RunGrepTest b/RunGrepTest
> +index 1c7bbd2..ab4f310 100755
> +--- a/RunGrepTest
> ++++ b/RunGrepTest
> +@@ -728,7 +728,7 @@ echo "---------------------------- Test
> + echo "RC=$?" >>testtrygrep
> +
> + echo "---------------------------- Test 132 -----------------------------" >>testtrygrep
> +-(cd $srcdir; exec 3<testdata/grepinput; $valgrind $vjs $pcre2grep -m1 -A3 '^match' <&3; echo '---'; head -1 <&3; exec 3<&-) >>testtrygrep 2>&1
> ++(cd $srcdir; exec 3<testdata/grepinput; $valgrind $vjs $pcre2grep -m1 -A3 '^match' <&3; echo '---'; head -n 1 <&3; exec 3<&-) >>testtrygrep 2>&1
> + echo "RC=$?" >>testtrygrep
> +
> + echo "---------------------------- Test 133 -----------------------------" >>testtrygrep
> +-- 
> +2.34.1
> diff --git a/meta/recipes-support/libpcre/libpcre2_10.43.bb b/meta/recipes-support/libpcre/libpcre2_10.43.bb
> index 57c4f0d0e7..f250f35584 100644
> --- a/meta/recipes-support/libpcre/libpcre2_10.43.bb
> +++ b/meta/recipes-support/libpcre/libpcre2_10.43.bb
> @@ -12,6 +12,7 @@ LIC_FILES_CHKSUM = "file://LICENCE;md5=321a5eb46acae6b6c1ff2c7a866d836a"
>  
>  SRC_URI = "${GITHUB_BASE_URI}/download/pcre2-${PV}/pcre2-${PV}.tar.bz2 \
>             file://run-ptest \
> +           file://0001-test-Fix-head-1-Busybox.patch \
>  "
>  
>  GITHUB_BASE_URI = "https://github.com/PCRE2Project/pcre2/releases"


-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

* [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
@ 2026-02-11  7:23 Shaik Moin
  2026-02-11  8:53 ` Yoann Congal
  0 siblings, 1 reply; 12+ messages in thread
From: Shaik Moin @ 2026-02-11  7:23 UTC (permalink / raw)
  To: openembedded-core; +Cc: careers.myinfo

Install libpcre2 test suite and run it as ptest.

Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine (RunTest), and grep utility (RunGrepTest).

pcre2posix_test: Verifies the POSIX wrapper API
RunTest: Executes the core PCRE2 test suite through pcre2test
RunGrepTest: Checks pcre2grep to ensure its grepping style matching works as expected with various patterns and input files.

Signed-off-by: Shaik Moin <moins@kpit.com>
---
 .../libpcre/libpcre2/run-ptest                | 39 +++++++------------
 .../recipes-support/libpcre/libpcre2_10.43.bb | 22 +++++------
 2 files changed, 22 insertions(+), 39 deletions(-)

diff --git a/meta/recipes-support/libpcre/libpcre2/run-ptest b/meta/recipes-support/libpcre/libpcre2/run-ptest
index aefb971141..2acfd17b17 100644
--- a/meta/recipes-support/libpcre/libpcre2/run-ptest
+++ b/meta/recipes-support/libpcre/libpcre2/run-ptest
@@ -1,39 +1,27 @@
 #!/bin/sh
 
-echo "START: ptest-runner"
-date +"%Y-%m-%dT%H:%M"
-echo "BEGIN: $(pwd)"
-
-# Space-separated list of test binaries
-TESTS="pcre2posix_test RunGrepTest RunTest"
-
+TESTS="RunGrepTest RunTest"
 total=0
 pass=0
 fail=0
-results=""
 
 for T in $TESTS; do
-    echo "Running $T"
-    total=$((total + 1))
-    if ./"$T"; then
-        echo "PASS: $T"
-        pass=$((pass + 1))
-        results="${results}\nPASS:  ${T}"
+    if [ -x "./$T" ]; then
+        echo "Running $T"
+        total=$((total + 1))
+        if "./$T"; then
+            echo "PASS: $T"
+            pass=$((pass + 1))
+        else
+            echo "FAIL: $T"
+            fail=$((fail + 1))
+        fi
     else
-        echo "FAIL: $T"
-        fail=$((fail + 1))
-        results="${results}\nFAIL:  ${T}"
+        echo "SKIP: $T (not found or not executable)"
     fi
 done
-echo "============================================================================"
-echo "Testsuite summary for PCRE"
-echo "============================================================================"
-
-if [ -n "$results" ]; then
-    printf "%b\n" "$results"
-fi
 
-# Summary with per-test details
+# Summary
 echo "============================================================================"
 echo "# TOTAL: $total"
 echo "# PASS:  $pass"
@@ -42,4 +30,3 @@ echo "==========================================================================
 
 # Exit code based on failures
 [ "$fail" -eq 0 ] && exit 0 || exit 1
-
diff --git a/meta/recipes-support/libpcre/libpcre2_10.43.bb b/meta/recipes-support/libpcre/libpcre2_10.43.bb
index f250f35584..781b5f15ba 100644
--- a/meta/recipes-support/libpcre/libpcre2_10.43.bb
+++ b/meta/recipes-support/libpcre/libpcre2_10.43.bb
@@ -12,7 +12,6 @@ LIC_FILES_CHKSUM = "file://LICENCE;md5=321a5eb46acae6b6c1ff2c7a866d836a"
 
 SRC_URI = "${GITHUB_BASE_URI}/download/pcre2-${PV}/pcre2-${PV}.tar.bz2 \
            file://run-ptest \
-           file://0001-test-Fix-head-1-Busybox.patch \
 "
 
 GITHUB_BASE_URI = "https://github.com/PCRE2Project/pcre2/releases"
@@ -58,16 +57,13 @@ FILES:pcre2test-doc = "${mandir}/man1/pcre2test.1"
 BBCLASSEXTEND = "native nativesdk"
 
 do_install_ptest() {
-        t=${D}${PTEST_PATH}
-        cp -r ${S}/testdata $t
-        for i in pcre2posix_test pcre2grep pcre2test; \
-          do cp ${B}/.libs/$i $t; \
-        done
-        for i in RunTest RunGrepTest test-driver; \
-          do cp ${S}/$i $t; \
-        done
-        # Skip the fr_FR locale test. If the locale fr_FR is found, it is tested.
-        # If not found, the test is skipped. The test program assumes fr_FR is non-UTF-8
-        # locale so the test fails if fr_FR is UTF-8 locale.
-        sed -i -e 's:do3=yes:do3=no:g' ${D}${PTEST_PATH}/RunTest
+    t=${D}${PTEST_PATH}
+    cp -r ${S}/testdata $t
+
+    for i in pcre2posix_test pcre2grep pcre2test; do
+        "${B}/libtool" --mode=install install "${B}/$i" "$t"
+    done
+    for i in RunTest RunGrepTest test-driver; \
+      do cp ${S}/$i $t; \
+    done
 }
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-11  7:23 Shaik Moin
@ 2026-02-11  8:53 ` Yoann Congal
  2026-02-18  5:30   ` Shaik Moin
  0 siblings, 1 reply; 12+ messages in thread
From: Yoann Congal @ 2026-02-11  8:53 UTC (permalink / raw)
  To: careers.myinfo, openembedded-core

On Wed Feb 11, 2026 at 8:23 AM CET, Shaik Moin via lists.openembedded.org wrote:
> Install libpcre2 test suite and run it as ptest.
>
> Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine (RunTest), and grep utility (RunGrepTest).
>
> pcre2posix_test: Verifies the POSIX wrapper API
> RunTest: Executes the core PCRE2 test suite through pcre2test
> RunGrepTest: Checks pcre2grep to ensure its grepping style matching works as expected with various patterns and input files.
>
> Signed-off-by: Shaik Moin <moins@kpit.com>
> ---
>  .../libpcre/libpcre2/run-ptest                | 39 +++++++------------
>  .../recipes-support/libpcre/libpcre2_10.43.bb | 22 +++++------
>  2 files changed, 22 insertions(+), 39 deletions(-)

Thanks for the patches but, as I already wrote, adding ptest is not
usually acceptable under the stable policy[0]. That also applies to your
kirkstone patch.

[0]: https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies

Regards,
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-11  8:53 ` Yoann Congal
@ 2026-02-18  5:30   ` Shaik Moin
  2026-02-18  8:01     ` Yoann Congal
  0 siblings, 1 reply; 12+ messages in thread
From: Shaik Moin @ 2026-02-18  5:30 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Hi team,

I updated master branch patch. Please check.

Thanks!

On Wed, 11 Feb 2026, 2:23 pm Yoann Congal, <yoann.congal@smile.fr> wrote:

> On Wed Feb 11, 2026 at 8:23 AM CET, Shaik Moin via lists.openembedded.org
> wrote:
> > Install libpcre2 test suite and run it as ptest.
> >
> > Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine
> (RunTest), and grep utility (RunGrepTest).
> >
> > pcre2posix_test: Verifies the POSIX wrapper API
> > RunTest: Executes the core PCRE2 test suite through pcre2test
> > RunGrepTest: Checks pcre2grep to ensure its grepping style matching
> works as expected with various patterns and input files.
> >
> > Signed-off-by: Shaik Moin <moins@kpit.com>
> > ---
> >  .../libpcre/libpcre2/run-ptest                | 39 +++++++------------
> >  .../recipes-support/libpcre/libpcre2_10.43.bb | 22 +++++------
> >  2 files changed, 22 insertions(+), 39 deletions(-)
>
> Thanks for the patches but, as I already wrote, adding ptest is not
> usually acceptable under the stable policy[0]. That also applies to your
> kirkstone patch.
>
> [0]:
> https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies
>
> Regards,
> --
> Yoann Congal
> Smile ECS
>
>

[-- Attachment #2: Type: text/html, Size: 2129 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-18  5:30   ` Shaik Moin
@ 2026-02-18  8:01     ` Yoann Congal
  2026-02-18  8:16       ` Marko, Peter
  0 siblings, 1 reply; 12+ messages in thread
From: Yoann Congal @ 2026-02-18  8:01 UTC (permalink / raw)
  To: careers.myinfo, openembedded-core

On Wed Feb 18, 2026 at 6:30 AM CET, Shaik Moin via lists.openembedded.org wrote:
> Hi team,
>
> I updated master branch patch. Please check.

Hello,

Sorry, but this patch is not acceptable on stable branches under the
policy[0] regarless to its master merging status.

[0]: https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies

Regards,
>
> Thanks!
>
> On Wed, 11 Feb 2026, 2:23 pm Yoann Congal, <yoann.congal@smile.fr> wrote:
>
>> On Wed Feb 11, 2026 at 8:23 AM CET, Shaik Moin via lists.openembedded.org
>> wrote:
>> > Install libpcre2 test suite and run it as ptest.
>> >
>> > Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine
>> (RunTest), and grep utility (RunGrepTest).
>> >
>> > pcre2posix_test: Verifies the POSIX wrapper API
>> > RunTest: Executes the core PCRE2 test suite through pcre2test
>> > RunGrepTest: Checks pcre2grep to ensure its grepping style matching
>> works as expected with various patterns and input files.
>> >
>> > Signed-off-by: Shaik Moin <moins@kpit.com>
>> > ---
>> >  .../libpcre/libpcre2/run-ptest                | 39 +++++++------------
>> >  .../recipes-support/libpcre/libpcre2_10.43.bb | 22 +++++------
>> >  2 files changed, 22 insertions(+), 39 deletions(-)
>>
>> Thanks for the patches but, as I already wrote, adding ptest is not
>> usually acceptable under the stable policy[0]. That also applies to your
>> kirkstone patch.
>>
>> [0]:
>> https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies
>>
>> Regards,
>> --
>> Yoann Congal
>> Smile ECS
>>
>>


-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-18  8:01     ` Yoann Congal
@ 2026-02-18  8:16       ` Marko, Peter
  2026-02-19 14:35         ` Yoann Congal
  0 siblings, 1 reply; 12+ messages in thread
From: Marko, Peter @ 2026-02-18  8:16 UTC (permalink / raw)
  To: yoann.congal@smile.fr, careers.myinfo@gmail.com,
	openembedded-core@lists.openembedded.org

Could we add "adding/improving tests" to the allowed LTS backport items?
I think we're shooting ourselves in the foot here.

Peter

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Yoann Congal via
> lists.openembedded.org
> Sent: Wednesday, February 18, 2026 9:02
> To: careers.myinfo@gmail.com; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
> 
> On Wed Feb 18, 2026 at 6:30 AM CET, Shaik Moin via lists.openembedded.org
> wrote:
> > Hi team,
> >
> > I updated master branch patch. Please check.
> 
> Hello,
> 
> Sorry, but this patch is not acceptable on stable branches under the
> policy[0] regarless to its master merging status.
> 
> [0]:
> https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acc
> eptance_Policies
> 
> Regards,
> >
> > Thanks!
> >
> > On Wed, 11 Feb 2026, 2:23 pm Yoann Congal, <yoann.congal@smile.fr> wrote:
> >
> >> On Wed Feb 11, 2026 at 8:23 AM CET, Shaik Moin via lists.openembedded.org
> >> wrote:
> >> > Install libpcre2 test suite and run it as ptest.
> >> >
> >> > Add tests for POSIX wrapper (pcre2posix_test), core PCRE2 engine
> >> (RunTest), and grep utility (RunGrepTest).
> >> >
> >> > pcre2posix_test: Verifies the POSIX wrapper API
> >> > RunTest: Executes the core PCRE2 test suite through pcre2test
> >> > RunGrepTest: Checks pcre2grep to ensure its grepping style matching
> >> works as expected with various patterns and input files.
> >> >
> >> > Signed-off-by: Shaik Moin <moins@kpit.com>
> >> > ---
> >> >  .../libpcre/libpcre2/run-ptest                | 39 +++++++------------
> >> >  .../recipes-support/libpcre/libpcre2_10.43.bb | 22 +++++------
> >> >  2 files changed, 22 insertions(+), 39 deletions(-)
> >>
> >> Thanks for the patches but, as I already wrote, adding ptest is not
> >> usually acceptable under the stable policy[0]. That also applies to your
> >> kirkstone patch.
> >>
> >> [0]:
> >>
> https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acc
> eptance_Policies
> >>
> >> Regards,
> >> --
> >> Yoann Congal
> >> Smile ECS
> >>
> >>
> 
> 
> --
> Yoann Congal
> Smile ECS


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-18  8:16       ` Marko, Peter
@ 2026-02-19 14:35         ` Yoann Congal
  2026-02-20  6:29           ` Shaik Moin
  2026-03-06 18:52           ` Yoann Congal
  0 siblings, 2 replies; 12+ messages in thread
From: Yoann Congal @ 2026-02-19 14:35 UTC (permalink / raw)
  To: Marko, Peter, careers.myinfo@gmail.com,
	openembedded-core@lists.openembedded.org

On Wed Feb 18, 2026 at 9:16 AM CET, Peter Marko wrote:
> Could we add "adding/improving tests" to the allowed LTS backport items?
> I think we're shooting ourselves in the foot here.

FYI, I've asked the Yocto Project TSC about this.

Regards,
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-19 14:35         ` Yoann Congal
@ 2026-02-20  6:29           ` Shaik Moin
  2026-03-06 18:52           ` Yoann Congal
  1 sibling, 0 replies; 12+ messages in thread
From: Shaik Moin @ 2026-02-20  6:29 UTC (permalink / raw)
  To: Yoann Congal; +Cc: Marko, Peter, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hi Yoann,

We are not going including this patch as per policy. I have addressed the
comments of master branch and informed that here. Please review that patch.

Thanks,
Moin

On Thu, 19 Feb 2026, 8:05 pm Yoann Congal, <yoann.congal@smile.fr> wrote:

> On Wed Feb 18, 2026 at 9:16 AM CET, Peter Marko wrote:
> > Could we add "adding/improving tests" to the allowed LTS backport items?
> > I think we're shooting ourselves in the foot here.
>
> FYI, I've asked the Yocto Project TSC about this.
>
> Regards,
> --
> Yoann Congal
> Smile ECS
>
>

[-- Attachment #2: Type: text/html, Size: 1000 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support
  2026-02-19 14:35         ` Yoann Congal
  2026-02-20  6:29           ` Shaik Moin
@ 2026-03-06 18:52           ` Yoann Congal
  1 sibling, 0 replies; 12+ messages in thread
From: Yoann Congal @ 2026-03-06 18:52 UTC (permalink / raw)
  To: Yoann Congal, Marko, Peter, careers.myinfo@gmail.com,
	openembedded-core@lists.openembedded.org

On Thu Feb 19, 2026 at 3:35 PM CET, Yoann Congal wrote:
> On Wed Feb 18, 2026 at 9:16 AM CET, Peter Marko wrote:
>> Could we add "adding/improving tests" to the allowed LTS backport items?
>> I think we're shooting ourselves in the foot here.
>
> FYI, I've asked the Yocto Project TSC about this.

Hello,

I'm sorry but we decided that standalone tests like this one are not
acceptable for stable inclusion.

For more detail, see "Clarification on ptest/selftest backports for stable branches"
https://lore.kernel.org/openembedded-core/DGVX4XQ6VLWT.1HOMXA78ZXLBG@smile.fr/T/#u

Regards,
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-03-06 18:52 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20  7:36 [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Shaik Moin
2026-01-20  7:36 ` [OE-core][scarthgap][PATCH 2/2] libpcre2: fix RunGrepTest Failure on Busybox systems Shaik Moin
2026-02-08 23:49   ` Yoann Congal
2026-02-08 23:30 ` [OE-core][scarthgap][PATCH 1/2] libpcre2: Enable Ptest Support Yoann Congal
  -- strict thread matches above, loose matches on Subject: below --
2026-02-11  7:23 Shaik Moin
2026-02-11  8:53 ` Yoann Congal
2026-02-18  5:30   ` Shaik Moin
2026-02-18  8:01     ` Yoann Congal
2026-02-18  8:16       ` Marko, Peter
2026-02-19 14:35         ` Yoann Congal
2026-02-20  6:29           ` Shaik Moin
2026-03-06 18:52           ` Yoann Congal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox