public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH] runqemu: parse QB_GRAPHICS for nographic flag
@ 2026-01-31 21:11 charles.embedded
  2026-02-02 15:58 ` [OE-core] " Alexander Kanavin
  0 siblings, 1 reply; 5+ messages in thread
From: charles.embedded @ 2026-01-31 21:11 UTC (permalink / raw)
  To: openembedded-core; +Cc: richard.purdie, Charles Dias

From: Charles Dias <charlesdias.cd@outlook.com>

The setup_vga() function was ignoring -nographic in QB_GRAPHICS
because it only checked the command-line self.nographic flag.
This caused QB_GRAPHICS to be appended after display autodetection,
resulting in conflicting options like "-device virtio-vga -display sdl"
and "-nographic" in the same command.

Add a check after reading qemuboot.conf to detect -nographic in
QB_GRAPHICS and set self.nographic accordingly. This prevents
unnecessary display autodetection for BSPs that specify -nographic
in their machine configuration, as happens in meta-zephyr layer.

Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
---
 scripts/runqemu | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index 32a3d6296a..b791abfda3 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -986,6 +986,12 @@ to your build configuration.
                 v = os.path.dirname(self.qemuboot)
             self.set(k_upper, v)
 
+        # Parse QB_GRAPHICS to set internal flags if not already set by command-line
+        if not self.nographic and self.get('QB_GRAPHICS'):
+            if '-nographic' in self.get('QB_GRAPHICS'):
+                logger.debug('Detected -nographic in QB_GRAPHICS, setting nographic mode')
+                self.nographic = True
+
     def validate_paths(self):
         """Ensure all relevant path variables are set"""
         # When we're started with a *.qemuboot.conf arg assume that image


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-02-03 11:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-31 21:11 [PATCH] runqemu: parse QB_GRAPHICS for nographic flag charles.embedded
2026-02-02 15:58 ` [OE-core] " Alexander Kanavin
2026-02-02 22:08   ` charles.embedded
2026-02-03  9:59     ` [OE-core] " Alexander Kanavin
2026-02-03 11:25       ` Charles Dias

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox