public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [OE-core][whinlatter][PATCH v1] libarchive: backport libarchive ptest to whinlatter
@ 2026-02-24 15:03 Pratik Farkase
  2026-03-06 18:46 ` Yoann Congal
  0 siblings, 1 reply; 2+ messages in thread
From: Pratik Farkase @ 2026-02-24 15:03 UTC (permalink / raw)
  To: openembedded-core; +Cc: pratik.farkase, Pratik Farkase

Backport ptest implementation from master branch to enable comprehensive
testing of libarchive functionality in the whinlatter release.

The implementation builds and installs five test suites:
libarchive_test, bsdtar_test, bsdcpio_test, bsdcat_test, and
bsdunzip_test, along with their test data files.

Test executables for bsdtar, bsdcpio, bsdcat, and bsdunzip are
provided via symlinks to the installed binaries.

All tests on qemux86-64 pass:
  libarchive_test: 689 tests
  bsdtar_test: 76 tests
  bsdcpio_test: 49 tests
  bsdcat_test: 18 tests
  bsdunzip_test: 8 tests

This backport ensures the whinlatter branch has the same comprehensive
test coverage as master, improving quality assurance and catching
regressions early.

Signed-off-by: Pratik Farkase <pratik.farkase@est.tech>
---
 .../distro/include/ptest-packagelists.inc     |  1 +
 .../libarchive/libarchive/run-ptest           | 10 ++++++
 .../libarchive/libarchive_3.8.5.bb            | 31 +++++++++++++++++--
 3 files changed, 40 insertions(+), 2 deletions(-)
 create mode 100755 meta/recipes-extended/libarchive/libarchive/run-ptest

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index 06d113e264..a70ad52f72 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -28,6 +28,7 @@ PTESTS_FAST = "\
     icu \
     json-c \
     json-glib \
+    libarchive \
     libconvert-asn1-perl \
     libexif \
     libgpg-error\
diff --git a/meta/recipes-extended/libarchive/libarchive/run-ptest b/meta/recipes-extended/libarchive/libarchive/run-ptest
new file mode 100755
index 0000000000..36d982917c
--- /dev/null
+++ b/meta/recipes-extended/libarchive/libarchive/run-ptest
@@ -0,0 +1,10 @@
+#!/bin/sh
+
+for t in libarchive_test bsdtar_test bsdcpio_test bsdcat_test bsdunzip_test; do
+    ./$t
+    if [ $? -eq 0 ]; then
+        echo "PASS: $t"
+    else
+        echo "FAIL: $t"
+    fi
+done
diff --git a/meta/recipes-extended/libarchive/libarchive_3.8.5.bb b/meta/recipes-extended/libarchive/libarchive_3.8.5.bb
index fcfaf5d231..b074617141 100644
--- a/meta/recipes-extended/libarchive/libarchive_3.8.5.bb
+++ b/meta/recipes-extended/libarchive/libarchive_3.8.5.bb
@@ -29,12 +29,15 @@ PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd,"
 
 EXTRA_OECONF += "--enable-largefile --without-iconv"
 
-SRC_URI = "https://libarchive.org/downloads/libarchive-${PV}.tar.gz"
+SRC_URI = "https://libarchive.org/downloads/libarchive-${PV}.tar.gz \
+           file://run-ptest \
+          "
+
 UPSTREAM_CHECK_URI = "https://www.libarchive.org/"
 
 SRC_URI[sha256sum] = "8a60f3a7bfd59c54ce82ae805a93dba65defd04148c3333b7eaa2102f03b7ffd"
 
-inherit autotools update-alternatives pkgconfig
+inherit autotools update-alternatives pkgconfig ptest
 
 CPPFLAGS += "-I${WORKDIR}/extra-includes"
 
@@ -62,3 +65,27 @@ ALTERNATIVE_LINK_NAME[cpio] = "${base_bindir}/cpio"
 ALTERNATIVE_TARGET[cpio] = "${bindir}/bsdcpio"
 
 BBCLASSEXTEND = "native nativesdk"
+
+do_compile_ptest() {
+    oe_runmake check TESTS=
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}
+
+    for test in libarchive_test bsdtar_test bsdcpio_test bsdcat_test bsdunzip_test; do
+            ${B}/libtool --mode=install install -m 0755 ${B}/$test ${D}${PTEST_PATH}/$test
+    done
+
+    for dir in libarchive tar cpio cat unzip; do
+            install -d ${D}${PTEST_PATH}/$dir/test
+            cp -r ${S}/$dir/test/* ${D}${PTEST_PATH}/$dir/test/
+    done
+
+    ln -sf ${bindir}/bsdtar ${D}${PTEST_PATH}/bsdtar
+    ln -sf ${bindir}/bsdcpio ${D}${PTEST_PATH}/bsdcpio
+    ln -sf ${bindir}/bsdcat ${D}${PTEST_PATH}/bsdcat
+    ln -sf ${bindir}/bsdunzip ${D}${PTEST_PATH}/bsdunzip
+}
+
+RDEPENDS:${PN}-ptest += "bsdtar bsdcpio"
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core][whinlatter][PATCH v1] libarchive: backport libarchive ptest to whinlatter
  2026-02-24 15:03 [OE-core][whinlatter][PATCH v1] libarchive: backport libarchive ptest to whinlatter Pratik Farkase
@ 2026-03-06 18:46 ` Yoann Congal
  0 siblings, 0 replies; 2+ messages in thread
From: Yoann Congal @ 2026-03-06 18:46 UTC (permalink / raw)
  To: pratik.farkase, openembedded-core; +Cc: pratik.farkase

On Tue Feb 24, 2026 at 4:03 PM CET, Pratik Farkase via lists.openembedded.org wrote:
> Backport ptest implementation from master branch to enable comprehensive
> testing of libarchive functionality in the whinlatter release.
>
> The implementation builds and installs five test suites:
> libarchive_test, bsdtar_test, bsdcpio_test, bsdcat_test, and
> bsdunzip_test, along with their test data files.
>
> Test executables for bsdtar, bsdcpio, bsdcat, and bsdunzip are
> provided via symlinks to the installed binaries.
>
> All tests on qemux86-64 pass:
>   libarchive_test: 689 tests
>   bsdtar_test: 76 tests
>   bsdcpio_test: 49 tests
>   bsdcat_test: 18 tests
>   bsdunzip_test: 8 tests
>
> This backport ensures the whinlatter branch has the same comprehensive
> test coverage as master, improving quality assurance and catching
> regressions early.
>
> Signed-off-by: Pratik Farkase <pratik.farkase@est.tech>

Hello,

I'm sorry but we decided that standalone tests like this one are not
acceptable for stable inclusion.

For more detail, see "Clarification on ptest/selftest backports for stable branches"
https://lore.kernel.org/openembedded-core/DGVX4XQ6VLWT.1HOMXA78ZXLBG@smile.fr/T/#u

Regards,
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-06 18:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 15:03 [OE-core][whinlatter][PATCH v1] libarchive: backport libarchive ptest to whinlatter Pratik Farkase
2026-03-06 18:46 ` Yoann Congal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox