From: Ryan Eatmon <reatmon@ti.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [OE-core][PATCH 1/2] uboot-config: Change indentation for KCONFIG_CONFIG_ROOTDIR check
Date: Fri, 13 Mar 2026 10:14:21 -0500 [thread overview]
Message-ID: <20260313151422.3719829-1-reatmon@ti.com> (raw)
The current check is in the inner loop of UBOOT_CONFIG, but the check is
attempting to only apply to the case when there is a single entry in
UBOOT_CONFIG. Shift the indention to be outside of the for loop and
only execute once.
Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
meta/classes-recipe/uboot-config.bbclass | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/meta/classes-recipe/uboot-config.bbclass b/meta/classes-recipe/uboot-config.bbclass
index f7848396c1..9e24db1f48 100644
--- a/meta/classes-recipe/uboot-config.bbclass
+++ b/meta/classes-recipe/uboot-config.bbclass
@@ -247,15 +247,15 @@ python () {
bb.debug(1, "Appending '%s' to UBOOT_CONFIG_FRAGMENTS." % fragments)
d.appendVar('UBOOT_CONFIG_FRAGMENTS', fragments + " ? ")
- # This recipe might be inherited e.g. by the kernel recipe via kernel-fitimage.bbclass
- # Ensure the uboot specific menuconfig settings do not leak into other recipes
- if 'u-boot' in recipename:
- if len(ubootconfig) == 1:
- builddir = "%s-%s" % (d.getVar("UBOOT_MACHINE").strip(), config)
- d.setVar('KCONFIG_CONFIG_ROOTDIR', os.path.join("${B}", builddir))
- else:
- # Disable menuconfig for multiple configs
- d.setVar('KCONFIG_CONFIG_ENABLE_MENUCONFIG', "false")
+ # This recipe might be inherited e.g. by the kernel recipe via kernel-fitimage.bbclass
+ # Ensure the uboot specific menuconfig settings do not leak into other recipes
+ if 'u-boot' in recipename:
+ if len(ubootconfig) == 1:
+ builddir = "%s-%s" % (d.getVar("UBOOT_MACHINE").strip(), config)
+ d.setVar('KCONFIG_CONFIG_ROOTDIR', os.path.join("${B}", builddir))
+ else:
+ # Disable menuconfig for multiple configs
+ d.setVar('KCONFIG_CONFIG_ENABLE_MENUCONFIG', "false")
}
uboot_config_get_indexed_value () {
--
2.43.0
next reply other threads:[~2026-03-13 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 15:14 Ryan Eatmon [this message]
2026-03-13 15:14 ` [OE-core][PATCH 2/2] selftest: uboot: Add sefltest for recent KCONFIG_CONFIG_ROOTDIR fix Ryan Eatmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313151422.3719829-1-reatmon@ti.com \
--to=reatmon@ti.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox