From: Michal Sieron <michalwsieron@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Michal Sieron <michalwsieron@gmail.com>
Subject: [PATCH v3 02/13] coreutils: Convert confusing append to override syntax
Date: Tue, 17 Mar 2026 21:29:01 +0100 [thread overview]
Message-ID: <20260317-fix-invalid-appends-v3-2-59452f073f31@gmail.com> (raw)
In-Reply-To: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com>
:class-target overrides for PACKAGE_BEFORE_PN and RDEPENDS:coreutils
were being appended to with the coreutils-stdbuf, but instead of being
an append only for target builds, it was actually overriding those
variables.
One could replace `:class-target +=` with `:append:class-target =`, but
I don't think there is actually any need for this to be :class-target
specific. RPROVIDES:coreutils few lines below doesn't use that override.
Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
---
meta/recipes-core/coreutils/coreutils_9.10.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_9.10.bb b/meta/recipes-core/coreutils/coreutils_9.10.bb
index 984c5b5292..fb254d047d 100644
--- a/meta/recipes-core/coreutils/coreutils_9.10.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.10.bb
@@ -66,9 +66,9 @@ sbindir_progs = "chroot"
# coreutils-stdbuf without getting the rest of coreutils, but make
# coreutils itself pull in stdbuf, so IMAGE_INSTALL += "coreutils"
# always provides all coreutils
-PACKAGE_BEFORE_PN:class-target += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
+PACKAGE_BEFORE_PN += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
FILES:coreutils-stdbuf = "${bindir}/stdbuf ${libdir}/coreutils/libstdbuf.so"
-RDEPENDS:coreutils:class-target += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
+RDEPENDS:coreutils += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils-stdbuf', d)}"
# However, when the single-binary PACKAGECONFIG is used, stdbuf
# functionality is built into the single coreutils binary, so there's
--
2.53.0
next prev parent reply other threads:[~2026-03-17 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:28 [PATCH v3 00/13] Confusing and invalid conditional appends Michal Sieron
2026-03-17 20:29 ` [PATCH v3 01/13] libffi: Convert confusing append to assignment Michal Sieron
2026-03-17 20:29 ` Michal Sieron [this message]
2026-03-17 20:29 ` [PATCH v3 03/13] expat: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 04/13] tune-power[567]: Remove confusing overrides Michal Sieron
2026-03-17 20:29 ` [PATCH v3 05/13] no-gplv3.inc: Convert confusing appends to override syntax Michal Sieron
2026-03-17 20:29 ` [PATCH v3 06/13] bootchart2: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 07/13] pigz: Convert confusing append " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 08/13] systemtap: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 09/13] ovmf: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 10/13] dnf: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 11/13] qemu: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 12/13] recipes-devtools/python: Convert confusing appends " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 13/13] musl-locales: Fix locale-base-sr-sr typo Michal Sieron
2026-03-17 20:33 ` [OE-core] [PATCH v3 00/13] Confusing and invalid conditional appends Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317-fix-invalid-appends-v3-2-59452f073f31@gmail.com \
--to=michalwsieron@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox