From: Michal Sieron <michalwsieron@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Michal Sieron <michalwsieron@gmail.com>
Subject: [PATCH v3 06/13] bootchart2: Convert confusing appends to override syntax
Date: Tue, 17 Mar 2026 21:29:05 +0100 [thread overview]
Message-ID: <20260317-fix-invalid-appends-v3-6-59452f073f31@gmail.com> (raw)
In-Reply-To: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com>
While in this case `RDEPENDS:${PN}:class-target +=` wouldn't result in
any unwanted override, there is no guarantee there won't be a change,
which would be hidden by this override. To avoid any surprises in the
future let's use `:append:class-target =` syntax here.
Also moving BBCLASSEXTEND to the bottom to conform to the style guide.
Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
---
meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
index 922e665028..013a86bf78 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
@@ -106,9 +106,6 @@ ALTERNATIVE:${PN} = "bootchartd"
ALTERNATIVE_LINK_NAME[bootchartd] = "${base_sbindir}/bootchartd"
ALTERNATIVE_PRIORITY = "100"
-# The only reason to build bootchart2-native is for a native pybootchartgui.
-BBCLASSEXTEND = "native"
-
SYSTEMD_SERVICE:${PN} = "bootchart2.service bootchart2-done.service bootchart2-done.timer"
UPDATERCPN = "bootchartd-stop-initscript"
@@ -150,8 +147,8 @@ do_install () {
PACKAGES =+ "pybootchartgui"
FILES:pybootchartgui += "${PYTHON_SITEPACKAGES_DIR}/pybootchartgui ${bindir}/pybootchartgui"
RDEPENDS:pybootchartgui = "python3-pycairo python3-compression python3-image python3-math python3-shell python3-compression python3-codecs"
-RDEPENDS:${PN}:class-target += "${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', 'sysvinit-pidof', 'procps', d)}"
-RDEPENDS:${PN}:class-target += "lsb-release"
+RDEPENDS:${PN}:append:class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', 'sysvinit-pidof', 'procps', d)}"
+RDEPENDS:${PN}:append:class-target = " lsb-release"
DEPENDS:append:class-native = " python3-pycairo-native"
PACKAGES =+ "bootchartd-stop-initscript"
@@ -164,3 +161,6 @@ FILES:${PN} += "${libdir}"
FILES:${PN}-doc += "${datadir}/docs"
RCONFLICTS:${PN} = "bootchart"
+
+# The only reason to build bootchart2-native is for a native pybootchartgui.
+BBCLASSEXTEND = "native"
--
2.53.0
next prev parent reply other threads:[~2026-03-17 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:28 [PATCH v3 00/13] Confusing and invalid conditional appends Michal Sieron
2026-03-17 20:29 ` [PATCH v3 01/13] libffi: Convert confusing append to assignment Michal Sieron
2026-03-17 20:29 ` [PATCH v3 02/13] coreutils: Convert confusing append to override syntax Michal Sieron
2026-03-17 20:29 ` [PATCH v3 03/13] expat: Convert confusing append to assignment Michal Sieron
2026-03-17 20:29 ` [PATCH v3 04/13] tune-power[567]: Remove confusing overrides Michal Sieron
2026-03-17 20:29 ` [PATCH v3 05/13] no-gplv3.inc: Convert confusing appends to override syntax Michal Sieron
2026-03-17 20:29 ` Michal Sieron [this message]
2026-03-17 20:29 ` [PATCH v3 07/13] pigz: Convert confusing append " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 08/13] systemtap: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 09/13] ovmf: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 10/13] dnf: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 11/13] qemu: " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 12/13] recipes-devtools/python: Convert confusing appends " Michal Sieron
2026-03-17 20:29 ` [PATCH v3 13/13] musl-locales: Fix locale-base-sr-sr typo Michal Sieron
2026-03-17 20:33 ` [OE-core] [PATCH v3 00/13] Confusing and invalid conditional appends Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317-fix-invalid-appends-v3-6-59452f073f31@gmail.com \
--to=michalwsieron@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox