[PATCH v2 0/3] useradd.bbclass: fix parse error when only USERADD_DEPENDS is set

[PATCH v2 0/3] useradd.bbclass: fix parse error when only USERADD_DEPENDS is set

[Zk47T]

When a recipe inherits useradd and only sets USERADD_DEPENDS (to depend
on users/groups created by another recipe) without creating any
users/groups itself, the parse-time sanity check in
update_useradd_after_parse() unconditionally throws a fatal error about
missing USERADD_PACKAGES.

This series fixes the issue by skipping the USERADD_PACKAGES validation
when USERADD_DEPENDS is set, adds a selftest recipe to exercise this
code path, and adds an oe-selftest case to verify the build succeeds.

Changes in v2:
- Added oe-selftest test case in usergrouptests.py (patch 3/3)
  as suggested by Ross Burton

Fixes [YOCTO #15863]

Nguyen Minh Tien (3):
  useradd.bbclass: allow inheriting with only USERADD_DEPENDS set
  meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS
    only
  oe-selftest: add test for useradd with only USERADD_DEPENDS

 .../selftest-users/usegroup-deponly.bb        | 25 +++++++++++++++++++
 meta/classes/useradd.bbclass                  |  5 ++++
 .../lib/oeqa/selftest/cases/usergrouptests.py |  6 +++++
 3 files changed, 36 insertions(+)
 create mode 100644 meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb

-- 
2.34.1

[PATCH v2 1/3] useradd.bbclass: allow inheriting with only USERADD_DEPENDS set

[Zk47T]

When a recipe inherits useradd and only sets USERADD_DEPENDS (to depend
on users/groups created by another recipe), without creating any
users/groups itself, the parse-time sanity check incorrectly throws a
fatal error about missing USERADD_PACKAGES.

Skip the USERADD_PACKAGES/USERADD_PARAM validation when USERADD_DEPENDS
is set but USERADD_PACKAGES is not, since the recipe only needs build
dependency tracking, not user/group creation.

Fixes [YOCTO #15863]

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/classes/useradd.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 16a65ac323..9d857a4555 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -212,6 +212,11 @@ def update_useradd_after_parse(d):
     useradd_packages = d.getVar('USERADD_PACKAGES')
 
     if not useradd_packages:
+        # It's valid to inherit useradd and only set USERADD_DEPENDS to
+        # depend on users/groups created by another recipe, without
+        # creating any users/groups in this recipe.
+        if d.getVar('USERADD_DEPENDS'):
+            return
         bb.fatal("%s inherits useradd but doesn't set USERADD_PACKAGES" % d.getVar('FILE', False))
 
     for pkg in useradd_packages.split():
-- 
2.34.1

[PATCH v2 2/3] meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS only

[Zk47T]

Add a test recipe that inherits useradd and only sets USERADD_DEPENDS
without USERADD_PACKAGES to validate the fix for [YOCTO #15863].

The root bug is that useradd.bbclass unconditionally requires
USERADD_PACKAGES to be set, even when a recipe only needs to depend on
users/groups created by another recipe via USERADD_DEPENDS. This recipe
depends on creategroup1 for user gt1 and group grouptest, but does not
create any users/groups itself, exercising the code path fixed in the
previous commit.

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 .../selftest-users/usegroup-deponly.bb        | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb

diff --git a/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb b/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb
new file mode 100644
index 0000000000..e5db7a47ea
--- /dev/null
+++ b/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb
@@ -0,0 +1,25 @@
+SUMMARY = "Test recipe that only uses USERADD_DEPENDS without USERADD_PARAM"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+
+LICENSE = "MIT"
+
+# This recipe depends on the user/group created by creategroup1
+# but does NOT create users or groups itself.
+USERADD_DEPENDS = "creategroup1"
+
+S = "${WORKDIR}/sources"
+UNPACKDIR = "${S}"
+
+EXCLUDE_FROM_WORLD = "1"
+
+inherit useradd allarch
+
+TESTDIR = "${D}${sysconfdir}/deponly"
+
+do_install() {
+	install -d   ${TESTDIR}
+	touch        ${TESTDIR}/file
+	chown gt1:grouptest ${TESTDIR}/file
+}
+
+FILES:${PN} = "${sysconfdir}/deponly/*"
-- 
2.34.1

[PATCH v2 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS

[Zk47T]

Add a test case to verify that a recipe inheriting useradd with only
USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
successfully. This validates the fix in useradd.bbclass for
[YOCTO #15863].

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py b/meta/lib/oeqa/selftest/cases/usergrouptests.py
index 3c59b0f290..69025a59aa 100644
--- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
+++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
@@ -55,3 +55,9 @@ class UserGroupTests(OESelftestTestCase):
         self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
         self.logger.info("Rebuild with other staticids")
         self.assertTrue(bitbake(' core-image-minimal'))
+
+    def test_useradd_depends_only(self):
+        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
+        # (and no USERADD_PACKAGES) parses and builds successfully. [YOCTO #15863]
+        self.logger.info("Building usegroup-deponly to test USERADD_DEPENDS only")
+        self.assertTrue(bitbake(' usegroup-deponly'))
-- 
2.34.1

Re: [OE-core] [PATCH v2 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS

[Mathieu Dubois-Briand]

On Mon Apr 20, 2026 at 6:39 PM CEST, Zk47T via lists.openembedded.org wrote:
> Add a test case to verify that a recipe inheriting useradd with only
> USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
> successfully. This validates the fix in useradd.bbclass for
> [YOCTO #15863].
>
> Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
> ---
>  meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> index 3c59b0f290..69025a59aa 100644
> --- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
> +++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> @@ -55,3 +55,9 @@ class UserGroupTests(OESelftestTestCase):
>          self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
>          self.logger.info("Rebuild with other staticids")
>          self.assertTrue(bitbake(' core-image-minimal'))
> +
> +    def test_useradd_depends_only(self):
> +        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
> +        # (and no USERADD_PACKAGES) parses and builds successfully. [YOCTO #15863]
> +        self.logger.info("Building usegroup-deponly to test USERADD_DEPENDS only")
> +        self.assertTrue(bitbake(' usegroup-deponly'))


Hi,

Thanks for adding tests.

Yet, it looks like this test is always failing. I had the issue both on
the autobuilder and locally:

2026-04-22 13:30:16,318 - oe-selftest - INFO - usergrouptests.UserGroupTests.test_useradd_depends_only (subunit.RemotedTestCase)
2026-04-22 13:30:16,332 - oe-selftest - INFO -  ... FAIL
...
ERROR: usegroup-deponly-1.0-r0 do_unpack: S should be set relative to UNPACKDIR, e.g. replace WORKDIR with UNPACKDIR in "S = ${WORKDIR}/sources"
ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-409425/tmp/work/all-poky-linux/usegroup-deponly/1.0/temp/log.do_unpack.2060861
NOTE: recipe usegroup-deponly-1.0-r0: task do_unpack: Failed
ERROR: Task (/srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-409425/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb:do_unpack) failed with exit code '1'

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/3719
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/3606

So I believe the issue does not code from the test, but from the recipe
itself.

Can you have a look at the issue?

Thanks,
Mathieu


-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH v3 0/3] useradd.bbclass: fix parse error when only USERADD_DEPENDS is set

[Zk47T]

When a recipe inherits useradd and only sets USERADD_DEPENDS (to depend
on users/groups created by another recipe) without creating any
users/groups itself, the parse-time sanity check in
update_useradd_after_parse() unconditionally throws a fatal error about
missing USERADD_PACKAGES.

This series fixes the issue by skipping the USERADD_PACKAGES validation
when USERADD_DEPENDS is set, adds a selftest recipe to exercise this
code path, and adds an oe-selftest case to verify the build succeeds.

Changes in v3:
- Fix usegroup-deponly.bb: remove unnecessary S and UNPACKDIR variables
  that caused do_unpack to fail on the autobuilder (reported by
  Mathieu Dubois-Briand)

Changes in v2:
- Added oe-selftest test case in usergrouptests.py (patch 3/3)
  as suggested by Ross Burton

Fixes [YOCTO #15863]

Nguyen Minh Tien (3):
  useradd.bbclass: allow inheriting with only USERADD_DEPENDS set
  meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS
    only
  oe-selftest: add test for useradd with only USERADD_DEPENDS

 .../selftest-users/usegroup-deponly.bb        | 22 +++++++++++++++++++
 meta/classes/useradd.bbclass                  |  5 +++++
 .../lib/oeqa/selftest/cases/usergrouptests.py |  6 +++++
 3 files changed, 33 insertions(+)
 create mode 100644 meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb

-- 
2.34.1

[PATCH v3 1/3] useradd.bbclass: allow inheriting with only USERADD_DEPENDS set

[Zk47T]

When a recipe inherits useradd and only sets USERADD_DEPENDS (to depend
on users/groups created by another recipe), without creating any
users/groups itself, the parse-time sanity check incorrectly throws a
fatal error about missing USERADD_PACKAGES.

Skip the USERADD_PACKAGES/USERADD_PARAM validation when USERADD_DEPENDS
is set but USERADD_PACKAGES is not, since the recipe only needs build
dependency tracking, not user/group creation.

Fixes [YOCTO #15863]

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/classes/useradd.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 16a65ac323..9d857a4555 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -212,6 +212,11 @@ def update_useradd_after_parse(d):
     useradd_packages = d.getVar('USERADD_PACKAGES')
 
     if not useradd_packages:
+        # It's valid to inherit useradd and only set USERADD_DEPENDS to
+        # depend on users/groups created by another recipe, without
+        # creating any users/groups in this recipe.
+        if d.getVar('USERADD_DEPENDS'):
+            return
         bb.fatal("%s inherits useradd but doesn't set USERADD_PACKAGES" % d.getVar('FILE', False))
 
     for pkg in useradd_packages.split():
-- 
2.34.1

[PATCH v3 2/3] meta-selftest: add usegroup-deponly recipe to test USERADD_DEPENDS only

[Zk47T]

Add a test recipe that inherits useradd and only sets USERADD_DEPENDS
without USERADD_PACKAGES to validate the fix for [YOCTO #15863].

The root bug is that useradd.bbclass unconditionally requires
USERADD_PACKAGES to be set, even when a recipe only needs to depend on
users/groups created by another recipe via USERADD_DEPENDS. This recipe
depends on creategroup1 for user gt1 and group grouptest, but does not
create any users/groups itself, exercising the code path fixed in the
previous commit.

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 .../selftest-users/usegroup-deponly.bb        | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb

diff --git a/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb b/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb
new file mode 100644
index 0000000000..22288abb61
--- /dev/null
+++ b/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb
@@ -0,0 +1,22 @@
+SUMMARY = "Test recipe that only uses USERADD_DEPENDS without USERADD_PARAM"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+
+LICENSE = "MIT"
+
+# This recipe depends on the user/group created by creategroup1
+# but does NOT create users or groups itself.
+USERADD_DEPENDS = "creategroup1"
+
+EXCLUDE_FROM_WORLD = "1"
+
+inherit useradd allarch
+
+TESTDIR = "${D}${sysconfdir}/deponly"
+
+do_install() {
+	install -d   ${TESTDIR}
+	touch        ${TESTDIR}/file
+	chown gt1:grouptest ${TESTDIR}/file
+}
+
+FILES:${PN} = "${sysconfdir}/deponly/*"
-- 
2.34.1

[PATCH v3 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS

[Zk47T]

Add a test case to verify that a recipe inheriting useradd with only
USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
successfully. This validates the fix in useradd.bbclass for
[YOCTO #15863].

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py b/meta/lib/oeqa/selftest/cases/usergrouptests.py
index 3c59b0f290..69025a59aa 100644
--- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
+++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
@@ -55,3 +55,9 @@ class UserGroupTests(OESelftestTestCase):
         self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
         self.logger.info("Rebuild with other staticids")
         self.assertTrue(bitbake(' core-image-minimal'))
+
+    def test_useradd_depends_only(self):
+        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
+        # (and no USERADD_PACKAGES) parses and builds successfully. [YOCTO #15863]
+        self.logger.info("Building usegroup-deponly to test USERADD_DEPENDS only")
+        self.assertTrue(bitbake(' usegroup-deponly'))
-- 
2.34.1

Re: [PATCH v3 3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS

[Zk47T]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Hi,
i remove these 2 lines in poky/meta-selftest/recipes-test/selftest-users/
usegroup-deponly.bb
- S = "${WORKDIR}/sources"
- UNPACKDIR = "${S}"

My poky base on walnascar-next, it seem that the autobuilder base on newer
branch that more strict in S and UNPACKDIR variables that caused do_unpack
failed
I have just updated new patch v3 for this . Please help review it

Thank,
Nguyen Minh Tien


Vào Thứ 5, 23 thg 4, 2026 vào lúc 17:04 Nguyen Minh Tien <
zizuzacker@gmail.com> đã viết:

> Add a test case to verify that a recipe inheriting useradd with only
> USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
> successfully. This validates the fix in useradd.bbclass for
> [YOCTO #15863].
>
> Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
> ---
>  meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py
> b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> index 3c59b0f290..69025a59aa 100644
> --- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
> +++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> @@ -55,3 +55,9 @@ class UserGroupTests(OESelftestTestCase):
>          self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
>          self.logger.info("Rebuild with other staticids")
>          self.assertTrue(bitbake(' core-image-minimal'))
> +
> +    def test_useradd_depends_only(self):
> +        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
> +        # (and no USERADD_PACKAGES) parses and builds successfully.
> [YOCTO #15863]
> +        self.logger.info("Building usegroup-deponly to test
> USERADD_DEPENDS only")
> +        self.assertTrue(bitbake(' usegroup-deponly'))
> --
> 2.34.1
>
>

[-- Attachment #2: Type: text/html, Size: 2622 bytes --]