* [meta][PATCH v3 2/3] oeqa/selftest: Add go-vendor.bbclass selftest suite
2026-07-17 21:32 [PATCH v3 0/3] Create selftest suite for go-vendor.bbclass John Ripple
2026-07-17 21:32 ` [meta][PATCH v3 1/3] go-vendor.bbclass: Fix test file exclusion and license propagation John Ripple
@ 2026-07-17 21:32 ` John Ripple
2026-07-21 8:59 ` [OE-core] " Mathieu Dubois-Briand
2026-07-17 21:32 ` [meta][PATCH v3 3/3] go-vendor.bbclass: Run vendor_unlink task under fakeroot John Ripple
2 siblings, 1 reply; 6+ messages in thread
From: John Ripple @ 2026-07-17 21:32 UTC (permalink / raw)
To: openembedded-core; +Cc: John Ripple
Add govendor.py with two test classes that cover the behaviors fixed and
defined in go-vendor.bbclass:
GoVendorSrcUriTests (offline, ~10 s): unit tests for go_src_uri() parsed
via bb.tinfoil; verifies the basic URI shape, path/pathmajor/subdir/replaces
encoding, and that non-git VCS omits the git-specific nobranch/protocol flags.
GoVendorTaskTests: runs do_go_vendor once against the real recipetool-go-test
project and checks that external deps land in vendor/, *_test.go files are
excluded, pathmajor=/v5 falls back to the repo root when no v5/ subdir exists,
modules.txt is reproduced in vendor/, a local replacement (./is) appears as
a symlink, and the S/src/GO_IMPORT/vendor -> S/src/import/vendor symlink is
created.
Exclude the govendor test recipes from world builds since they are only meant
to be built directly by the govendor test suite.
Signed-off-by: John Ripple <john.ripple@keysight.com>
---
.../recipes-test/govendor/files/modules.txt | 7 +
.../govendor/go-vendor-src-uri_1.0.bb | 17 ++
.../govendor/govendor-real-test_1.0.bb | 29 +++
meta/lib/oeqa/selftest/cases/govendor.py | 179 ++++++++++++++++++
4 files changed, 232 insertions(+)
create mode 100644 meta-selftest/recipes-test/govendor/files/modules.txt
create mode 100644 meta-selftest/recipes-test/govendor/go-vendor-src-uri_1.0.bb
create mode 100644 meta-selftest/recipes-test/govendor/govendor-real-test_1.0.bb
create mode 100644 meta/lib/oeqa/selftest/cases/govendor.py
diff --git a/meta-selftest/recipes-test/govendor/files/modules.txt b/meta-selftest/recipes-test/govendor/files/modules.txt
new file mode 100644
index 0000000000..f64f5245b5
--- /dev/null
+++ b/meta-selftest/recipes-test/govendor/files/modules.txt
@@ -0,0 +1,7 @@
+# github.com/godbus/dbus/v5 v5.1.0
+## explicit; go 1.12
+github.com/godbus/dbus/v5
+# github.com/matryer/is v1.4.1 => ./is
+## explicit; go 1.14
+github.com/matryer/is
+# github.com/matryer/is => ./is
\ No newline at end of file
diff --git a/meta-selftest/recipes-test/govendor/go-vendor-src-uri_1.0.bb b/meta-selftest/recipes-test/govendor/go-vendor-src-uri_1.0.bb
new file mode 100644
index 0000000000..b24b992bb1
--- /dev/null
+++ b/meta-selftest/recipes-test/govendor/go-vendor-src-uri_1.0.bb
@@ -0,0 +1,17 @@
+SUMMARY = "Selftest fixture: go_src_uri parameter variants"
+LICENSE = "CLOSED"
+
+# Parsed via tinfoil for its GO_SRC_URI_* variables only; never actually built
+# (it has no real SRC_URI, so do_go_vendor would fail).
+EXCLUDE_FROM_WORLD = "1"
+
+inherit go-vendor
+
+GO_IMPORT = "example.com/testpkg"
+
+GO_SRC_URI_BASIC = "${@go_src_uri('github.com/foo/bar', 'v1.0.0')}"
+GO_SRC_URI_PATH = "${@go_src_uri('github.com/foo/bar', 'v2.1.0', path='github.com/foo/bar/v2')}"
+GO_SRC_URI_PATHMAJOR = "${@go_src_uri('github.com/foo/bar', 'v2.0.0', pathmajor='/v2')}"
+GO_SRC_URI_SUBDIR = "${@go_src_uri('github.com/foo/bar', 'v1.0.0', subdir='sub/pkg')}"
+GO_SRC_URI_REPLACES = "${@go_src_uri('github.com/baz/qux', 'v1.0.0', replaces='../local/baz')}"
+GO_SRC_URI_SVN = "${@go_src_uri('example.com/svnmod', 'r42', vcs='svn')}"
diff --git a/meta-selftest/recipes-test/govendor/govendor-real-test_1.0.bb b/meta-selftest/recipes-test/govendor/govendor-real-test_1.0.bb
new file mode 100644
index 0000000000..8086922e10
--- /dev/null
+++ b/meta-selftest/recipes-test/govendor/govendor-real-test_1.0.bb
@@ -0,0 +1,29 @@
+SUMMARY = "go-vendor integration test: recipetool-go-test"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=4e3933dd47afbf115e484d11385fb3bd"
+
+# Only meant to be built directly by GoVendorTaskTests (bitbake('%s -c go_vendor')),
+# not as part of a general world build.
+EXCLUDE_FROM_WORLD = "1"
+
+# Native variant lets GoVendorTaskTests.test_do_compile_succeeds exercise the
+# real go toolchain without requiring a full target Go cross-toolchain.
+BBCLASSEXTEND = "native"
+
+inherit go-vendor
+
+GO_IMPORT = "git.yoctoproject.org/recipetool-go-test"
+
+# modules.txt for recipetool-go-test at SRCREV:
+# - github.com/godbus/dbus/v5 v5.1.0 (external, fetched via go_src_uri)
+# - github.com/matryer/is v1.4.1 (local replacement => ./is)
+# Use go mod vendor to generate the modules.txt
+SRC_URI = "\
+ git://${GO_IMPORT};name=recipetool-go-test;branch=main;protocol=https;nobranch=1;destsuffix=${GO_SRCURI_DESTSUFFIX} \
+ ${@go_src_uri('github.com/godbus/dbus', 'v5.1.0', path='github.com/godbus/dbus/v5', pathmajor='/v5')} \
+ file://modules.txt \
+ "
+SRCREV_FORMAT = "recipetool-go-test"
+# git.yoctoproject.org/recipetool-go-test main branch HEAD
+SRCREV_recipetool-go-test = "c3e213c01b6c1406b430df03ef0d1ae77de5d2f7"
+SRCREV_github.com.godbus.dbus.v5 = "e523abc905595cf17fb0001a7d77eaaddfaa216d"
diff --git a/meta/lib/oeqa/selftest/cases/govendor.py b/meta/lib/oeqa/selftest/cases/govendor.py
new file mode 100644
index 0000000000..8be2712060
--- /dev/null
+++ b/meta/lib/oeqa/selftest/cases/govendor.py
@@ -0,0 +1,179 @@
+#
+# Copyright OpenEmbedded Contributors
+#
+# SPDX-License-Identifier: MIT
+#
+# Comprehensive tests for go-vendor.bbclass:
+# GoVendorSrcUriTests -- unit tests for the go_src_uri() helper (offline, ~10 s)
+# GoVendorTaskTests -- integration tests using the real recipetool-go-test project
+# (network fetch of git.yoctoproject.org + github.com/godbus/dbus)
+
+import os
+
+from oeqa.selftest.case import OESelftestTestCase
+from oeqa.utils.commands import bitbake, get_bb_var
+
+# ---------------------------------------------------------------------------
+# Class 1: go_src_uri() helper function
+# ---------------------------------------------------------------------------
+
+class GoVendorSrcUriTests(OESelftestTestCase):
+ """Tests for the go_src_uri() Python helper in go-vendor.bbclass.
+
+ Parses the go-vendor-src-uri fixture recipe (meta-selftest/recipes-test/
+ govendor/go-vendor-src-uri_1.0.bb) via bb.tinfoil (config_only=True) once
+ per class so the function runs inside the real BitBake class-loading
+ machinery. All tests are offline and complete in ~10 s total.
+ """
+
+ @classmethod
+ def setUpClass(cls):
+ import bb.tinfoil
+ super().setUpClass()
+
+ recipe_path = os.path.join(cls.testlayer_path, 'recipes-test',
+ 'govendor', 'go-vendor-src-uri_1.0.bb')
+
+ with bb.tinfoil.Tinfoil() as tinfoil:
+ tinfoil.prepare(config_only=True, quiet=2)
+ rd = tinfoil.parse_recipe_file(recipe_path)
+ cls.bp = rd.getVar('BP')
+ cls.uris = {k: rd.getVar('GO_SRC_URI_' + k)
+ for k in ('BASIC', 'PATH', 'PATHMAJOR', 'SUBDIR',
+ 'REPLACES', 'SVN')}
+
+ # --- individual test methods -------------------------------------------
+
+ def test_basic(self):
+ """destsuffix uses expanded BP"""
+ uri = self.uris['BASIC']
+ expected_ds = 'destsuffix=%s/src/import/vendor.fetch/github.com/foo/bar@v1.0.0' % self.bp
+ self.assertIn(expected_ds, uri)
+ self.assertIn('go_module_path=github.com/foo/bar', uri)
+ self.assertIn('nobranch=1', uri)
+ self.assertIn('protocol=https', uri)
+ self.assertIn('is_go_dependency=1', uri)
+
+ def test_path_override(self):
+ """Explicit path= sets go_module_path independently of the repo URL."""
+ uri = self.uris['PATH']
+ self.assertIn('go_module_path=github.com/foo/bar/v2', uri)
+ expected_ds = 'destsuffix=%s/src/import/vendor.fetch/github.com/foo/bar@v2.1.0' % self.bp
+ self.assertIn(expected_ds, uri)
+
+ def test_pathmajor(self):
+ """pathmajor is encoded as go_pathmajor in the URI."""
+ self.assertIn('go_pathmajor=/v2', self.uris['PATHMAJOR'])
+
+ def test_subdir(self):
+ """subdir is encoded as go_subdir in the URI."""
+ self.assertIn('go_subdir=sub/pkg', self.uris['SUBDIR'])
+
+ def test_replaces(self):
+ """replaces is encoded as go_module_replacement in the URI."""
+ self.assertIn('go_module_replacement=../local/baz', self.uris['REPLACES'])
+
+ def test_non_git_vcs(self):
+ """Non-git VCS omits the git-specific nobranch and protocol=https flags."""
+ uri = self.uris['SVN']
+ self.assertIn('svn://example.com/svnmod', uri)
+ self.assertNotIn('nobranch', uri)
+ self.assertNotIn('protocol=https', uri)
+ self.assertIn('is_go_dependency=1', uri)
+
+
+# ---------------------------------------------------------------------------
+# Class 2: do_go_vendor task integration — real project
+# ---------------------------------------------------------------------------
+
+class GoVendorTaskTests(OESelftestTestCase):
+ """Integration tests for do_go_vendor using the real recipetool-go-test project.
+
+ The govendor-real-test recipe (meta-selftest/recipes-test/govendor/
+ govendor-real-test_1.0.bb) fetches git.yoctoproject.org/recipetool-go-test
+ (commit c3e213c) as its main source and github.com/godbus/dbus/v5 v5.1.0
+ as an external vendor dependency. The project also has a local module
+ replacement (github.com/matryer/is => ./is) that lives inside the main
+ source tree.
+
+ do_go_vendor runs ONCE in setUpClass; individual test methods inspect the
+ resulting vendor directory without re-running bitbake.
+
+ Verified behaviors:
+ - External dependency files are copied to vendor/
+ - *_test.go files are excluded from the vendor copy
+ - pathmajor fallback: when the /v5 subdir is absent, repo root is used
+ - modules.txt is reproduced inside vendor/
+ - Local module replacement creates a relative symlink in vendor/
+ - S/src/GO_IMPORT/vendor symlink is created pointing at S/src/import/vendor
+ """
+
+ GO_IMPORT = 'git.yoctoproject.org/recipetool-go-test'
+ RECIPE_NAME = 'govendor-real-test'
+
+ @classmethod
+ def setUpClass(cls):
+ super().setUpClass()
+
+ bitbake('%s -c go_vendor' % cls.RECIPE_NAME)
+ cls.s_dir = get_bb_var('S', cls.RECIPE_NAME)
+ cls.vendor_dir = os.path.join(cls.s_dir, 'src', 'import', 'vendor')
+
+ # --- test methods (all inspect cls.vendor_dir, no bitbake) ---------------
+
+ def test_external_dep_copied_to_vendor(self):
+ """godbus/dbus/v5 source files are copied into vendor/."""
+ dbus_dir = os.path.join(self.vendor_dir, 'github.com', 'godbus', 'dbus', 'v5')
+ self.assertTrue(os.path.isdir(dbus_dir),
+ 'vendor/github.com/godbus/dbus/v5/ not created')
+ self.assertTrue(os.path.isfile(os.path.join(dbus_dir, 'conn.go')),
+ 'conn.go not found in vendor/github.com/godbus/dbus/v5/')
+
+ def test_test_files_excluded_from_vendor(self):
+ """*_test.go files from godbus/dbus are not copied into vendor/."""
+ dbus_dir = os.path.join(self.vendor_dir, 'github.com', 'godbus', 'dbus', 'v5')
+ self.assertFalse(
+ os.path.isfile(os.path.join(dbus_dir, 'conn_test.go')),
+ 'conn_test.go should have been excluded from vendor by *_test.go pattern')
+
+ def test_pathmajor_falls_back_to_root(self):
+ """godbus/dbus v5.1.0 has no v5/ subdir; pathmajor=/v5 falls back to root."""
+ dbus_dir = os.path.join(self.vendor_dir, 'github.com', 'godbus', 'dbus', 'v5')
+ # auth.go is at the repo root of godbus/dbus, not inside a v5/ subdir.
+ self.assertTrue(os.path.isfile(os.path.join(dbus_dir, 'auth.go')),
+ 'auth.go not found; pathmajor=/v5 fallback to repo root did not work')
+
+ def test_modules_txt_in_vendor(self):
+ """modules.txt is reproduced inside vendor/ and lists the external dep."""
+ modules_txt = os.path.join(self.vendor_dir, 'modules.txt')
+ self.assertTrue(os.path.isfile(modules_txt))
+ with open(modules_txt) as fh:
+ content = fh.read()
+ self.assertIn('github.com/godbus/dbus/v5 v5.1.0', content)
+
+ def test_local_replacement_symlink(self):
+ """go.mod local replacement (./is) creates a symlink in vendor/ to S/src/GO_IMPORT/is."""
+ symlink = os.path.join(self.vendor_dir, 'github.com', 'matryer', 'is')
+ self.assertTrue(os.path.islink(symlink),
+ 'vendor/github.com/matryer/is should be a symlink for the ./is local replacement')
+ expected_target = os.path.join(self.s_dir, 'src', self.GO_IMPORT, 'is')
+ self.assertEqual(os.path.realpath(symlink), os.path.realpath(expected_target),
+ 'Local replacement symlink does not point to S/src/GO_IMPORT/is')
+
+ def test_go_import_vendor_symlink(self):
+ """do_go_vendor creates S/src/GO_IMPORT/vendor -> S/src/import/vendor."""
+ link = os.path.join(self.s_dir, 'src', self.GO_IMPORT, 'vendor')
+ self.assertTrue(os.path.islink(link),
+ 'S/src/GO_IMPORT/vendor symlink not created')
+ self.assertEqual(os.path.realpath(link), os.path.realpath(self.vendor_dir),
+ 'S/src/GO_IMPORT/vendor does not point to S/src/import/vendor')
+
+ def test_do_compile_succeeds(self):
+ """The vendored tree is valid Go: the toolchain can actually build it.
+
+ Runs against the -native variant so this only depends on go-native,
+ not a full target Go cross-toolchain. The SRC_URI fetch is already
+ cached in DL_DIR from setUpClass, so this mainly re-runs
+ unpack/go_vendor/compile for the native variant.
+ """
+ bitbake('%s-native -c compile' % self.RECIPE_NAME)
^ permalink raw reply related [flat|nested] 6+ messages in thread