* [OE-core][scarthgap][PATCH] python3-mako: Fix CVE-2026-41205
@ 2026-08-19 11:15 Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
2026-08-31 9:12 ` Yoann Congal
0 siblings, 1 reply; 4+ messages in thread
From: Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) @ 2026-08-19 11:15 UTC (permalink / raw)
To: openembedded-core; +Cc: xe-linux-external, Hetvi Thakar
From: Hetvi Thakar <hthakar@cisco.com>
This patch applies the upstream fix as referenced in [2], using
the commit shown in [1].
The backport makes Template URI normalization strip all leading
slashes, preventing a double-slash URI from bypassing the path
traversal check while keeping Mako at version 1.3.2.
[1] https://github.com/sqlalchemy/mako/commit/e05ac61989a7fb9dd7dcde6cfd72dc48328719a3
[2] https://github.com/advisories/GHSA-v92g-xgxw-vvmm
Signed-off-by: Hetvi Thakar <hthakar@cisco.com>
---
.../python/python3-mako/CVE-2026-41205.patch | 110 ++++++++++++++++++
.../python/python3-mako_1.3.2.bb | 2 +
2 files changed, 112 insertions(+)
create mode 100644 meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
diff --git a/meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch b/meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
new file mode 100644
index 0000000000..0699654b53
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
@@ -0,0 +1,110 @@
+From e05ac61989a7fb9dd7dcde6cfd72dc48328719a3 Mon Sep 17 00:00:00 2001
+From: Mike Bayer <mike_mp@zzzcomputing.com>
+Date: Tue, 14 Apr 2026 15:45:19 -0400
+Subject: [PATCH] Fix path traversal via double-slash URI prefix in
+ TemplateLookup
+
+The URI normalization in Template.__init__ stripped only a single
+leading slash, while TemplateLookup.get_template() stripped all
+leading slashes. A URI such as "//../../secret.txt" could bypass
+the directory traversal check. Changed to use lstrip("/") so
+both code paths handle leading slashes consistently.
+
+Fixes: #434
+Change-Id: I400b9a40aed956cc2b5826a9c8736f104e84f1a4
+
+CVE: CVE-2026-41205
+Upstream-Status: Backport [https://github.com/sqlalchemy/mako/commit/e05ac61989a7fb9dd7dcde6cfd72dc48328719a3]
+
+(cherry picked from commit e05ac61989a7fb9dd7dcde6cfd72dc48328719a3)
+Signed-off-by: Hetvi Thakar <hthakar@cisco.com>
+---
+ doc/build/unreleased/434.rst | 10 +++++++++
+ mako/template.py | 4 +---
+ test/test_lookup.py | 41 ++++++++++++++++++++++++++++++++++++
+ 3 files changed, 52 insertions(+), 3 deletions(-)
+ create mode 100644 doc/build/unreleased/434.rst
+
+diff --git a/doc/build/unreleased/434.rst b/doc/build/unreleased/434.rst
+new file mode 100644
+index 00000000..452265ad
+--- /dev/null
++++ b/doc/build/unreleased/434.rst
+@@ -0,0 +1,10 @@
++.. change::
++ :tags: bug, template
++ :tickets: 434
++
++ Fixed issue in :class:`.TemplateLookup` where a URI with a double-slash
++ prefix (e.g. ``//../../``) could bypass the directory traversal check in
++ :class:`.Template`, allowing reads of arbitrary files outside of the
++ template directory. The issue was caused by an inconsistency in how leading
++ slashes were stripped between :meth:`.TemplateLookup.get_template` and
++ :class:`.Template` initialization.
+diff --git a/mako/template.py b/mako/template.py
+index 82c7cba8..d8ebc949 100644
+--- a/mako/template.py
++++ b/mako/template.py
+@@ -259,9 +259,7 @@ def __init__(
+ self.module_id = "memory:" + hex(id(self))
+ self.uri = self.module_id
+
+- u_norm = self.uri
+- if u_norm.startswith("/"):
+- u_norm = u_norm[1:]
++ u_norm = self.uri.lstrip("/")
+ u_norm = os.path.normpath(u_norm)
+ if u_norm.startswith(".."):
+ raise exceptions.TemplateLookupException(
+diff --git a/test/test_lookup.py b/test/test_lookup.py
+index 6a797d7a..2f7cdf0b 100644
+--- a/test/test_lookup.py
++++ b/test/test_lookup.py
+@@ -127,6 +127,47 @@ def test_dont_accept_relative_outside_of_root(self):
+ # this is OK since the .. cancels out
+ runtime._lookup_template(ctx, "foo/../index.html", index.uri)
+
++ def test_dont_accept_relative_outside_of_root_via_double_slash(self):
++ """test that double-slash URI prefix can't bypass the
++ path traversal check"""
++ with tempfile.TemporaryDirectory() as base:
++ tmpl_dir = os.path.join(base, "app", "templates")
++ os.makedirs(tmpl_dir)
++ with open(os.path.join(tmpl_dir, "index.html"), "w") as f:
++ f.write("Hello")
++
++ secret = os.path.join(base, "secrets", "creds.txt")
++ os.makedirs(os.path.dirname(secret))
++ with open(secret, "w") as f:
++ f.write("SECRET_KEY=supersecret123")
++
++ tl = lookup.TemplateLookup(directories=[tmpl_dir])
++ rel = os.path.relpath(secret, tmpl_dir)
++
++ # single-slash prefix should also be blocked
++ assert_raises_message(
++ exceptions.TemplateLookupException,
++ "cannot be relative outside of the root path",
++ tl.get_template,
++ "/" + rel,
++ )
++
++ # double-slash prefix must not bypass the check
++ assert_raises_message(
++ exceptions.TemplateLookupException,
++ "cannot be relative outside of the root path",
++ tl.get_template,
++ "//" + rel,
++ )
++
++ # triple-slash prefix must not bypass the check
++ assert_raises_message(
++ exceptions.TemplateLookupException,
++ "cannot be relative outside of the root path",
++ tl.get_template,
++ "///" + rel,
++ )
++
+ def test_checking_against_bad_filetype(self):
+ with tempfile.TemporaryDirectory() as tempdir:
+ tl = lookup.TemplateLookup(directories=[tempdir])
diff --git a/meta/recipes-devtools/python/python3-mako_1.3.2.bb b/meta/recipes-devtools/python/python3-mako_1.3.2.bb
index f9a8f60ff0..a328985a07 100644
--- a/meta/recipes-devtools/python/python3-mako_1.3.2.bb
+++ b/meta/recipes-devtools/python/python3-mako_1.3.2.bb
@@ -10,6 +10,8 @@ PYPI_PACKAGE = "Mako"
inherit pypi python_setuptools_build_meta
+SRC_URI += "file://CVE-2026-41205.patch \
+ "
SRC_URI[sha256sum] = "2a0c8ad7f6274271b3bb7467dd37cf9cc6dab4bc19cb69a4ef10669402de698e"
RDEPENDS:${PN} = "python3-html \
--
2.35.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core][scarthgap][PATCH] python3-mako: Fix CVE-2026-41205
2026-08-19 11:15 [OE-core][scarthgap][PATCH] python3-mako: Fix CVE-2026-41205 Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
@ 2026-08-31 9:12 ` Yoann Congal
2026-08-31 9:22 ` [scarthgap][PATCH] " Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
0 siblings, 1 reply; 4+ messages in thread
From: Yoann Congal @ 2026-08-31 9:12 UTC (permalink / raw)
To: hthakar, openembedded-core; +Cc: xe-linux-external
On Wed Aug 19, 2026 at 1:15 PM CEST, Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) via lists.openembedded.org wrote:
> From: Hetvi Thakar <hthakar@cisco.com>
>
> This patch applies the upstream fix as referenced in [2], using
> the commit shown in [1].
>
> The backport makes Template URI normalization strip all leading
> slashes, preventing a double-slash URI from bypassing the path
> traversal check while keeping Mako at version 1.3.2.
>
> [1] https://github.com/sqlalchemy/mako/commit/e05ac61989a7fb9dd7dcde6cfd72dc48328719a3
> [2] https://github.com/advisories/GHSA-v92g-xgxw-vvmm
>
> Signed-off-by: Hetvi Thakar <hthakar@cisco.com>
> ---
> .../python/python3-mako/CVE-2026-41205.patch | 110 ++++++++++++++++++
> .../python/python3-mako_1.3.2.bb | 2 +
> 2 files changed, 112 insertions(+)
> create mode 100644 meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
Hello,
As fas as I can tell, a fix for this CVE is also needed on wrynose.
I can't merge here until this is fixed there.
Can you send a patch to fix this and then, ping back here?
Thanks!
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [scarthgap][PATCH] python3-mako: Fix CVE-2026-41205
2026-08-31 9:12 ` Yoann Congal
@ 2026-08-31 9:22 ` Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
2026-08-31 9:32 ` [OE-core] " Yoann Congal
0 siblings, 1 reply; 4+ messages in thread
From: Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) @ 2026-08-31 9:22 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]
On Mon, Aug 31, 2026 at 02:42 PM, Yoann Congal wrote:
>
> On Wed Aug 19, 2026 at 1:15 PM CEST, Hetvi Thakar -X (hthakar - E
> INFOCHIPS PRIVATE LIMITED at Cisco) via lists.openembedded.org wrote:
>
>> From: Hetvi Thakar <hthakar@cisco.com>
>>
>> This patch applies the upstream fix as referenced in [2], using
>> the commit shown in [1].
>>
>> The backport makes Template URI normalization strip all leading
>> slashes, preventing a double-slash URI from bypassing the path
>> traversal check while keeping Mako at version 1.3.2.
>>
>> [1] https://github.com/sqlalchemy/mako/commit/e05ac61989a7fb9dd7dcde6cfd72dc48328719a3
>>
>> [2] https://github.com/advisories/GHSA-v92g-xgxw-vvmm
>>
>> Signed-off-by: Hetvi Thakar <hthakar@cisco.com>
>> ---
>> .../python/python3-mako/CVE-2026-41205.patch | 110 ++++++++++++++++++
>> .../python/python3-mako_1.3.2.bb | 2 +
>> 2 files changed, 112 insertions(+)
>> create mode 100644
>> meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
>
> Hello,
>
> As fas as I can tell, a fix for this CVE is also needed on wrynose.
>
> I can't merge here until this is fixed there.
>
> Can you send a patch to fix this and then, ping back here?
>
> Thanks!
> --
> Yoann Congal
> Smile ECS
Hi,
I have submitted a package upgrade for wrynose that addresses this
CVE:
https://lists.openembedded.org/g/openembedded-core/message/244285 ( https://lists.openembedded.org/g/openembedded-core/message/244285 )
Could you please take a look and review it?
Regards,
Hetvi
[-- Attachment #2: Type: text/html, Size: 2138 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [scarthgap][PATCH] python3-mako: Fix CVE-2026-41205
2026-08-31 9:22 ` [scarthgap][PATCH] " Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
@ 2026-08-31 9:32 ` Yoann Congal
0 siblings, 0 replies; 4+ messages in thread
From: Yoann Congal @ 2026-08-31 9:32 UTC (permalink / raw)
To: hthakar, openembedded-core
On Mon Aug 31, 2026 at 11:22 AM CEST, Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco) via lists.openembedded.org wrote:
> On Mon, Aug 31, 2026 at 02:42 PM, Yoann Congal wrote:
>
>>
>> On Wed Aug 19, 2026 at 1:15 PM CEST, Hetvi Thakar -X (hthakar - E
>> INFOCHIPS PRIVATE LIMITED at Cisco) via lists.openembedded.org wrote:
>>
>>> From: Hetvi Thakar <hthakar@cisco.com>
>>>
>>> This patch applies the upstream fix as referenced in [2], using
>>> the commit shown in [1].
>>>
>>> The backport makes Template URI normalization strip all leading
>>> slashes, preventing a double-slash URI from bypassing the path
>>> traversal check while keeping Mako at version 1.3.2.
>>>
>>> [1] https://github.com/sqlalchemy/mako/commit/e05ac61989a7fb9dd7dcde6cfd72dc48328719a3
>>>
>>> [2] https://github.com/advisories/GHSA-v92g-xgxw-vvmm
>>>
>>> Signed-off-by: Hetvi Thakar <hthakar@cisco.com>
>>> ---
>>> .../python/python3-mako/CVE-2026-41205.patch | 110 ++++++++++++++++++
>>> .../python/python3-mako_1.3.2.bb | 2 +
>>> 2 files changed, 112 insertions(+)
>>> create mode 100644
>>> meta/recipes-devtools/python/python3-mako/CVE-2026-41205.patch
>>
>> Hello,
>>
>> As fas as I can tell, a fix for this CVE is also needed on wrynose.
>>
>> I can't merge here until this is fixed there.
>>
>> Can you send a patch to fix this and then, ping back here?
>>
>> Thanks!
>> --
>> Yoann Congal
>> Smile ECS
>
> Hi,
>
> I have submitted a package upgrade for wrynose that addresses this
> CVE:
>
> https://lists.openembedded.org/g/openembedded-core/message/244285 ( https://lists.openembedded.org/g/openembedded-core/message/244285 )
>
> Could you please take a look and review it?
>
> Regards,
> Hetvi
Thanks for the quick answer.
I will review both but not in the current cycle.
Regards,
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-31 9:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 11:15 [OE-core][scarthgap][PATCH] python3-mako: Fix CVE-2026-41205 Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
2026-08-31 9:12 ` Yoann Congal
2026-08-31 9:22 ` [scarthgap][PATCH] " Hetvi Thakar -X (hthakar - E INFOCHIPS PRIVATE LIMITED at Cisco)
2026-08-31 9:32 ` [OE-core] " Yoann Congal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox